Draft: [skip ci] Remove the mr_pipelines_graphql feature flag
What does this MR do and why?
This MR removes the mr_pipelines_graphql feature flag.
It is stacked on !266580, which moves the new merge request page to a GraphQL list behind the same flag.
The flag is enabled by default since !263880 (merged). After this MR, the Pipelines tab always renders a GraphQL list:
- The existing merge request page renders
pipelines_table_wrapper.vue.Projects::MergeRequestsControllerno longer pushes the flag. - The new merge request page renders
new_merge_request_pipelines_list.vue, whenevergl.mrWidgetDatais missing.Projects::MergeRequests::CreationsControllerno longer pushes the flag.
No production code reaches these modules now, so the MR deletes them and their specs:
commit/pipelines/legacy_pipelines_table_wrapper.vuecommit/pipelines/legacy_pipelines_store.jscommit/pipelines/legacy_pipelines_service.jscommit/pipelines/legacy_pipelines_mixin.js
The MR also removes two exports that only the legacy wrapper used:
CREATING_PIPELINE_TOAST_MESSAGEis deleted. Its string stays inlocale/gitlab.pot, because the MR widget uses the same string.validateParamsis no longer exported. Its own module still uses it.
Knip confirmed this list. The check used the script from !265759 (merged), with only the webpack entry points as entries.
The existing merge request page app no longer chooses a table wrapper: it always loads pipelines_table_wrapper.vue, and it drops the endpoint and isMergeRequestTable props that only the legacy wrapper read.
The MR also removes the legacy wrapper from .eslint_todo/local-rules-vue-no-single-use-i-18-n-keys.mjs.
Most of the diff is deleted files. In the feature specs, select Hide whitespace changes: the only change there is that the examples no longer run twice, with the flag on and off.
How knip was run
- Run the script on all of
app/assets/javascriptsandee/app/assets/javascriptsonmaster. This is the baseline. - Run it again with the flag removed. It reports 6 new findings: the 4 modules above and the 2 exports.
- Delete them and run it again. It reports no new findings.
- After the rebase onto !266580, compare the stack tip with
masterand with !266580. Neither comparison has a new finding.
Each run compares the findings with the baseline, so findings that already exist on master do not count.
Not in this MR
- The pipelines table rows still accept REST-shaped rows. The next MR removes those fallbacks: !266262
- No frontend code calls the REST
pipelinesJSON actions inProjects::MergeRequestsControllerandProjects::MergeRequests::CreationsControllernow. No frontend code reads thedata-endpointattribute inprojects/commit/_pipelines_list.hamleither. Knip does not see HAML, so this was checked by hand. Removing them needs backend review, so they are left for #637015.
Screenshots or screen recordings
No visual change is intended. The flag was already enabled by default.
How to set up and validate locally
- Open the Pipelines tab of a merge request that has pipelines. The GraphQL table renders.
- Start a new merge request from a branch with pipelines on more than one commit. Open its Pipelines tab. The GraphQL table lists the pipelines of every commit.
- On each page, select another tab and then Pipelines again. The table renders once.
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Local verification
- Jest passes at the tip of the stack for
spec/frontend/ci/common,spec/frontend/ci/merge_requests,spec/frontend/ci/pipelines_pageandspec/frontend/merge_request_tabs_spec.js. merge_request_tabs_spec.jsandpipelines_table_wrapper_spec.jsalso pass in the Vue 3 lane.- ESLint, Prettier and the lefthook pre-push checks pass.
- The feature specs were not run locally. CI runs them:
user_sees_pipelines_spec.rbuser_sees_merge_request_pipelines_spec.rbuser_sees_pipelines_from_forked_project_spec.rbuser_selects_branches_for_new_mr_spec.rb
References
- Stacked on the new merge request page work for #637319:
- Feature specs: !266595 (merged)
- GraphQL field: !266573 (merged)
- Mount the Pipelines tab with
initVueApp: !269491 (merged) - Frontend: !266580
- This MR
- Remove the REST fallbacks from the table rows: !266262
- Rollout issue: #419726
- Feedback issue for the flag: #608190 (closed)
- Flag enabled by default in !263880 (merged)
- Replaces an earlier attempt that listed the head commit only: !266261 (closed)
- Same removal for the commit Pipelines tab: !249572 (merged)
- Knip script used to confirm the removals: !265759 (merged)
- Follow-up, remove the unused REST endpoints: #637015