Skip to content

Resolve "Follow-up from "Support `license_scanning` in MR and Pipeline""

Tetiana Chupryna requested to merge 201727-follow-up-refactoring into master

What does this MR do?

Fix #201727 (closed)

  • @dosuken123 started a discussion:

    Can we remove this duplicated guard clause? See !23537 (diffs)

  • discussion

    Ideally, we should check an actual job artifact object rather than just an object type, in order to make sure that a artifact for license management is persisted/returned correctly.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Closes #201727 (closed)

Merge request reports