Skip to content
Snippets Groups Projects

Persist Threat Monitoring alert dismissal

Merged Mark Florian requested to merge 14707-persist-threat-monitoring-alert-dismissal-ee into master

What does this MR do?

Persist Threat Monitoring alert dismissal

This ensures that once a user dismisses the info alert on the Threat Monitoring page, it doesn't appear again on subsequent visits.

Part of WAF statistics reporting.

TODO

  • Once !21916 (merged) is merged, rebase and retarget this to master (which is why this is currently WIP)

Screenshots

Note: since the backend isn't done yet, and that this is based on !21916 (merged), these screenshots can only be recreated by first applying this patch: mock_threat_monitoring_apis.patch (apply with git apply <patchfile>)

Not dismissed Dismissed
page_updated page_alert_dismissed

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Edited by Rémy Coutable

Merge request reports

Merge request pipeline #108074797 passed with warnings

Merge request pipeline passed with warnings for bf617edd

Test coverage 87.04% (-0.01%) from 2 jobs

Merged by Kushal PandyaKushal Pandya 5 years ago (Jan 9, 2020 12:43pm UTC)

Loading

Pipeline #108095104 passed with warnings

Pipeline passed with warnings for c05cf762 on master

Test coverage 87.05% (-0.01%) from 2 jobs
4 environments impacted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Mark Florian
  • Mark Florian assigned to @dosuken123 and @shampton

    assigned to @dosuken123 and @shampton

  • Mark Florian changed the description

    changed the description

  • added workflowready for review label and removed workflowin dev label

  • Mark Florian added 38 commits

    added 38 commits

    • 26c0a705 - Remove spinner when approval require input is changed
    • c0c1e3d3 - Ensure search against actual render tree
    • a2ed00bc - Test for no offenses only makes sense with offense
    • cba5dd6d - Replace trigger with emit on component
    • 5ae54a45 - Provide proper mock data for test
    • e5b5a130 - Add js billing plans box to profiles
    • 973e0e31 - Fix shallowMount + stubs tests
    • a384893a - Ensure setData calls are properly handled
    • f6f49861 - Add resource weight tracking
    • 682e7701 - Introduce bulk insert of weight changes for an array of issues
    • 26fa3733 - Generate weight change notes as synthetic notes
    • d58847b7 - Add wait_for_requests method
    • 341cfbae - Fix karma tests in future version of VTU
    • 8be8343a - Wrap trigger into nextEmit calls
    • c1abe977 - Cut and paste Markdown table from a spreadsheet
    • bc9696df - Merge branch 'sh-cut-and-paste-spreadsheets-markdown' into 'master'
    • a05f762c - Move weight note model to EE
    • 429087fd - Documentation for pages size Limitations by Project or Group
    • c314b76f - Merge branch '16610-gitlab-pages-storage-size-limitations-by-project-or-group-3' into 'master'
    • 88b4580b - Merge branch '38090-remove-spinner-on-approval-change' into 'master'
    • 578d8700 - Merge branch 'xanf-vtu-30-trigger' into 'master'
    • 7fc62602 - Merge branch 'xanf-vtu-30-outdated-search' into 'master'
    • 1eb92778 - Merge branch 'xanf-vtu-30-karma' into 'master'
    • ad910438 - Merge branch 'xanf-vtu-beta30' into 'master'
    • 9bb91e4f - Merge branch '119204-users-in-personal-trials-should-be-able-to-upgrade' into 'master'
    • cea105fe - Stop exposing MR refs in favor of persistent pipeline refs
    • 6b3d82ef - Merge branch '38096-create-resource-weight-events-table-pd' into 'master'
    • 9ced482f - Merge branch 'stop-exposing-mr-refs-in-favor-of-persistent-refs' into 'master'
    • 8fc0d79a - Merge branch 'qa-shl-wait-for-requests' into 'master'
    • 97f28e0a - Merge branch 'ab/add-column-with-default-specs' into 'master'
    • f905a752 - Merge branch 'xanf-vtu-30-trigger-emit' into 'master'
    • ebb9d17d - Merge branch 'xanf-vtu-30-proper-mock-data' into 'master'
    • bbbc58a1 - Merge branch 'xanf-vtu-30-mount' into 'master'
    • 766403c7 - Render Threat Monitoring statistics
    • 81b6c18d - Use plural form for enum
    • ab3b4852 - Format the chart tooltip according to designs
    • 24ac41f5 - Persist Threat Monitoring alert dismissal
    • bdae47cf - Swap order of series

    Compare with previous version

  • Mark Florian assigned to @rossfuhrman and unassigned @dosuken123

    assigned to @rossfuhrman and unassigned @dosuken123

  • Mark Florian added 5 commits

    added 5 commits

    • bdae47cf...1735368e - 4 commits from branch 14707-add-threat-monitoring-charts-ee
    • 4d3120cb - Persist Threat Monitoring alert dismissal

    Compare with previous version

  • Mark Florian added 2 commits

    added 2 commits

    • e17a3d85 - 1 commit from branch 14707-add-threat-monitoring-charts-ee
    • 75b8a41b - Persist Threat Monitoring alert dismissal

    Compare with previous version

  • Mark Florian added 1 commit

    added 1 commit

    • 61d54f21 - Persist Threat Monitoring alert dismissal

    Compare with previous version

  • rossfuhrman approved this merge request

    approved this merge request

  • Mark Florian added 163 commits

    added 163 commits

    Compare with previous version

  • Mark Florian marked the checklist item Once !21916 (merged) is merged, rebase and retarget this to master (which is why this is currently WIP) as completed

    marked the checklist item Once !21916 (merged) is merged, rebase and retarget this to master (which is why this is currently WIP) as completed

  • Mark Florian unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Mark Florian changed target branch from 14707-add-threat-monitoring-charts-ee to master

    changed target branch from 14707-add-threat-monitoring-charts-ee to master

  • Mark Florian assigned to @lauraMon and unassigned @shampton

    assigned to @lauraMon and unassigned @shampton

  • Laura Montemayor approved this merge request

    approved this merge request

  • Laura Montemayor unassigned @lauraMon

    unassigned @lauraMon

  • Mark Florian resolved all threads

    resolved all threads

  • Mark Florian added 244 commits

    added 244 commits

    Compare with previous version

  • Kushal Pandya
  • Mark Florian added 61 commits

    added 61 commits

    Compare with previous version

  • Mark Florian added 120 commits

    added 120 commits

    Compare with previous version

  • Kushal Pandya approved this merge request

    approved this merge request

  • Kushal Pandya resolved all threads

    resolved all threads

  • merged

  • Kushal Pandya mentioned in commit c05cf762

    mentioned in commit c05cf762

  • mentioned in commit 7816adee

  • Mark Florian mentioned in merge request !25858 (merged)

    mentioned in merge request !25858 (merged)

  • mentioned in issue #210561 (closed)

  • Mark Florian mentioned in merge request !26838 (merged)

    mentioned in merge request !26838 (merged)

  • mentioned in issue #213671 (closed)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading