Persist Threat Monitoring alert dismissal
What does this MR do?
Persist Threat Monitoring alert dismissal
This ensures that once a user dismisses the info alert on the Threat Monitoring page, it doesn't appear again on subsequent visits.
Part of WAF statistics reporting.
TODO
-
Once !21916 (merged) is merged, rebase and retarget this to master(which is why this is currently WIP)
Screenshots
Note: since the backend isn't done yet, and that this is based on !21916 (merged), these screenshots can only be recreated by first applying this patch: mock_threat_monitoring_apis.patch (apply with git apply <patchfile>)
| Not dismissed | Dismissed |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines - [-] Merge request performance guidelines
-
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
Merge request reports
Activity
changed milestone to %12.7
assigned to @markrian
1 Message 
CHANGELOG missing: If this merge request doesn’t need a CHANGELOG entry, feel free to ignore this message. You can create one with:
bin/changelog -m 22117 "Persist Threat Monitoring alert dismissal"If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 22117 "Persist Threat Monitoring alert dismissal"Note: Merge requests with ~backstage, ci-build, meta do not trigger this check.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer frontend John Hampton ( @jhampton)Tim Zallmann ( @timzallmann)backend Oswaldo Ferreira ( @oswaldo)Heinrich Lee Yu ( @engwan)Generated by
Edited by 🤖 GitLab Bot 🤖mentioned in issue #14707 (closed)
added 465 commits
-
55a29554...3b793e69 - 464 commits from branch
14707-add-threat-monitoring-charts-ee - 8dbd3939 - Persist Threat Monitoring alert dismissal
-
55a29554...3b793e69 - 464 commits from branch
- Resolved by Mark Florian
This is currently marked WIP because the MR it depends on (!21916 (merged)) hasn't been merged yet. With that said, I think this is otherwise ready.
So, @shampton, would you do an initial frontend review of this, please?
@dosuken123, would you do an initial backend review of this, please?
- Last reply by rossfuhrman
assigned to @dosuken123 and @shampton
added workflowready for review label and removed workflowin dev label
added workflowin review label and removed workflowready for review label
added feature flag label
added 38 commits
- 26c0a705 - Remove spinner when approval require input is changed
- c0c1e3d3 - Ensure search against actual render tree
- a2ed00bc - Test for no offenses only makes sense with offense
- cba5dd6d - Replace trigger with emit on component
- 5ae54a45 - Provide proper mock data for test
- e5b5a130 - Add js billing plans box to profiles
- 973e0e31 - Fix shallowMount + stubs tests
- a384893a - Ensure setData calls are properly handled
- f6f49861 - Add resource weight tracking
- 682e7701 - Introduce bulk insert of weight changes for an array of issues
- 26fa3733 - Generate weight change notes as synthetic notes
- d58847b7 - Add wait_for_requests method
- 341cfbae - Fix karma tests in future version of VTU
- 8be8343a - Wrap trigger into nextEmit calls
- c1abe977 - Cut and paste Markdown table from a spreadsheet
- bc9696df - Merge branch 'sh-cut-and-paste-spreadsheets-markdown' into 'master'
- a05f762c - Move weight note model to EE
- 429087fd - Documentation for pages size Limitations by Project or Group
- c314b76f - Merge branch '16610-gitlab-pages-storage-size-limitations-by-project-or-group-3' into 'master'
- 88b4580b - Merge branch '38090-remove-spinner-on-approval-change' into 'master'
- 578d8700 - Merge branch 'xanf-vtu-30-trigger' into 'master'
- 7fc62602 - Merge branch 'xanf-vtu-30-outdated-search' into 'master'
- 1eb92778 - Merge branch 'xanf-vtu-30-karma' into 'master'
- ad910438 - Merge branch 'xanf-vtu-beta30' into 'master'
- 9bb91e4f - Merge branch '119204-users-in-personal-trials-should-be-able-to-upgrade' into 'master'
- cea105fe - Stop exposing MR refs in favor of persistent pipeline refs
- 6b3d82ef - Merge branch '38096-create-resource-weight-events-table-pd' into 'master'
- 9ced482f - Merge branch 'stop-exposing-mr-refs-in-favor-of-persistent-refs' into 'master'
- 8fc0d79a - Merge branch 'qa-shl-wait-for-requests' into 'master'
- 97f28e0a - Merge branch 'ab/add-column-with-default-specs' into 'master'
- f905a752 - Merge branch 'xanf-vtu-30-trigger-emit' into 'master'
- ebb9d17d - Merge branch 'xanf-vtu-30-proper-mock-data' into 'master'
- bbbc58a1 - Merge branch 'xanf-vtu-30-mount' into 'master'
- 766403c7 - Render Threat Monitoring statistics
- 81b6c18d - Use plural form for enum
- ab3b4852 - Format the chart tooltip according to designs
- 24ac41f5 - Persist Threat Monitoring alert dismissal
- bdae47cf - Swap order of series
Toggle commit listassigned to @rossfuhrman and unassigned @dosuken123
added 5 commits
-
bdae47cf...1735368e - 4 commits from branch
14707-add-threat-monitoring-charts-ee - 4d3120cb - Persist Threat Monitoring alert dismissal
-
bdae47cf...1735368e - 4 commits from branch