Skip to content
Snippets Groups Projects

Add `description` param to the service access tokens

All threads resolved!

What does this MR do and why?

Add description param to the API endpoint that creates service access tokens.

In addition, we unify all the usage in a single place.

References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

N/A

How to set up and validate locally

All current API endpoints to create access tokens should continue to work and support the description param:

  • POST /api/v4/user/personal_access_tokens
  • POST /api/v4/users/:user_id/personal_access_tokens
  • POST /api/v4/groups/:group_id/access_token
  • POST /api/v4/projects/:project_id/access_token

In addition, POST /api/v4/groups/:group_id/service_accounts/:user_id/personal_access_tokens should support description param.

Edited by Eduardo Sanz García

Merge request reports

Merge train pipeline #1712504802 passed

Merge train pipeline passed for 475f95d8

Merged by Eduardo Sanz GarcíaEduardo Sanz García 1 week ago (Mar 12, 2025 10:15am UTC)

Loading

Pipeline #1712509252 passed

Pipeline passed for a6b4de6b on master

10 environments impacted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Eduardo Sanz García
  • requested review from @dblessing and @nbelokolodov

  • added 1 commit

    • fe12d0c0 - Add `description` param to the service access tokens

    Compare with previous version

  • Drew Blessing
  • Drew Blessing left review comments

    left review comments

  • Drew Blessing approved this merge request

    approved this merge request

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 5bda9dff

    expand test summary
    +--------------------------------------------------------------+
    |                        suites summary                        |
    +---------+--------+--------+---------+-------+-------+--------+
    |         | passed | failed | skipped | flaky | total | result |
    +---------+--------+--------+---------+-------+-------+--------+
    | Verify  | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Release | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Plan    | 3      | 0      | 0       | 0     | 3     | ✅     |
    +---------+--------+--------+---------+-------+-------+--------+
    | Total   | 5      | 0      | 0       | 0     | 5     | ✅     |
    +---------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-cng: :white_check_mark: test report for 5bda9dff

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Create      | 144    | 0      | 22      | 0     | 166   | ✅     |
    | Plan        | 86     | 0      | 8       | 0     | 94    | ✅     |
    | Govern      | 82     | 0      | 12      | 0     | 94    | ✅     |
    | Verify      | 49     | 0      | 23      | 0     | 72    | ✅     |
    | Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
    | Package     | 29     | 0      | 15      | 0     | 44    | ✅     |
    | Data Stores | 31     | 0      | 10      | 0     | 41    | ✅     |
    | Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
    | Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Secure      | 4      | 0      | 4       | 0     | 8     | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
    | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
    | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 443    | 0      | 131     | 0     | 574   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    Edited by ****
  • :tools: Generated by gitlab_quality-test_tooling.


    :snail: Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.

    Click to expand
    Job File Name Duration Expected duration
    #9378978090 spec/features/admin/users/users_spec.rb#L179 Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 66.12 s < 50.13 s
    #9381908172 spec/features/admin/users/users_spec.rb#L179 Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 68.34 s < 50.13 s
    #9384790682 spec/features/admin/users/users_spec.rb#L179 Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 67.21 s < 50.13 s
    Edited by ****
  • Niko Belokolodov resolved all threads

    resolved all threads

  • Niko Belokolodov approved this merge request

    approved this merge request

  • Niko Belokolodov enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Eduardo Sanz García aborted automatic add to merge train because the source branch was updated. Learn more.

    aborted automatic add to merge train because the source branch was updated. Learn more.

  • Eduardo Sanz García added 217 commits

    added 217 commits

    Compare with previous version

  • Eduardo Sanz García enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • mentioned in commit a6b4de6b

  • mentioned in merge request !184291 (merged)

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading