Adds details to Other status in chart
What does this MR do and why?
The "Other" is used to report status of Skipped and Cancelled pipelines, this change adds this detail in the chart.
References
- This was left over from a simplified scope in the original MR.
MR acceptance checklist
Screenshots or screen recordings
See the new label for the Other series in the chart:
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
You can use the steps in the original MR:
Related to #469603 (closed)
Merge request reports
Activity
changed milestone to %17.10
assigned to @mrincon
added pipelinetier-1 label
2 Warnings featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
There were no new or modified feature flag YAML files detected in this MR. If the changes here are already controlled under an existing feature flag, please add
the feature flagexists. Otherwise, if you think the changes here don't need
to be under a feature flag, please add the label feature flagskipped, and
add a short comment about why we skipped the feature flag.For guidance on when to use a feature flag, please see the documentation.
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer frontend @leetickett-gitlab
(UTC+0, 1 hour behind author)
@ekigbo
(UTC+11, 10 hours ahead of author)
UX @gdoyle
(UTC-4, 5 hours behind author)
Maintainer review is optional for UX Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by ****- Resolved by Enrique Alcántara
@gdoyle I found that our gitlab-ui chart's component doesn't allow me to easily customize the appearance of the chart legends (at the bottom of the chart).
This is a simpler alternative that I hope accomplishes the goal of labelling "Other" while sticking to our framework. Can you have a look?
requested review from @gdoyle
mentioned in issue #469603 (closed)
mentioned in issue gitlab-runner#37936 (closed)
removed review request for @gdoyle
mentioned in issue gitlab-design#2774 (closed)
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 8ba294c6 and b755cc3d
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.95 MB 4.95 MB - -0.0 % mainChunk 3.88 MB 3.88 MB - 0.0 % Significant Growth: 2Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.admin.application_settings.general 720.41 KB 740.61 KB +20.21 KB 2.8 % pages.admin.ai.duo_self_hosted 490.38 KB 500.95 KB +10.57 KB 2.2 % Significant Reduction: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.usage_quotas 4.67 MB 4.39 MB -278.69 KB -5.8 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@leipert
,@markrian
,@pgascouvaillancourt
,@sdejonge
or@thutterer
) for review, if you are unsure about the size increase.Note: We do not have exact data for 8ba294c6. So we have used data from: 77b4924c.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by ****E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for b755cc3dexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 82 | 0 | 8 | 2 | 90 | ✅ | | Verify | 48 | 0 | 24 | 1 | 72 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Package | 24 | 0 | 14 | 2 | 38 | ✅ | | Create | 138 | 0 | 22 | 3 | 160 | ✅ | | Govern | 79 | 0 | 13 | 1 | 92 | ✅ | | Secure | 4 | 0 | 4 | 1 | 8 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Data Stores | 31 | 0 | 10 | 0 | 41 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 424 | 0 | 132 | 10 | 556 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for b755cc3dexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Package | 29 | 0 | 15 | 0 | 44 | ✅ | | Govern | 82 | 0 | 12 | 0 | 94 | ✅ | | Create | 142 | 0 | 22 | 0 | 164 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Data Stores | 31 | 0 | 10 | 0 | 41 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Verify | 49 | 0 | 23 | 0 | 72 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Secure | 4 | 0 | 4 | 0 | 8 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 441 | 0 | 131 | 0 | 572 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
Edited by ****