feat: Work items - Close drawer when active card is clicked
-
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you receive complimentary access to GitLab Duo.
Relates to #517393
What does this MR do and why?
Add the capability to close the drawer when an active card is clicked.
Screen recording:
Merge request reports
Activity
mentioned in issue #517393
added devopsplan groupproduct planning sectiondev typefeature labels
added pipelinetier-1 label
Thanks for your contribution to GitLab @vedant-jain03!
Did you know about our community forks? Working from there will make your contribution process easier. Please check it out!
- If you need help, page a coach by clicking here or come say hi on Discord.
- When you're ready, request a review by clicking here.
- We welcome AI-generated contributions and offer complimentary access to GitLab Duo!
- To add labels to your merge request, comment
@gitlab-bot label ~"label1" ~"label2"
.
This message was generated automatically. Improve it or delete it.
added Community contribution workflowin dev labels
assigned to @vedant-jain03
added linked-issue label
requested review from @nickbrandt
Thanks for helping us improve the UX of GitLab. Your contribution is appreciated! We have pinged our UX team, so stay tuned for their feedback.
This message was generated automatically. Improve it or delete it.
Great work @vedant-jain03 and thanks for putting this MR together!
One question:
-
This works great on the Issues and Epics List pages, as well as on both Issue boards and Epic boards. However, it doesn't look like this effects the Child items and Linked items widgets on the work item detail page. Would it be possible to include that here as well?
-
Oops, missed it. Thanks for the catch, @nickbrandt
I have added the commit to acknowledge this.
Fix works great, thanks @vedant-jain03 !
I noticed one other thing, which I missed during original testing as I had
work_items_alpha
FF on. Clicking on an "active" item works on the work item version of the List page, but not on the Issues List (which doesn't yet use the work item version and won't for awhile). Would we be able to address this for that as well? Sorry for not catching initially!@nickbrandt Sure, I have added the changes in a new commit!
Thank you @vedant-jain03 – everything is working great!
Approving for UX@anastasia.khom would you be able to do the frontend review on this?
Thanks for the contribution @vedant-jain03!
Will be able to get to this review tomorrow
added 1 commit
- 3a1c9787 - chore: add toggle capability for linked and child items
added 1072 commits
-
3a1c9787...cb978ad4 - 1069 commits from branch
gitlab-org:master
- 04289c10 - feat: Work items - Close drawer when active card is clicked
- 4c6caaa7 - chore: add toggle capability for linked and child items
- 4f46e020 - chore: add toggle drawer for legacy issue list
Toggle commit list-
3a1c9787...cb978ad4 - 1069 commits from branch
requested review from @anastasia.khom
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.