feat: Work items - Close drawer when active card is clicked
-
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you receive complimentary access to GitLab Duo.
Relates to #517393 (closed)
What does this MR do and why?
Add the capability to close the drawer when an active card is clicked.
Screen recording:
Merge request reports
Activity
mentioned in issue #517393 (closed)
added devopsplan groupproduct planning sectiondev typefeature labels
added pipelinetier-1 label
Thanks for your contribution to GitLab @vedant-jain03!
Did you know about our community forks? Working from there will make your contribution process easier. Please check it out!
- If you need help, page a coach by clicking here or come say hi on Discord.
- When you're ready, request a review by clicking here.
- We welcome AI-generated contributions and offer complimentary access to GitLab Duo!
- To add labels to your merge request, comment
@gitlab-bot label ~"label1" ~"label2".
This message was generated automatically. Improve it or delete it.
added Community contribution workflowin dev labels
assigned to @vedant-jain03
added linked-issue label
requested review from @nickbrandt
-
Thanks for helping us improve the UX of GitLab. Your contribution is appreciated! We have pinged our UX team, so stay tuned for their feedback.
This message was generated automatically. Improve it or delete it.
- Resolved by Natalia Tepluhina
Great work @vedant-jain03 and thanks for putting this MR together!
One question:
-
This works great on the Issues and Epics List pages, as well as on both Issue boards and Epic boards. However, it doesn't look like this effects the Child items and Linked items widgets on the work item detail page. Would it be possible to include that here as well?
Screen capture
-
- Last reply by Anastasia Khomchenko
added 1 commit
- 3a1c9787 - chore: add toggle capability for linked and child items
added 1072 commits
-
3a1c9787...cb978ad4 - 1069 commits from branch
gitlab-org:master - 04289c10 - feat: Work items - Close drawer when active card is clicked
- 4c6caaa7 - chore: add toggle capability for linked and child items
- 4f46e020 - chore: add toggle drawer for legacy issue list
Toggle commit list-
3a1c9787...cb978ad4 - 1069 commits from branch
requested review from @anastasia.khom
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
-
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
- Resolved by Natalia Tepluhina
Thanks so much for picking this up @vedant-jain03! I personally think this is a great addition to our UX.
I just have a few suggestions/questions. Let me know what you think! Back to you
- Last reply by Natalia Tepluhina
requested review from @anastasia.khom
requested review from @ntepluhina
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
5 Warnings 
a6f399b9: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. c17ee1ac: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. 8f21bfb6: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. 421b4c13: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. This merge request does not refer to an existing milestone. 2 Messages 
This merge request includes changes to Vue files that have both CE and EE versions. CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelogtrailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Vue
<template>in CE and EESome Vue files in CE have a counterpart in EE. (For example,
path/to/file.vueandee/path/to/file.vue.)When run in the context of CE, the
<template>of the CE Vue file is used. When run in the context of EE, the<template>of the EE Vue file is used.It's easy to accidentally make a change to a CE
<template>that should appear in both CE and EE without making the change in both places. When this happens, the change only takes effect in CE.The following Vue files were changed as part of this merge request that include both a CE and EE version of the file:
app/assets/javascripts/issues/list/components/issues_list_app.vueapp/assets/javascripts/work_items/pages/work_items_list_app.vue
If you made a change to the
<template>of any of these Vue files that should be visible in both CE and EE, please ensure you have made your change to both versions of the file.A better alternative
An even better alternative is to refactor this component to only use a single template for both CE and EE. More info on this approach here: https://docs.gitlab.com/development/ee_features/#template-tag
Reviewer roulette
Category Reviewer Maintainer frontend @marina.mosti
(UTC+1)@himkp (UTC+1)UX @nickbrandt (UTC-6)Maintainer review is optional for UX Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-reviewjob that generated this comment.Generated by
Edited by ****Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 190385ee and a6f399b9
Entrypoint / Name Size before Size after Diff Diff in percent average 4.95 MB 4.95 MB - 0.0 % mainChunk 3.88 MB 3.88 MB - 0.0 %
Note: We do not have exact data for 190385ee. So we have used data from: fe66a577.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
E2E Test Result Summary
allure-report-publishergenerated test report!e2e-test-on-gdk:
expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 138 | 0 | 22 | 3 | 160 | ✅ | | Govern | 79 | 0 | 13 | 1 | 92 | ✅ | | Data Stores | 31 | 0 | 10 | 0 | 41 | ✅ | | Plan | 82 | 0 | 8 | 2 | 90 | ✅ | | Package | 24 | 0 | 14 | 1 | 38 | ✅ | | Verify | 48 | 0 | 24 | 1 | 72 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Secure | 5 | 0 | 3 | 1 | 8 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 425 | 0 | 131 | 9 | 556 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+e2e-test-on-cng:
expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 142 | 0 | 22 | 0 | 164 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Verify | 49 | 0 | 23 | 0 | 72 | ✅ | | Package | 29 | 0 | 15 | 0 | 44 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Data Stores | 31 | 0 | 10 | 0 | 41 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Secure | 5 | 0 | 3 | 0 | 8 | ✅ | | Govern | 82 | 0 | 12 | 0 | 94 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 442 | 0 | 130 | 0 | 572 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+Edited by ****- Resolved by Natalia Tepluhina
@vedant-jain03 it looks like we have one of work item feature specs failing. Would you mind rebasing onto latest
masterto check whether the problem persists? - Last reply by Vedant Jain
added 1746 commits
-
e2cbaaa0...2f5e8d3c - 1742 commits from branch
gitlab-org:master - 30753500 - feat: Work items - Close drawer when active card is clicked
- 319cdbb4 - chore: add toggle capability for linked and child items
- 79fcd9b4 - chore: add toggle drawer for legacy issue list
- 445d3b0a - fix: refactor optional chaining
Toggle commit list-
e2cbaaa0...2f5e8d3c - 1742 commits from branch
reset approvals from @ntepluhina by pushing to the branch
added 99 commits
-
445d3b0a...6b24b569 - 95 commits from branch
gitlab-org:master - a642c75e - feat: Work items - Close drawer when active card is clicked
- 421b4c13 - chore: add toggle capability for linked and child items
- 8f21bfb6 - chore: add toggle drawer for legacy issue list
- c17ee1ac - fix: refactor optional chaining
Toggle commit list-
445d3b0a...6b24b569 - 95 commits from branch
reset approvals from @ntepluhina by pushing to the branch
added 1 commit
- a6f399b9 - chore: fix the immediate closing of drawer on editing the widgets
reset approvals from @ntepluhina by pushing to the branch
