17.5: Fix ability to use password for Git when password for Web is disabled
What does this MR do and why?
This MR backports !175160 (merged) to 17.5
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch. -
The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes). -
This MR has a severity label assigned (if applicable). -
Set the milestone of the merge request to match the target backport branch version. -
This MR has been approved by a maintainer (only one approval is required). -
Ensure the e2e:test-on-omnibus-ee
job has either succeeded or been approved by a Software Engineer in Test.
Note to the merge request author and maintainer
If you have questions about the patch release process, please:
- Refer to the patch release runbook for engineers and maintainers for guidance.
- Ask questions on the
#releases
Slack channel (internal only).
Merge request reports
Activity
added Enterprise Edition typefeature labels
assigned to @bdenkovych
added pipelinetier-1 label
changed milestone to %17.7
added Category:System Access Deliverable backend bugfunctional devopssoftware supply chain security groupauthentication pipelinetier-3 pipeline:mr-approved pipeline:run-e2e-omnibus-once priority1 regression regression:17.5 rspec:slow test detected sectionsec self-managed severity2 typebug workflowin dev labels and removed pipelinetier-1 typefeature labels
changed milestone to %17.5
removed rspec:slow test detected label
4 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.e1f45da7: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. Backporting to older releases requires an exception request process The e2e:test-on-omnibus-ee
job needs to succeed or have approval from a Software Engineer in Test.
Read the "QA e2e:test-on-omnibus-ee" section for more details.Reviewer roulette
Category Reviewer Maintainer backend @missy-gitlab
(UTC-5, 7 hours behind author)
@sgarg_gitlab
(UTC+5.5, 3.5 hours ahead of author)
test for spec/features/*
@missy-gitlab
(UTC-5, 7 hours behind author)
Maintainer review is optional for test for spec/features/*
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
QA
e2e:test-on-omnibus-ee
@bdenkovych, the
e2e:test-on-omnibus
job must complete before merging this merge request.*If there are failures on the
e2e:test-on-omnibus
pipeline, ping your team's associated Software Engineer in Test (SET) to confirm the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the#test-platform
Slack channel.If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in issue gitlab-org/release/tasks#15782 (closed)
requested review from @dblessing
Generated bygitlab_quality-test_tooling
.
Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #8600425200 spec/features/admin/users/users_spec.rb#L177
Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 66.36 s < 50.13 s - A deleted user
added rspec:slow test detected label
- Resolved by Adil Farrukh
@dblessing
, thanks for approving this merge request.This is the first time the merge request has been approved. Please ensure the
e2e:test-on-omnibus-ee
job has succeeded. If there is a failure, a Software Engineer in Test (SET) needs to confirm the failures are unrelated to the merge request. If there's no SET assigned to this team, ask for assistance on the#test-platform
Slack channel.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-omnibus:
test report for e1f45da7expand test summary
+---------------------------------------------------------------------+ | suites summary | +----------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 46 | 0 | 1 | 0 | 47 | ✅ | | Analytics | 3 | 0 | 0 | 0 | 3 | ✅ | | Govern | 99 | 0 | 1 | 0 | 100 | ✅ | | Monitor | 12 | 0 | 2 | 0 | 14 | ✅ | | Create | 540 | 7 | 64 | 0 | 611 | ❌ | | Fulfillment | 4 | 0 | 0 | 1 | 4 | ✅ | | Package | 32 | 0 | 0 | 0 | 32 | ✅ | | Systems | 6 | 0 | 1 | 0 | 7 | ✅ | | Manage | 26 | 0 | 10 | 1 | 36 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Plan | 83 | 0 | 1 | 0 | 84 | ✅ | | Secure | 5 | 0 | 0 | 0 | 5 | ✅ | | Configure | 1 | 0 | 0 | 0 | 1 | ✅ | | Verify | 42 | 0 | 3 | 0 | 45 | ✅ | | Ai-powered | 0 | 1 | 0 | 0 | 1 | ❌ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | +----------------+--------+--------+---------+-------+-------+--------+ | Total | 906 | 8 | 84 | 2 | 998 | ❌ | +----------------+--------+--------+---------+-------+-------+--------+
removed pipeline:run-e2e-omnibus-once label
changed milestone to %17.7
added missed-deliverable missed:17.5 labels
mentioned in issue #503361 (closed)
mentioned in issue #504880 (closed)
requested review from @hmuralidhar
changed milestone to %17.5
changed milestone to %17.7
changed milestone to %17.8
added missed:17.7 label
changed milestone to %17.5
changed milestone to %17.8
- Resolved by Adil Farrukh
Will this be merged in the 17.5.5 patch?
assigned to @mayra-cabrera, @anganga, and @madelacruz
mentioned in commit 9b9f221a
changed milestone to %17.5
We also have this problem and after installing patch 17.5.5, we can use the password for git again, but only for local users. Users with an external identity (openid connect and LDAP) still don't work with password.
Do you have an explanation/solution ?
Edited by Johan Thys