Fix ability to use password for Git when password for Web is disabled
What does this MR do and why?
In !168111 (comment 2152596436) we had assumed that when password for Web is disabled, it should be disabled for any activities, including Git activity. We did this change without thorough consideration and discussion. That change turned out to be a regression as per feedback we've received from users[1, 2, 3, 4].
This MR eliminates the regression.
Related to #503361 (closed)
Also, in #504880 (closed) it was reported that login to registry with password was affected by the same regression. I didn't add specs to confirm the fix for registry, but I can create a follow-up MR if anybody guides me how to write specs for registry.
References
Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
- #503361 (closed)
- #504880 (closed)
- https://gitlab.com/gitlab-com/sec-sub-department/section-sec-request-for-help/-/issues/473
- #501653 (closed)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
assigned to @bdenkovych
changed milestone to %17.7
added pipelinetier-1 label
- A deleted user
added backend label
2 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.1c295073: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. Reviewer roulette
Category Reviewer Maintainer backend @gonzoyumo
(UTC-5, 7 hours behind author)
@mfangitlab
(UTC-8, 10 hours behind author)
test for spec/features/*
@gonzoyumo
(UTC-5, 7 hours behind author)
Maintainer review is optional for test for spec/features/*
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Adil Farrukh
- Resolved by Adil Farrukh
- Resolved by Adil Farrukh
requested review from @dblessing
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 1c295073expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 48 | 0 | 4 | 0 | 52 | ✅ | | Create | 129 | 0 | 3 | 0 | 132 | ✅ | | Plan | 82 | 0 | 1 | 0 | 83 | ✅ | | Govern | 78 | 0 | 2 | 0 | 80 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Data Stores | 33 | 0 | 0 | 0 | 33 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Package | 25 | 0 | 0 | 0 | 25 | ✅ | | Monitor | 8 | 0 | 1 | 0 | 9 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 417 | 0 | 11 | 0 | 428 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for 1c295073expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 84 | 0 | 10 | 1 | 94 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Create | 140 | 0 | 19 | 1 | 159 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Verify | 49 | 0 | 16 | 0 | 65 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Analytics | 2 | 0 | 0 | 1 | 2 | ✅ | | Fulfillment | 2 | 0 | 7 | 1 | 9 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Secure | 2 | 0 | 5 | 0 | 7 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 436 | 0 | 119 | 4 | 555 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
mentioned in issue gitlab-org/release/tasks#15782 (closed)
added 1 commit
- 1c295073 - Test "Disable password authentication for users with an SSO identity"
reset approvals from @dblessing by pushing to the branch
Generated bygitlab_quality-test_tooling
.
Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #8598222078 spec/features/admin/users/users_spec.rb#L177
Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 69.58 s < 50.13 s #8605487379 spec/features/admin/users/users_spec.rb#L177
Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking 66.03 s < 50.13 s - A deleted user
added rspec:slow test detected label
requested review from @ifarkas
- Resolved by Adil Farrukh
Thanks @bdenkovych! Looks good to me.
mentioned in merge request !175272 (merged)
mentioned in merge request !175274 (merged)
removed review request for @dblessing
requested review from @atevans
requested review from @dblessing
started a merge train
mentioned in commit d41364fd
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in issue #503361 (closed)
mentioned in issue #504880 (closed)
mentioned in merge request !170421 (merged)
added workflowpost-deploy-db-staging label and removed workflowproduction label
added releasedcandidate self-managed labels and removed self-managed label
added releasedpublished self-managed labels and removed releasedcandidate self-managed labels