Fix ability to use password for Git when password for Web is disabled
What does this MR do and why?
In !168111 (comment 2152596436) we had assumed that when password for Web is disabled, it should be disabled for any activities, including Git activity. We did this change without thorough consideration and discussion. That change turned out to be a regression as per feedback we've received from users[1, 2, 3, 4].
This MR eliminates the regression.
Related to #503361 (closed)
Also, in #504880 (closed) it was reported that login to registry with password was affected by the same regression. I didn't add specs to confirm the fix for registry, but I can create a follow-up MR if anybody guides me how to write specs for registry.
References
Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
- #503361 (closed)
- #504880 (closed)
- https://gitlab.com/gitlab-com/sec-sub-department/section-sec-request-for-help/-/issues/473
- #501653 (closed)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| Before | After |
|---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.