Tree table: Migrate classes used to design tokens
What does this MR do and why?
Tree table:
- Migrate bootstrap classes to Tailwind
- Use design tokens for colors
- Fixes a small bug when the tree item is a single cell
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
Related to #474922 (closed)
Merge request reports
Activity
changed milestone to %17.6
assigned to @seggenberger
added devopsfoundations groupux paper cuts labels
- Resolved by Sascha Eggenberger
requested review from @annabeldunstone
added sectioncore platform label and removed sectiondev label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels
added 168 commits
-
426e5ed1...594f985c - 167 commits from branch
master
- 39e4f246 - Merge branch 'sf/feature/standards_adherence_lighthouse-472145' into 'master'
-
426e5ed1...594f985c - 167 commits from branch
- A deleted user
2 Warnings For the following files, a review from the Data team and Analytics Instrumentation team is recommended
Please check the analytics instrumentation Service Ping guide or the Snowplow guide.For MR review guidelines, see the Internal Analytics review guidelines.
ee/config/events/visit_standards_adherence.yml
ee/config/metrics/counts_28d/count_distinct_namespace_id_from_standards_adherence_with_active_compliance_frameworks_monthly.yml
ee/config/metrics/counts_28d/count_distinct_namespace_id_from_viewed_standards_adherence_usage_monthly.yml
This merge request contains lines with testid selectors. Please ensure e2e:test-on-omnibus
job is run.testid
selectorsThe following changed lines in this MR contain
testid
selectors:app/assets/javascripts/repository/components/table/row.vue
- <gl-badge v-if="lfsOid" variant="muted" class="ml-1" data-testid="label-lfs">LFS</gl-badge> + <gl-badge v-if="lfsOid" variant="muted" class="gl-ml-2" data-testid="label-lfs">LFS</gl-badge>
If the
e2e:test-on-omnibus
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:test-on-omnibus-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer analytics instrumentation No engineer is available for automated assignment, please reach out to the #g_analyze_analytics_instrumentation
Slack channel or mention@gitlab-org/analytics-section/analytics-instrumentation/engineers
for assistance.Maintainer review is optional for analytics instrumentation backend @syarynovskyi
(UTC+2, 1 hour ahead of author)
@seanarnold
(UTC+13, 12 hours ahead of author)
frontend @leetickett-gitlab
(UTC+0, 1 hour behind author)
@psimyn
(UTC+11, 10 hours ahead of author)
UX @jmiocene
(UTC+1, same timezone as author)
Maintainer review is optional for UX Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 30dfe07a and 80b90a23
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.4 MB 4.4 MB - 0.0 % mainChunk 3.31 MB 3.31 MB - 0.0 %
Note: We do not have exact data for 30dfe07a. So we have used data from: 8101d20a.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerE2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 80b90a23expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 56 | 0 | 1 | 0 | 57 | ✅ | | Govern | 35 | 0 | 3 | 0 | 38 | ✅ | | Plan | 59 | 0 | 0 | 0 | 59 | ✅ | | Verify | 38 | 0 | 1 | 0 | 39 | ✅ | | Package | 24 | 0 | 0 | 0 | 24 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Data Stores | 15 | 0 | 0 | 0 | 15 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Release | 4 | 0 | 0 | 0 | 4 | ✅ | | Monitor | 3 | 0 | 0 | 0 | 3 | ✅ | | Fulfillment | 1 | 0 | 0 | 0 | 1 | ✅ | | Analytics | 1 | 0 | 0 | 0 | 1 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 241 | 0 | 5 | 0 | 246 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for 80b90a23expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 139 | 0 | 21 | 0 | 160 | ✅ | | Verify | 50 | 0 | 15 | 0 | 65 | ✅ | | Govern | 84 | 0 | 9 | 3 | 93 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Secure | 1 | 0 | 6 | 0 | 7 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 435 | 0 | 120 | 3 | 555 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
added pipeline:mr-approved label
added 1 commit
- 80b90a23 - Merge branch 'sf/feature/standards_adherence_lighthouse-472145' into 'master'
- Resolved by Janis Altherr
Hey @syarynovskyi can you review frontend here? TY!
requested review from @syarynovskyi
requested review from @janis
removed review request for @syarynovskyi
started a merge train
mentioned in commit 14bb0c97
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label