Add specs to test for_role scopes
What does this MR do and why?
Add specs to test for_role scopes
This change adds test to cover the for_role scope.
Also removes a duplicated spec which is already covered in the shared examples.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| Before | After |
|---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
changed milestone to %17.5
assigned to @jwoodwardgl
removed pipeline:run-e2e-omnibus-once label
removed pipelinetier-3 label
added pipelinetier-1 label
mentioned in merge request !143573 (merged)
1 Warning ⚠ 37b7d095: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. Reviewer roulette
Category Reviewer Maintainer backend @missy-gitlab
(UTC-4, 5 hours behind author)@vshushlin (UTC+2, 1 hour ahead of author)Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
🔁 danger-reviewjob that generated this comment.Generated by
🚫 DangerEdited by Ghost Userrequested review from @nisong
- Resolved by Joe Woodward
Thanks @jwoodwardgl for adding this, I left a suggestion, let me know what you think..
- Last reply by Joe Woodward
removed review request for @nisong
-
@vshushlin can you review the backend please
requested review from @vshushlin
- Resolved by Vladimir Shushlin
Thanks, @jwoodwardgl!
One tiny suggestion, otherwise LGTM
👍 - Last reply by Joe Woodward
