Finalize migration BackfillApprovalMergeRequestRulesProjectId
This migration was finished at 2024-05-19 05:28:03 UTC
, you can confirm
the status using our
batched background migration chatops commands.
To confirm it is finished you can run:
/chatops run batched_background_migrations status 1000542
The last time this background migration was triggered was in db/post_migrate/20240501044351_queue_backfill_approval_merge_request_rules_project_id.rb
You can read more about the process for finalizing batched background migrations in https://docs.gitlab.com/ee/development/database/batched_background_migrations.html .
As part of our process we want to ensure all batched background migrations have had at least one required stop to process the migration. Therefore we can finalize any batched background migration that was added before the last required stop.
This change was generated by gitlab-housekeeper using the Keeps::OverdueFinalizeBackgroundMigration keep.
To provide feedback on your experience with gitlab-housekeeper
please create an issue with the
label GitLab Housekeeper and consider pinging the author of this keep.
Merge request reports
Activity
requested review from @marc_shaw
added devopscreate sectiondev labels
added 1 commit
- e32f9c04 - Finalize migration BackfillApprovalMergeRequestRulesProjectId
added typemaintenance label
added pipelinetier-1 label
- A deleted user
added database databasereview pending labels
- Resolved by Michał Zając
4 Warnings d8d4c9b3: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. New migrations added but db/structure.sql wasn't updated Usually, when adding new migrations, db/structure.sql should be
updated too (unless the migration isn't changing the DB schema
and isn't the most recent one).This merge request does not have any assignee yet. Setting an assignee clarifies who needs to take action on the merge request at any given time. You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Category Reviewer Maintainer database @johnmason
(UTC-4)
@Quintasan
(UTC+2)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Useradded automation:bot-authored label
changed milestone to %17.5
Database migrations (on the main database)
Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).
Migration Type Total runtime Result DB size change 20240925232222 - FinalizeBackfillApprovalMergeRequestRulesProjectId Post deploy 4.9 s +0.00 B Runtime Histogram for all migrations
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 2 0.1 seconds - 1 second 3 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0 Migration: 20240925232222 - FinalizeBackfillApprovalMergeRequestRulesProjectId
- Type: Post deploy
- Duration: 4.9 s
- Database size change: +0.00 B
Calls Total Time Max Time Mean Time Rows Query 1 3.7 ms 3.7 ms 3.7 ms 1 UPDATE "batched_background_migrations" SET "updated_at" = $1, "status" = $2
WHERE "batched_background_migrations"."id" = $31 2.2 ms 2.2 ms 2.2 ms 1 SELECT "batched_background_migrations".*
FROM "batched_background_migrations" WHERE "batched_background_migrations"."job_class_name" = $1 AND "batched_background_migrations"."table_name" = $2 AND "batched_background_migrations"."column_name" = $3 AND (job_arguments = $4) AND "batched_background_migrations"."gitlab_schema" = $5
ORDER BY "batched_background_migrations"."id" ASC
LIMIT $61 0.0 ms 0.0 ms 0.0 ms 0 SELECT $1 AS one
FROM "batched_background_migrations" WHERE "batched_background_migrations"."job_arguments" = $2 AND "batched_background_migrations"."id" != $3 AND "batched_background_migrations"."job_class_name" = $4 AND "batched_background_migrations"."table_name" = $5 AND "batched_background_migrations"."column_name" = $6
LIMIT $72 0.0 ms 0.0 ms 0.0 ms 2 SELECT pg_backend_pid()
Histogram for FinalizeBackfillApprovalMergeRequestRulesProjectId
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 2 0.1 seconds - 1 second 3 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0 Other information
Other migrations pending on GitLab.com
Migration Type Total runtime Result DB size change 20240922144910 - AddProjectIdToCiUnitTestFailures Regular 5.4 s +0.00 B 20240925021414 - AddWatermarkToZoektIndices Regular 4.4 s +0.00 B 20240830122733 - TrackClusterAgentRecordChanges Post deploy 4.3 s +0.00 B 20240830131630 - RemoveProjectsVulnerabilityReadsProjectIdFk Post deploy 5.1 s +0.00 B 20240830131638 - RemoveClusterAgentsVulnerabilityReadsCastedClusterAgentIdFk Post deploy 4.9 s +0.00 B 20240920072729 - RemoveDanglingCronWorker Post deploy 4.0 s +0.00 B 20240922144911 - IndexCiUnitTestFailuresOnProjectId Post deploy 5.6 s +8.00 KiB [note] 20240922144912 - AddCiUnitTestFailuresProjectIdTrigger Post deploy 4.5 s +0.00 B 20240922144913 - QueueBackfillCiUnitTestFailuresProjectId Post deploy 4.2 s +0.00 B 20240923132238 - RemoveConanInfoColumnsInPackagesConanMetadata Post deploy 5.8 s +0.00 B 20240923154747 - DropIdxSbomSourcePackagesOnNameAndPurlType Post deploy 5.0 s -840.00 KiB 20240923154851 - DropIndexSbomComponentsOnComponentTypeNameAndPurlType Post deploy 5.2 s -32.27 MiB Clone details
Clone ID Clone Created At Clone Data Timestamp Expected Removal Time database-testing-3733742-15484396-main
2024-09-26T08:04:16Z 2024-09-25T15:20:45Z 2024-09-26 20:14:44 +0000 database-testing-3733742-15484396-ci
2024-09-26T08:04:16Z 2024-09-26T04:45:24Z 2024-09-26 20:14:44 +0000 Database migrations (on the ci database)
Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).
Migration Type Total runtime Result DB size change 20240925232222 - FinalizeBackfillApprovalMergeRequestRulesProjectId Post deploy 6.8 s +0.00 B Runtime Histogram for all migrations
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 0 0.1 seconds - 1 second 2 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0 Migration: 20240925232222 - FinalizeBackfillApprovalMergeRequestRulesProjectId
- Type: Post deploy
- Duration: 6.8 s
- Database size change: +0.00 B
Calls Total Time Max Time Mean Time Rows Query 2 0.0 ms 0.0 ms 0.0 ms 2 SELECT pg_backend_pid()
Histogram for FinalizeBackfillApprovalMergeRequestRulesProjectId
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 0 0.1 seconds - 1 second 2 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0 Other information
No other migrations pending on GitLab.com
Clone details
Clone ID Clone Created At Clone Data Timestamp Expected Removal Time database-testing-3733742-15484396-main
2024-09-26T08:04:16Z 2024-09-25T15:20:45Z 2024-09-26 20:14:44 +0000 database-testing-3733742-15484396-ci
2024-09-26T08:04:16Z 2024-09-26T04:45:24Z 2024-09-26 20:14:44 +0000
Brought to you by gitlab-org/database-team/gitlab-com-database-testing. Epic
Edited by ****removed review request for @marc_shaw
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
requested review from @johnmason
- Resolved by Michał Zając
Hola @johnmason
Mind taking the first review here?