Markdown footnote improvements
What does this MR do and why?
- Prevent footnote OL from being reorderable
The ordered list in markdown footnotes is not reorderable, but we present affordances for it in the UI. - Improve styling of footnotes
Add separator style, adjust font size and margins of list items and paragraphs
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
Hovering:
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Check out this branch
- Create an issue in the GDK with footnotes
- The footnotes will be in a section at the bottom of the description with smaller font, with a small divider line above the list of footnotes
- Hover over the footnotes. There will not be a grab handle rendered at the left like normal ordered lists in gitlab markdown.
Example markdown content to create footnotes:
I'm creating a footnote[^1] here as an example of how they are currently[^2] styled.
[^1]: This is my example footnote
[^2]: This is another footnote
Related to #26118 (closed), #482771 (closed), #469616 (closed)
Merge request reports
Activity
changed milestone to %17.4
assigned to @clavimoniere
added workflowin review label and removed workflowready for development label
added pipelinetier-1 label
- Resolved by Chad Lavimoniere
@annabeldunstone can you give this a UX Paper Cuts review?
requested review from @annabeldunstone
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Category Reviewer Maintainer frontend @vanessaotto
(UTC+2, 6 hours ahead of author)
@pgascouvaillancourt
(UTC-4, same timezone as author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 10860bc3 and 21226688
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.35 MB 4.35 MB - 0.0 % mainChunk 3.28 MB 3.28 MB - 0.0 %
Note: We do not have exact data for 10860bc3. So we have used data from: 6bacbd1c.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 651 commits
-
031114c1...835017a6 - 649 commits from branch
master
- 1e711c9e - Prevent footnote OL from being reorderable
- 21226688 - Improve styling of footnotes
-
031114c1...835017a6 - 649 commits from branch
removed review request for @annabeldunstone
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 21226688expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 128 | 0 | 16 | 0 | 144 | ✅ | | Verify | 44 | 0 | 2 | 0 | 46 | ✅ | | Plan | 73 | 0 | 0 | 0 | 73 | ✅ | | Govern | 72 | 0 | 0 | 0 | 72 | ✅ | | Package | 20 | 0 | 12 | 0 | 32 | ✅ | | Data Stores | 31 | 0 | 1 | 0 | 32 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Secure | 3 | 0 | 0 | 0 | 3 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 389 | 0 | 32 | 0 | 421 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-omnibus:
test report for 21226688expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Plan | 82 | 0 | 9 | 0 | 91 | ✅ | | Create | 408 | 0 | 51 | 0 | 459 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 490 | 0 | 60 | 0 | 550 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
mentioned in issue #482771 (closed)
- Resolved by Natalia Tepluhina
@ntepluhina can you do a frontend maintainer review on this?
requested review from @ntepluhina
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
removed pipeline:run-e2e-omnibus-once label
started a merge train
mentioned in commit 12a68c36
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!3354 (merged)
added releasedpublished label and removed releasedcandidate label