Skip to content

Resolve "Use only one version of the key icon"

Jeremy Elder requested to merge 31438-use-only-one-version-of-the-key-icon into master

What does this MR do?

Simplifies the UI by using only one version of the key icon. Currently we have both key and key-modern, but since they are both representing the same concept of “keys”, one icon will suffice.

As a benefit, this will help decrease the size of the icon library and make it easier to update a single key icon in the future (See gitlab-design#602 (closed)).

Closes #31438 (closed)

Screenshots

Before After
Screen_Shot_2019-09-11_at_10.40.21_PM Frame_2

Does this MR meet the acceptance criteria?

Conformity

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Jeremy Elder

Merge request reports