Delete the `json_wrapper_legacy_mode` feature flag
This feature flag was introduced in 13.0, which is more than 12 milestones ago.
As part of our process we want to ensure feature flags don't stay too long in the codebase.
Rollout issue: #369436 (closed)
The feature flag is enabled by default. Unless it's disabled on GitLab.com, you should keep the feature-flag code branch, otherwise, keep the other branch.
Remaining mentions of the feature flag (click to expand)
It is possible that this MR will still need some changes to remove references to the feature flag in the code.
At the moment the gitlab-housekeeper
is not always capable of removing all references so you must check the diff and pipeline failures to confirm if there are any issues.
It is the responsibility of groupsource code to push those changes to this branch.
If they are already removing this feature flag in another merge request then they can just close this merge request.
You can also see the status of the rollout by checking #369436 (closed) and https://gitlab.com/gitlab-com/gl-infra/feature-flag-log/-/issues/?search=json_wrapper_legacy_mode&sort=created_date&state=all&label_name%5B%5D=host%3A%3Agitlab.com.
This change was generated by gitlab-housekeeper using the Keeps::DeleteOldFeatureFlags keep.
To provide feedback on your experience with gitlab-housekeeper
please create an issue with the
label GitLab Housekeeper and consider pinging the author of this keep.
Merge request reports
Activity
requested review from @j.seto
added 1 commit
- 23fb4221 - Delete the `json_wrapper_legacy_mode` feature flag
added Category:Source Code Management devopscreate sectiondev labels
added typemaintenance label
added pipelinetier-1 label
- A deleted user
added backend label
3 Warnings 23fb4221: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. The master pipeline status page reported failures in - rspec system pg14 single-redis 16/32
- rspec-ee unit pg14 single-redis 36/39
- rspec unit pg14 single-redis 26/44
If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the#master-broken
Slack channel.This merge request does not refer to an existing milestone. Reviewer roulette
Category Reviewer Maintainer backend @mokhax
(UTC-6, 16 hours behind author)
@jessieay
(UTC-7, 17 hours behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Igor Drozdov
@igor.drozdov are you able to review this MR. Please note that this MR is generated by AI so may contain errors. This feature flag was chosen by automation as it is older than 12 months old and is already enabled by default.
requested review from @igor.drozdov
removed review request for @j.seto
assigned to @DylanGriffith
added pipeline:mr-approved label
added pipelinetier-3 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 23fb4221expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 70 | 0 | 0 | 0 | 70 | ✅ | | Package | 16 | 0 | 15 | 0 | 31 | ✅ | | Data Stores | 30 | 0 | 1 | 0 | 31 | ✅ | | Create | 127 | 0 | 12 | 0 | 139 | ✅ | | Govern | 71 | 0 | 0 | 0 | 71 | ✅ | | Verify | 43 | 0 | 2 | 0 | 45 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Fulfillment | 1 | 0 | 0 | 0 | 1 | ✅ | | Secure | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 375 | 0 | 31 | 0 | 406 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 23fb4221expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Create | 417 | 0 | 51 | 0 | 468 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 417 | 0 | 51 | 0 | 468 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
mentioned in commit f29f4389
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
changed milestone to %17.3
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
mentioned in issue #369436 (closed)
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!3241 (merged)