Add approval rule: Move action buttons to content
What does this MR do and why?
Add approval rule: Move action buttons to content
According to our design guidelines contextual buttons should be included in the content area of a drawer
. From a users flow perspective it also makes sense to have the buttons below the form in this case.
The MR moves the action buttons to below the form.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Related to #452231 (closed), !146502 (comment 1808464857)
Merge request reports
Activity
changed milestone to %17.3
assigned to @seggenberger
added UX UX Paper Cuts bugux frontend groupsource code sectiondev typebug labels
added devopsmanage label
added Category:Source Code Management devopscreate labels and removed devopsmanage label
- Resolved by Michael Le
added devopsmanage groupux paper cuts sectioncore platform labels and removed devopscreate groupsource code sectiondev labels
added pipelinetier-1 label
2 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.This merge request contains lines with testid selectors. Please ensure e2e:package-and-test
job is run.testid
selectorsThe following changed lines in this MR contain
testid
selectors:ee/app/assets/javascripts/approvals/components/rule_drawer/create_rule.vue
- data-testid="save-approval-rule-button" + data-testid="save-approval-rule-button"
If the
e2e:package-and-test
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:package-and-test-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer frontend @minahilnichols
(UTC-4, 6 hours behind author)
@pslaughter
(UTC-5, 7 hours behind author)
UX @annabeldunstone
(UTC+0, 2 hours behind author)
Maintainer review is optional for UX Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 1 commit
- a878c5e4 - Add approval rule: Move action buttons to content
removed review request for @afracazo
removed review request for @mle
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
mentioned in issue #457923 (closed)
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for d173febdexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 127 | 0 | 12 | 0 | 139 | ✅ | | Verify | 44 | 0 | 3 | 0 | 47 | ✅ | | Plan | 63 | 0 | 6 | 0 | 69 | ✅ | | Govern | 69 | 0 | 0 | 0 | 69 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Package | 19 | 0 | 12 | 0 | 31 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Fulfillment | 1 | 0 | 0 | 0 | 1 | ✅ | | Secure | 1 | 0 | 0 | 0 | 1 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 370 | 0 | 34 | 0 | 404 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for d173febdexpand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Create | 278 | 0 | 34 | 66 | 312 | ✅ | | Manage | 30 | 0 | 15 | 2 | 45 | ✅ | | Govern | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 6 | 0 | 2 | 0 | 8 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 318 | 0 | 51 | 68 | 369 | ✅ | +--------+--------+--------+---------+-------+-------+--------+