Skip to content

Add approval rules drawer component (project settings)

Jacques Erasmus requested to merge 439397-approval-rules-drawer into master

What does this MR do and why?

Adds an approval rules drawer component to Project > Settings > Merge requests > Merge request approvals as part of updating our frontend to use a Drawer component instead of a Modal everywhere approval rules can be managed.

Issue: #439397 (closed)

⚠ Note: changes in this MR are behind the :approval_rules_drawer feature flag.

Implementation breakdown:

Description Issue/MR
Add approval rules drawer component (Project > Settings > Merge requests) 👈 This MR
Add approval rules drawer component (Merge Request > New/Edit)
Address docs changes (!146502 (comment 1807508724))		 follow-up MR
Add approval rules drawer component (Branch rules > Edit) follow-up MR
Update approval rules form to use User and Group selectors (mockups) follow-up MR
Rollout approval_rules_drawer feature flag #444628 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
(Add) Screenshot_2024-03-05_at_11.59.37 (Add) Screenshot_2024-03-05_at_12.02.27
(Edit) Screenshot_2024-03-05_at_11.59.55 (Edit) Screenshot_2024-03-05_at_12.02.38
(Enable coverage check) Screenshot_2024-03-05_at_12.00.25 (Enable coverage check) Screenshot_2024-03-05_at_12.02.47

Screen_Recording_2024-03-05_at_12.56.07.2024-03-05_12_58_44

How to set up and validate locally

  1. Enable the approval_rules_drawer feature flag.
  2. Navigate to Project > Settings > Merge requests > Merge request approvals.
  3. Add, Edit, and Enabling coverage checks should now happen in a drawer instead of a modal.

Related to #439397 (closed)

Edited by Jacques Erasmus

Merge request reports