Skip to content
Snippets Groups Projects

Add CRM contacts widget to frontend

Merged Lee Tickett requested to merge gitlab-community/gitlab:464589-crm-widget-frontend into master
All threads resolved!

What does this MR do and why?

Add the frontend work item widget for CRM contacts.

Note: This is the first MR which is getting a bit big, so i'm looking to get it merged before raising a follow up to apply some presentation/UX tweaks to make it completely match the initial designs.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screen_Recording_2024-07-25_at_12.15.19

How to set up and validate locally

pre-req: your group will need some crm contacts- this should already be seeded in your database, but read the CRM docs if not.

  1. http://gdk.test:3000/flightjs/Flight/-/work_items/new
    1. Select a work item type that supports crm contacts (issue or task for example)
    2. Select Edit in the Contacts widget and try adding some contacts/removing some contacts/clearing contacts etc
  2. http://gdk.test:3000/flightjs/Flight/-/work_items/iid 2. Select Edit in the Contacts widget and try adding some contacts/removing some contacts/clearing contacts etc

Related to #464589 (closed)

Edited by Lee Tickett

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Deepika Guliani
  • Deepika Guliani
  • Deepika Guliani
  • Deepika Guliani requested changes

    requested changes

  • Lee Tickett added 381 commits

    added 381 commits

    Compare with previous version

  • Lee Tickett added 235 commits

    added 235 commits

    Compare with previous version

  • requested review from @deepika.guliani

  • Lee Tickett mentioned in issue #474870

    mentioned in issue #474870

  • Lee Tickett added 1 commit

    added 1 commit

    Compare with previous version

  • Nick Leonard approved this merge request

    approved this merge request

  • added pipelinetier-2 label and removed pipelinetier-1 label

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • Lee Tickett added 1 commit

    added 1 commit

    Compare with previous version

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for c33c21a0

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Plan        | 70     | 0      | 0       | 0     | 70    | ✅     |
    | Create      | 127    | 0      | 12      | 0     | 139   | ✅     |
    | Verify      | 43     | 0      | 2       | 0     | 45    | ✅     |
    | Govern      | 71     | 0      | 0       | 0     | 71    | ✅     |
    | Package     | 16     | 0      | 15      | 0     | 31    | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Data Stores | 30     | 0      | 1       | 0     | 31    | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Secure      | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Fulfillment | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 375    | 0      | 31      | 0     | 406   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :white_check_mark: test report for c33c21a0

    expand test summary
    +-------------------------------------------------------------+
    |                       suites summary                        |
    +--------+--------+--------+---------+-------+-------+--------+
    |        | passed | failed | skipped | flaky | total | result |
    +--------+--------+--------+---------+-------+-------+--------+
    | Plan   | 82     | 0      | 9       | 0     | 91    | ✅     |
    | Create | 270    | 0      | 34      | 0     | 304   | ✅     |
    +--------+--------+--------+---------+-------+-------+--------+
    | Total  | 352    | 0      | 43      | 0     | 395   | ✅     |
    +--------+--------+--------+---------+-------+-------+--------+
  • Lee Tickett added 1 commit

    added 1 commit

    Compare with previous version

  • mentioned in issue #475041 (closed)

  • Lee Tickett resolved all threads

    resolved all threads

  • @psimyn could you take the maintainer review please? :pray:

  • Lee Tickett requested review from @psimyn and removed review request for @nickleonard and @deepika.guliani

    requested review from @psimyn and removed review request for @nickleonard and @deepika.guliani

  • Deepika Guliani approved this merge request

    approved this merge request

  • added pipelinetier-3 label and removed pipelinetier-2 label

  • Simon Knox
  • Simon Knox
  • Simon Knox
  • Simon Knox
  • Simon Knox
  • Simon Knox
  • Simon Knox
  • Simon Knox
  • Simon Knox
  • Simon Knox
  • Simon Knox
  • Simon Knox
  • Simon Knox
  • Lee Tickett added 1 commit

    added 1 commit

    Compare with previous version

  • Lee Tickett reset approvals from @deepika.guliani by pushing to the branch

    reset approvals from @deepika.guliani by pushing to the branch

  • Lee Tickett requested review from @psimyn

    requested review from @psimyn

  • LGTM @leetickett-gitlab!

    Couple of additional responses but nothing that cannot be updated later

  • Simon Knox approved this merge request

    approved this merge request

  • Simon Knox resolved all threads

    resolved all threads

  • Lee Tickett enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Lee Tickett added 755 commits

    added 755 commits

    Compare with previous version

  • Lee Tickett reset approvals from @psimyn by pushing to the branch

    reset approvals from @psimyn by pushing to the branch

  • Natalia Tepluhina approved this merge request

    approved this merge request

  • Natalia Tepluhina enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Natalia Tepluhina started a merge train

    started a merge train

  • mentioned in commit c20fc883

  • added workflowstaging label and removed workflowcanary label

  • mentioned in issue #464589 (closed)

  • Please register or sign in to reply
    Loading