Remove unnecessary calls to sign out
What does this MR do and why?
Continuing the work (epic) to improve slow tests and other inefficiencies. Throughout our codebase, we make superfluous calls to sign_out (for example, signing the user out of a test in the after
block). These calls are superfluous and take unnecessary time, since each new test starts a new browser session.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Merge request reports
Activity
assigned to @svistas
- A deleted user
added QA label
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer QA @hmuralidhar
(UTC+10, 7 hours ahead of author)
@treagitlab
(UTC-7, 10 hours behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Useradded Quality label
- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@svistas
- please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
- Resolved by Tiffany Rea
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 84be56f8expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Package | 19 | 0 | 12 | 0 | 31 | ✅ | | Verify | 36 | 0 | 2 | 0 | 38 | ✅ | | Data Stores | 27 | 0 | 4 | 0 | 31 | ✅ | | Create | 126 | 0 | 12 | 0 | 138 | ✅ | | Govern | 65 | 0 | 0 | 0 | 65 | ✅ | | Plan | 60 | 0 | 2 | 0 | 62 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Fulfillment | 1 | 0 | 0 | 0 | 1 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 349 | 0 | 33 | 0 | 382 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 84be56f8expand test summary
+---------------------------------------------------------------------+ | suites summary | +----------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------+--------+--------+---------+-------+-------+--------+ | Create | 417 | 0 | 48 | 9 | 465 | ✅ | | Systems | 7 | 0 | 0 | 0 | 7 | ✅ | | Govern | 105 | 0 | 8 | 1 | 113 | ✅ | | Fulfillment | 4 | 0 | 24 | 0 | 28 | ✅ | | Manage | 29 | 0 | 16 | 0 | 45 | ✅ | | Monitor | 12 | 0 | 13 | 0 | 25 | ✅ | | Plan | 80 | 0 | 11 | 0 | 91 | ✅ | | Analytics | 3 | 0 | 0 | 0 | 3 | ✅ | | Package | 31 | 0 | 14 | 0 | 45 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Data Stores | 43 | 0 | 14 | 0 | 57 | ✅ | | Ai-powered | 1 | 0 | 1 | 1 | 2 | ✅ | | Configure | 1 | 0 | 3 | 0 | 4 | ✅ | | Verify | 53 | 0 | 13 | 0 | 66 | ✅ | | Secure | 3 | 0 | 2 | 0 | 5 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | +----------------+--------+--------+---------+-------+-------+--------+ | Total | 796 | 0 | 172 | 11 | 968 | ✅ | +----------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for 84be56f8expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 53 | 0 | 13 | 0 | 66 | ✅ | | Plan | 83 | 0 | 11 | 0 | 94 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Govern | 79 | 0 | 9 | 0 | 88 | ✅ | | Create | 138 | 0 | 16 | 0 | 154 | ✅ | | Data Stores | 30 | 0 | 13 | 0 | 43 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Package | 23 | 0 | 15 | 0 | 38 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Fulfillment | 2 | 0 | 24 | 0 | 26 | ✅ | | Manage | 2 | 0 | 8 | 0 | 10 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Secure | 3 | 0 | 2 | 0 | 5 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Ai-powered | 0 | 0 | 1 | 0 | 1 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 428 | 0 | 131 | 0 | 559 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost User
added pipeline:run-all-e2e label
changed milestone to %17.2
added typemaintenance label
requested review from @hmuralidhar
- Resolved by Tiffany Rea
@hmuralidhar could I have a review here? Thanks in advance!
added pipeline:mr-approved label
added pipelinetier-2 label
requested review from @treagitlab
removed review request for @hmuralidhar