From 84be56f84dece0154d6e8dfc998b861f71c1d4be Mon Sep 17 00:00:00 2001
From: Sofia Vistas <svistas@gitlab.com>
Date: Wed, 26 Jun 2024 13:55:06 +0300
Subject: [PATCH] Remove unnecessary calls to sign out

---
 .../3_create/repository/protocol_v2_push_ssh_spec.rb          | 2 --
 .../group/group_saml_enforced_sso_git_access_spec.rb          | 4 ----
 .../group/group_saml_enforced_sso_new_account_spec.rb         | 1 -
 .../10_govern/group/group_saml_non_enforced_sso_spec.rb       | 3 ---
 .../browser_ui/10_govern/group/restrict_by_ip_address_spec.rb | 3 ---
 5 files changed, 13 deletions(-)

diff --git a/qa/qa/specs/features/browser_ui/3_create/repository/protocol_v2_push_ssh_spec.rb b/qa/qa/specs/features/browser_ui/3_create/repository/protocol_v2_push_ssh_spec.rb
index a27b57759e800ba3..65cc8c5cb61c1f8a 100644
--- a/qa/qa/specs/features/browser_ui/3_create/repository/protocol_v2_push_ssh_spec.rb
+++ b/qa/qa/specs/features/browser_ui/3_create/repository/protocol_v2_push_ssh_spec.rb
@@ -23,8 +23,6 @@ module QA
         example.run
 
         ssh_key.remove_via_api!
-
-        Page::Main::Menu.perform(&:sign_out_if_signed_in)
       end
 
       it 'user pushes to the repository', :blocking, testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/347734' do
diff --git a/qa/qa/specs/features/ee/browser_ui/10_govern/group/group_saml_enforced_sso_git_access_spec.rb b/qa/qa/specs/features/ee/browser_ui/10_govern/group/group_saml_enforced_sso_git_access_spec.rb
index 61d940e2bd951106..7ad8b517be5be746 100644
--- a/qa/qa/specs/features/ee/browser_ui/10_govern/group/group_saml_enforced_sso_git_access_spec.rb
+++ b/qa/qa/specs/features/ee/browser_ui/10_govern/group/group_saml_enforced_sso_git_access_spec.rb
@@ -29,12 +29,8 @@ module QA
       end
 
       after do
-        page.visit Runtime::Scenario.gitlab_address
-
         group.remove_via_api!
 
-        Page::Main::Menu.perform(&:sign_out_if_signed_in)
-
         Flow::Saml.remove_saml_idp_service(saml_idp_service)
       end
 
diff --git a/qa/qa/specs/features/ee/browser_ui/10_govern/group/group_saml_enforced_sso_new_account_spec.rb b/qa/qa/specs/features/ee/browser_ui/10_govern/group/group_saml_enforced_sso_new_account_spec.rb
index 157f14d67fb55793..e5f1a183cc9b4aaa 100644
--- a/qa/qa/specs/features/ee/browser_ui/10_govern/group/group_saml_enforced_sso_new_account_spec.rb
+++ b/qa/qa/specs/features/ee/browser_ui/10_govern/group/group_saml_enforced_sso_new_account_spec.rb
@@ -83,7 +83,6 @@ module QA
         remove_user
 
         page.visit Runtime::Scenario.gitlab_address
-        Page::Main::Menu.perform(&:sign_out_if_signed_in)
       end
 
       context 'with Snowplow tracking enabled',
diff --git a/qa/qa/specs/features/ee/browser_ui/10_govern/group/group_saml_non_enforced_sso_spec.rb b/qa/qa/specs/features/ee/browser_ui/10_govern/group/group_saml_non_enforced_sso_spec.rb
index 98fc4dad88fc9a45..889f23a02b5c910b 100644
--- a/qa/qa/specs/features/ee/browser_ui/10_govern/group/group_saml_non_enforced_sso_spec.rb
+++ b/qa/qa/specs/features/ee/browser_ui/10_govern/group/group_saml_non_enforced_sso_spec.rb
@@ -23,9 +23,6 @@ module QA
       after do
         group.remove_via_api!
 
-        page.visit Runtime::Scenario.gitlab_address
-        Page::Main::Menu.perform(&:sign_out_if_signed_in)
-
         Flow::Saml.remove_saml_idp_service(saml_idp_service)
 
         user.remove_via_api! if user
diff --git a/qa/qa/specs/features/ee/browser_ui/10_govern/group/restrict_by_ip_address_spec.rb b/qa/qa/specs/features/ee/browser_ui/10_govern/group/restrict_by_ip_address_spec.rb
index 4eafd6dfcde65050..8a60cc5847995744 100644
--- a/qa/qa/specs/features/ee/browser_ui/10_govern/group/restrict_by_ip_address_spec.rb
+++ b/qa/qa/specs/features/ee/browser_ui/10_govern/group/restrict_by_ip_address_spec.rb
@@ -31,9 +31,6 @@ module QA
 
       after do
         sandbox_group.remove_via_api!
-
-        page.visit Runtime::Scenario.gitlab_address
-        Page::Main::Menu.perform(&:sign_out_if_signed_in)
       end
 
       context 'when restricted by another ip address' do
-- 
GitLab