Use DEFAULT_POLICY_TEST_STAGE constant
What does this MR do and why?
This MR addresses #446292 (closed) by using the ::Gitlab::Ci::Config::SecurityOrchestrationPolicies::Processor::DEFAULT_POLICY_TEST_STAGE
constant instead of a string.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #446292 (closed)
Merge request reports
Activity
changed milestone to %17.2
assigned to @Andyschoenen
added pipelinetier-1 label
- A deleted user
added backend label
Reviewer roulette
Category Reviewer Maintainer backend @tvellishetty
(UTC+5.5, 3.5 hours ahead of author)
@rkumar555
(UTC+2, same timezone as author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User- Resolved by drew stachon
Hi @shreyasagarwal can you do the initial review?
requested review from @shreyasagarwal
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
- Resolved by drew stachon
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you resolve this discussion, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please resolve this discussion and the set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
- Resolved by drew stachon
@drew Could you please take over as the maintainer for the MR?
requested review from @drew and removed review request for @shreyasagarwal
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for ee0a55ceexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 65 | 0 | 0 | 0 | 65 | ✅ | | Plan | 60 | 0 | 2 | 0 | 62 | ✅ | | Create | 126 | 0 | 11 | 0 | 137 | ✅ | | Verify | 36 | 0 | 2 | 0 | 38 | ✅ | | Package | 18 | 0 | 13 | 0 | 31 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Fulfillment | 1 | 0 | 0 | 0 | 1 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 352 | 0 | 29 | 0 | 381 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for ee0a55ceexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 77 | 0 | 9 | 0 | 86 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Create | 135 | 0 | 15 | 0 | 150 | ✅ | | Verify | 53 | 0 | 13 | 0 | 66 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Package | 22 | 0 | 16 | 0 | 38 | ✅ | | Plan | 78 | 1 | 11 | 0 | 90 | ❌ | | Data Stores | 34 | 0 | 9 | 0 | 43 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Manage | 2 | 0 | 8 | 0 | 10 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Fulfillment | 2 | 0 | 24 | 0 | 26 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Ai-powered | 0 | 0 | 1 | 0 | 1 | ➖ | | Secure | 3 | 0 | 2 | 0 | 5 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 421 | 1 | 127 | 0 | 549 | ❌ | +-------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Useradded pipelinetier-3 label and removed pipelinetier-2 label
enabled automatic add to merge train when the pipeline for a036fd5f succeeds