Fix Geo migration spec
What does this MR do and why?
The test was failing in CI because the Geo CI job artifact registry
had cached the newer state of the columns that no longer had the
success
column. migrate!
doesn't reset the column information.
This change resets the state so that the migration spec passes.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
How to set up and validate locally
To reproduce the failure, run:
CI=true bundle exec rspec ./ee/spec/migrations/geo/migrate_ci_job_artifacts_to_separate_registry_spec.rb
From https://gitlab.com/gitlab-org/gitlab/-/issues/462487#note_1911223919
Merge request reports
Activity
assigned to @stanhu
added pipelinetier-1 label
- A deleted user
added database databasereview pending labels
1 Message This merge request adds or changes files that require a review from the Database team. This merge request requires a database review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
- Prepare your MR for database review according to the docs.
- Assign and mention the database reviewer suggested by Reviewer Roulette.
The following files require a review from the Database team:
ee/spec/migrations/geo/migrate_ci_job_artifacts_to_separate_registry_spec.rb
Reviewer roulette
Category Reviewer Maintainer database @bhrai
(UTC+2, 9 hours ahead of author)
@OmarQunsulGitlab
(UTC+2, 9 hours ahead of author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@stanhu
- please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
changed milestone to %17.1
added maintenancepipelines typemaintenance labels
requested review from @rymai
mentioned in merge request !154494 (merged)
mentioned in merge request !154495 (merged)
mentioned in merge request !154505 (merged)
mentioned in incident gitlab-org/release/tasks#10917 (closed)
mentioned in incident gitlab-org/release/tasks#10917 (closed)
mentioned in merge request !154503 (merged)
mentioned in merge request !154504 (merged)
mentioned in merge request !154502 (merged)
mentioned in merge request !154501 (merged)