Add a new tab for Kubernetes tree view
What does this MR do and why?
This MR introduces a WIP feature flag k8s_tree_view
project-based. It adds a new tab for the Tree view hidden behind this feature flag.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
FF disabled | FF enabled |
---|---|
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Prerequisites:
- NGINX, loopback interface, and HTTPS set up on your GDK
- Docker instance
- KAS enabled on GDK (steps 1-2 from the guide).
-
Visit the Project -> Operate -> Environments
-
Create/Edit an environment using the UI
-
Visit the Project -> Infrastructure -> Kubernetes clusters page and create an agent following the instructions from the modal.
- Select the "Connect a cluster" button
- The modal should pop up
- In the modal select "Select an agent or enter a name to create new"
- You probably won't have any configured agents to show up in the list, create a new one by typing the name of your choice
- The button should appear at the bottom of the list saying "Create agent:
<your-agent-name>
" - Select the button and click "Register" in the next view.
- Save the token to use it in the next point.
-
Add the following configuration inside your project in
.gitlab/agents/<your-agent-name>/config.yaml
for the user_access agent:user_access: access_as: agent: {} projects: - id: <your-group>/<your-project-to-share-agent-with>
-
Note that the shared agents should be connected to the cluster in order to appear in the list. Please follow points 3-8 from the guide and then the Deploy the GitLab Agent (agentk) with k3d section to create a local cluster and connect your agent with the cluster.
-
Select an agent from the dropdown in the Environments settings page and save the change.
-
Visit the Environments page and visit the environment details page for the environment that has an associated agent.
-
Enable
k8s_tree_view
feature flag for this project:Feature.enable(:k8s_tree_view, Project.find(<project id>))
-
Verify the new tab, "Summary", available in the Kubernetes overview section.
Related to #463331 (closed)
Merge request reports
Activity
changed milestone to %17.1
assigned to @anna_vovchenko
added workflowin dev label and removed workflowready for development label
added docs-only label
added pipelinetier-1 label
- A deleted user
added backend feature flag labels
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @panoskanell
(UTC+3, same timezone as author)
@hraghuvanshi
(UTC+5.5, 2.5 hours ahead of author)
frontend @rhardarson
(UTC+2, 1 hour behind author)
@kushalpandya
(UTC-4, 7 hours behind author)
UX @emilybauman
(UTC-4, 7 hours behind author)
Maintainer review is optional for UX Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerremoved backend feature flag labels
removed docs-only label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 998d28f1 and b86a9e7d
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.32 MB 4.32 MB - 0.0 % mainChunk 3.3 MB 3.3 MB - 0.0 %
Note: We do not have exact data for 998d28f1. So we have used data from: e0098295.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Lorenz van Herwaarden
@afontaine, could you please do the initial frontend review?
@emilybauman, I am starting to work on the Tree view. As it's behind a feature flag, the UX review is not required. I'll still be pinging you on the related MRs for awareness
added workflowready for review label and removed workflowin dev label
requested review from @afontaine
- Resolved by Lorenz van Herwaarden
@hustewart, could you please review the backend change? I think it's a very small change, and it should be sufficient to have just one backend review.
requested review from @hustewart
added pipeline:mr-approved label
- Resolved by Lorenz van Herwaarden
@hustewart
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipelinetier-3 label and removed pipelinetier-1 label
- A deleted user
added backend feature flag labels
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for b86a9e7dexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 128 | 0 | 2 | 82 | 130 | ✅ | | Create | 242 | 0 | 20 | 186 | 262 | ✅ | | Verify | 60 | 0 | 4 | 58 | 64 | ✅ | | Data Stores | 62 | 0 | 0 | 44 | 62 | ✅ | | Package | 38 | 0 | 24 | 38 | 62 | ✅ | | Plan | 108 | 0 | 4 | 94 | 112 | ✅ | | Release | 10 | 0 | 0 | 10 | 10 | ✅ | | Analytics | 2 | 0 | 2 | 0 | 4 | ✅ | | Monitor | 16 | 0 | 0 | 14 | 16 | ✅ | | Manage | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 666 | 0 | 58 | 526 | 724 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for b86a9e7dexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 588 | 0 | 76 | 12 | 664 | ✅ | | Verify | 106 | 0 | 24 | 0 | 130 | ✅ | | Plan | 205 | 0 | 16 | 0 | 221 | ✅ | | Data Stores | 90 | 0 | 18 | 0 | 108 | ✅ | | Package | 126 | 0 | 66 | 0 | 192 | ✅ | | Secure | 6 | 0 | 2 | 4 | 8 | ✅ | | Monitor | 24 | 0 | 16 | 0 | 40 | ✅ | | Manage | 6 | 0 | 4 | 0 | 10 | ✅ | | Release | 12 | 0 | 2 | 0 | 14 | ✅ | | Configure | 0 | 0 | 6 | 0 | 6 | ➖ | | Analytics | 2 | 0 | 2 | 0 | 4 | ✅ | | Govern | 180 | 0 | 18 | 0 | 198 | ✅ | | Fulfillment | 4 | 0 | 50 | 0 | 54 | ✅ | | Growth | 0 | 0 | 4 | 0 | 4 | ➖ | | ModelOps | 0 | 0 | 2 | 0 | 2 | ➖ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 1349 | 0 | 308 | 16 | 1657 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
- Resolved by Anna Vovchenko
- Resolved by Lorenz van Herwaarden
just one tiny suggestion for you @anna_vovchenko
I won't block the MR though
reset approvals from @afontaine and @hustewart by pushing to the branch
- Resolved by Lorenz van Herwaarden
@lorenzvanherwaarden, could you please do the frontend maintainer review? This MR has already had approvals from the UX, frontend, and backend maintainer, which got erased when I updated the feature flag with the rollout issue link.
requested review from @lorenzvanherwaarden
removed pipeline:mr-approved label
added pipelinetier-1 label and removed pipelinetier-3 label
- Resolved by Lorenz van Herwaarden
added pipeline:mr-approved label
added pipelinetier-3 label and removed pipelinetier-1 label
enabled an automatic merge when the pipeline for 1ae1cb96 succeeds
mentioned in commit 7cbf4547
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#6599 (closed)
added workflowstaging-canary label and removed workflowready for review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in issue gitlab-org/quality/triage-reports#20604 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20977 (closed)
mentioned in issue gitlab-org/quality/triage-reports#21524 (closed)
mentioned in issue gitlab-org/quality/triage-reports#22020