Cycle analytics - implement card ui for stage list
What does this MR do?
Implements the card ui needed for the stages list for cycle analytics.
- Moves the existing stage-nav-item from haml to vue
- Update the style of the list to match the card list in the new designs
- Adds unit tests
Before | After: canEdit = false | After: canEdit = true |
---|---|---|
![]() |
![]() |
![]() |
CE Port
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31580
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related issue
Merge request reports
Activity
changed milestone to %12.2
added backstage [DEPRECATED] devopsmanage estimationneeded frontend + 1 deleted label
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer frontend Sarah Groff Hennigh-Palermo ( @sarahghp
)Kushal Pandya ( @kushalpandya
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 2 commits
added 272 commits
-
093a8aec...b2fbc919 - 269 commits from branch
master
- bd36d12f - Move cycle analytics stages templates to vue
- 64cdee1d - Fix alignment of median value
- 3d295fd6 - Test for stage_nav_item.vue
Toggle commit list-
093a8aec...b2fbc919 - 269 commits from branch
added 214 commits
-
3d295fd6...878a306a - 207 commits from branch
master
- f7945b03 - Add customisable_cycle_analytics feature flag
- 68012936 - Move cycle analytics stages templates to vue
- f28645f6 - Fix alignment of median value
- e1126f0f - Test for stage_nav_item.vue
- 46a94d75 - Added menu item for additional options
- 6e64264d - Updated tests for stage-nav-item
- c5a6d83e - Removed the feature flag
Toggle commit list-
3d295fd6...878a306a - 207 commits from branch
added 348 commits
-
c5a6d83e...df98cdb4 - 340 commits from branch
master
- f3391c43 - Add customisable_cycle_analytics feature flag
- 561176cf - Move cycle analytics stages templates to vue
- a79a966a - Fix alignment of median value
- efa970da - Test for stage_nav_item.vue
- 892b5015 - Added menu item for additional options
- 65ab8a79 - Updated tests for stage-nav-item
- a43e7209 - Removed the feature flag
- f25f76c1 - Replace css with utility classes
Toggle commit list-
c5a6d83e...df98cdb4 - 340 commits from branch
added 7 commits
- ff43e36d - Move cycle analytics stages templates to vue
- fd310f5d - Fix alignment of median value
- b7c3181f - Test for stage_nav_item.vue
- 60da9912 - Added menu item for additional options
- b1cdadb7 - Updated tests for stage-nav-item
- 837b77ec - Removed the feature flag
- c7624586 - Replace css with utility classes
Toggle commit listadded 49 commits
-
c2ee78ba...4f354639 - 42 commits from branch
master
- 6ebf5bde - Move cycle analytics stages templates to vue
- e54befcc - Test for stage_nav_item.vue
- 92cb70ca - Added menu item for additional options
- f2e54674 - Updated tests for stage-nav-item
- 17e67c6f - Replace css with utility classes
- 04448401 - Updated gitlab pot file
- 09683624 - Minor cleanup css and utilities
Toggle commit list-
c2ee78ba...4f354639 - 42 commits from branch
- Resolved by Ezekiel Kigbo
@ekigbo is there a reason to have this EE port for the MR? It doesn't look like any EE files were touched. The MRs look the same. Am I missing something?
Anyway, I made my comments on the CE version.
added 62 commits
-
09683624...339015e2 - 54 commits from branch
master
- 80e9ca50 - Move cycle analytics stages templates to vue
- 6533996f - Test for stage_nav_item.vue
- 8f9c3b35 - Added menu item for additional options
- b20350dc - Updated tests for stage-nav-item
- 7ef982e8 - Replace css with utility classes
- e6fa10f8 - Updated gitlab pot file
- 3a69ec3f - Minor cleanup css and utilities
- 0df15085 - Minor review comments
Toggle commit list-
09683624...339015e2 - 54 commits from branch
added 129 commits
-
0df15085...cd5044ff - 121 commits from branch
master
- 7229e809 - Move cycle analytics stages templates to vue
- 1b33ed7a - Test for stage_nav_item.vue
- 5c444fc4 - Added menu item for additional options
- ebe7d457 - Updated tests for stage-nav-item
- 2eb578e6 - Replace css with utility classes
- 990bd0ab - Updated gitlab pot file
- a1dbb793 - Minor cleanup css and utilities
- e70a883b - Minor review comments
Toggle commit list-
0df15085...cd5044ff - 121 commits from branch
added Enterprise Edition label
removed estimationneeded label
added 517 commits
-
e70a883b...e47f6a2b - 509 commits from branch
master
- bc53bec0 - Move cycle analytics stages templates to vue
- a6ff00ab - Test for stage_nav_item.vue
- b1ae7cac - Added menu item for additional options
- 7c4924f0 - Updated tests for stage-nav-item
- 035ca4fe - Replace css with utility classes
- 92f52903 - Updated gitlab pot file
- 1f7f8fa5 - Minor cleanup css and utilities
- ec9dcba6 - Minor review comments
Toggle commit list-
e70a883b...e47f6a2b - 509 commits from branch
assigned to @fatihacet and unassigned @ekigbo
assigned to @kushalpandya and unassigned @fatihacet
- Resolved by Kushal Pandya
@ekigbo Left my comments in CE MR.
assigned to @ekigbo and unassigned @kushalpandya
assigned to @kushalpandya
added 418 commits
-
ec9dcba6...c9e8505c - 409 commits from branch
master
- 5ce66d60 - Move cycle analytics stages templates to vue
- 19a0092e - Test for stage_nav_item.vue
- b1b9e3d2 - Added menu item for additional options
- fed886de - Updated tests for stage-nav-item
- 3d3229f2 - Replace css with utility classes
- 4c883113 - Updated gitlab pot file
- 639c3a8f - Minor cleanup css and utilities
- fbda4f2b - Minor review comments
- 4e60bbdc - Address maintainer feedback
Toggle commit list-
ec9dcba6...c9e8505c - 409 commits from branch
added 33 commits
-
4e60bbdc...ae751bc0 - 27 commits from branch
master
- 651c5dff - Move cycle analytics stages templates to vue
- 0788c19d - Added menu item for additional options
- de3b4e54 - Replace css with utility classes
- 05d76a25 - Updated gitlab pot file
- 1b2d187c - Minor cleanup css and utilities
- ef900bba - Minor review comments
Toggle commit list-
4e60bbdc...ae751bc0 - 27 commits from branch
unassigned @ekigbo
mentioned in commit 3e443390
mentioned in issue #12196 (closed)
mentioned in merge request !15428 (merged)
mentioned in merge request !15122 (merged)
added Category:Value Stream Management label