Jira issues - Clean up issue creation section UI in settings form
What does this MR do and why?
This change is behind the feature flag jira_multiple_project_keys
. Previous MR !148004 (merged).
- Move Jira project key under the Enable Jira issue creation from vulnerabilities checkbox.
- Remove the extra badge Ultimate next to the checkbox.
- Add help text for Jira project keys input and polish UI.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before - without feature flag | Before - with feature flag | After |
---|---|---|
![]() |
![]() |
![]() |
How to set up and validate locally
-
In rails console enable the experiment fully
Feature.enable(:jira_multiple_project_keys)
-
Go to Project > Settings > Integrations > Jira. For example,
http://127.0.0.1:3000/gitlab-org/gitlab-test/-/settings/integrations/jira/edit
.
Related to #452161 (closed)
Merge request reports
Activity
changed milestone to %16.11
assigned to @justin_ho
4 Warnings 8dee851e: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. d2c88bbf: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
This merge request contains lines with testid selectors. Please ensure e2e:package-and-test
job is run.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
testid
selectorsThe following changed lines in this MR contain
testid
selectors:app/assets/javascripts/integrations/edit/components/jira_issues_fields.vue
+ data-testid="jira-project-keys" - data-testid="project-key-form-group" - data-testid="jira-project-key-field"
ee/app/assets/javascripts/integrations/edit/components/jira_issue_creation_vulnerabilities.vue
+ data-testid="jira-project-key"
If the
e2e:package-and-test
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:package-and-test-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer backend @akotte
(UTC+5.5, 1.5 hours behind author)
@pshutsin
(UTC+2, 5 hours behind author)
frontend @nradina
(UTC+2, 5 hours behind author)
@aturinske
(UTC-7, 14 hours behind author)
groupimport and integrate (backend) @ivaneG
(UTC+1, 6 hours behind author)
Maintainer review is optional for groupimport and integrate (backend) test for spec/features/*
@akotte
(UTC+5.5, 1.5 hours behind author)
Maintainer review is optional for test for spec/features/*
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Justin Ho Tuan Duong
- Resolved by Pavel Shutsin
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 113eb396 and a2f2b957
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.3 MB 4.3 MB - 0.0 % mainChunk 3.29 MB 3.29 MB - 0.0 %
Note: We do not have exact data for 113eb396. So we have used data from: 8e13dbd1.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangerrequested review from @ashrafkhamis
added Category:Integrations Technical Writing UI text labels
- Resolved by Ashraf Khamis
@justin_ho I think we should update the UI text here to:
- Section: `Jira issues` - Checkbox: `View Jira issues`
- Section: `Jira issues for vulnerabilities` - Checkbox: `Create Jira issues for vulnerabilities`
removed review request for @ashrafkhamis
- Resolved by Ashraf Khamis
@justin_ho In https://gitlab.com/gitlab-org/gitlab/uploads/bca3ae8f20f9589d78b0e0db1614dd8a/Jira_issues_section_-_after.png, we have
Jira project keys
inView Jira issues
andJira project key
inJira issue creation from vulnerabilities
. Does the former accept multiple values and the latter accept only a single value?
mentioned in epic &12609 (closed)
mentioned in merge request !148903 (merged)
added 106 commits
-
ffa85fcd...ef57c6e7 - 100 commits from branch
master
- 001799de - Move Jira project key under enable vulnerabilities
- abf222f5 - Add help text to project keys
- 738109bd - Improve warning messages around project key
- 6e471b57 - Add specs for basic rendering and logic
- e55a27d3 - Update section titles and checkbox labels
- 3987383a - Fix failing feature specs
Toggle commit list-
ffa85fcd...ef57c6e7 - 100 commits from branch
- A deleted user
added backend label
- Resolved by Pavel Shutsin
requested review from @ashrafkhamis, @akotte, and @nradina
- Resolved by Justin Ho Tuan Duong
- Resolved by Justin Ho Tuan Duong
- Resolved by Justin Ho Tuan Duong
- Resolved by Justin Ho Tuan Duong
- Resolved by Justin Ho Tuan Duong
- Resolved by Justin Ho Tuan Duong
- Resolved by Justin Ho Tuan Duong
- Resolved by Justin Ho Tuan Duong
- Resolved by Justin Ho Tuan Duong
removed review request for @ashrafkhamis
- Resolved by Justin Ho Tuan Duong
added 216 commits
-
34b04b8a...14286f6c - 209 commits from branch
master
- 146120a1 - Move Jira project key under enable vulnerabilities
- 59a7ef68 - Add help text to project keys
- ee5090ed - Improve warning messages around project key
- 7ea2fc54 - Add specs for basic rendering and logic
- 9081d2fb - Update section titles and checkbox labels
- 9bfd849c - Fix failing feature specs
- 29d4002e - Update copy from technical writing review
Toggle commit list-
34b04b8a...14286f6c - 209 commits from branch
- Resolved by Abhilash Kotte
requested review from @ashrafkhamis
- Resolved by Justin Ho Tuan Duong
- Resolved by Justin Ho Tuan Duong
- Resolved by Justin Ho Tuan Duong
removed review request for @ashrafkhamis
- Resolved by Nataliia Radina
added pipeline:mr-approved label
- Resolved by Pavel Shutsin
@nradina
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
requested review from @fguibert
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for a2f2b957expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 87 | 0 | 9 | 0 | 96 | ✅ | | Plan | 51 | 0 | 2 | 0 | 53 | ✅ | | Govern | 66 | 0 | 0 | 0 | 66 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Verify | 35 | 0 | 1 | 0 | 36 | ✅ | | Package | 24 | 0 | 6 | 0 | 30 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 308 | 0 | 19 | 0 | 327 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for a2f2b957expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Manage | 6 | 32 | 12 | 1 | 50 | ❌ | | Create | 0 | 0 | 15 | 0 | 15 | ➖ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 6 | 32 | 27 | 1 | 65 | ❌ | +--------+--------+--------+---------+-------+-------+--------+
added 312 commits
-
d0cc13d6...06c1289e - 304 commits from branch
master
- f939af6e - Move Jira project key under enable vulnerabilities
- ffa46166 - Add help text to project keys
- e6be96bc - Improve warning messages around project key
- a8089b09 - Add specs for basic rendering and logic
- 72cb1280 - Update section titles and checkbox labels
- b075780c - Fix failing feature specs
- f8aed602 - Update copy from technical writing review
- e0437368 - Update more copy and refactor code
Toggle commit list-
d0cc13d6...06c1289e - 304 commits from branch
reset approvals from @fguibert by pushing to the branch
requested review from @ashrafkhamis and removed review request for @fguibert and @nradina
removed review request for @ashrafkhamis
- Resolved by Justin Ho Tuan Duong
added 49 commits
-
eb030c85...f52fe519 - 40 commits from branch
master
- 2ef5b8cb - Move Jira project key under enable vulnerabilities
- 043e9a92 - Add help text to project keys
- 61fe9762 - Improve warning messages around project key
- d2c88bbf - Add specs for basic rendering and logic
- 108d9aab - Update section titles and checkbox labels
- 67a1776c - Fix failing feature specs
- 8dee851e - Update copy from technical writing review
- 54947a7b - Update more copy and refactor code
- a2f2b957 - Update section description
Toggle commit list-
eb030c85...f52fe519 - 40 commits from branch
requested review from @pshutsin
removed review request for @akotte
mentioned in issue gitlab-com/www-gitlab-com#34665 (closed)
changed milestone to %17.0
added missed:16.11 label
removed review request for @pshutsin
enabled an automatic merge when the pipeline for 0323e020 succeeds
mentioned in commit 6a8d6bfb
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
mentioned in merge request !149964 (merged)
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added pipelinetier-3 label