Skip to content
Snippets Groups Projects

Jira issues - Clean up issue creation section UI in settings form

All threads resolved!

What does this MR do and why?

This change is behind the feature flag jira_multiple_project_keys. Previous MR !148004 (merged).

  • Move Jira project key under the Enable Jira issue creation from vulnerabilities checkbox.
  • Remove the extra badge Ultimate next to the checkbox.
  • Add help text for Jira project keys input and polish UI.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before - without feature flag Before - with feature flag After
Jira_issues_section_-_ff_disabled Jira_issues_section_-_ff_enabled Jira_issues_after

How to set up and validate locally

  1. In rails console enable the experiment fully

    Feature.enable(:jira_multiple_project_keys)
  2. Go to Project > Settings > Integrations > Jira. For example, http://127.0.0.1:3000/gitlab-org/gitlab-test/-/settings/integrations/jira/edit.

Related to #452161 (closed)

Edited by Justin Ho Tuan Duong

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Justin Ho Tuan Duong
  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 113eb396 and a2f2b957

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.3 MB 4.3 MB - 0.0 %
    mainChunk 3.29 MB 3.29 MB - 0.0 %

    Note: We do not have exact data for 113eb396. So we have used data from: 8e13dbd1.
    The target commit was too new, so we used the latest commit from master we have info on.
    It might help to rerun the bundle-size-review job
    This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • requested review from @ashrafkhamis

  • Ashraf Khamis removed review request for @ashrafkhamis

    removed review request for @ashrafkhamis

  • mentioned in merge request !148903 (merged)

  • added 106 commits

    • ffa85fcd...ef57c6e7 - 100 commits from branch master
    • 001799de - Move Jira project key under enable vulnerabilities
    • abf222f5 - Add help text to project keys
    • 738109bd - Improve warning messages around project key
    • 6e471b57 - Add specs for basic rendering and logic
    • e55a27d3 - Update section titles and checkbox labels
    • 3987383a - Fix failing feature specs

    Compare with previous version

  • A deleted user added backend label

    added backend label

  • requested review from @ashrafkhamis, @akotte, and @nradina

  • Ashraf Khamis removed review request for @ashrafkhamis

    removed review request for @ashrafkhamis

  • added 1 commit

    • 34b04b8a - Update copy from technical writing review

    Compare with previous version

  • added 216 commits

    • 34b04b8a...14286f6c - 209 commits from branch master
    • 146120a1 - Move Jira project key under enable vulnerabilities
    • 59a7ef68 - Add help text to project keys
    • ee5090ed - Improve warning messages around project key
    • 7ea2fc54 - Add specs for basic rendering and logic
    • 9081d2fb - Update section titles and checkbox labels
    • 9bfd849c - Fix failing feature specs
    • 29d4002e - Update copy from technical writing review

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Justin Ho Tuan Duong changed the description

    changed the description

  • added 1 commit

    • d0cc13d6 - Update copy from technical writing review

    Compare with previous version

  • Abhilash Kotte
  • requested review from @ashrafkhamis

  • Ashraf Khamis removed review request for @ashrafkhamis

    removed review request for @ashrafkhamis

  • Nataliia Radina approved this merge request

    approved this merge request

  • Nataliia Radina requested review from @fguibert

    requested review from @fguibert

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for a2f2b957

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Create      | 87     | 0      | 9       | 0     | 96    | ✅     |
    | Plan        | 51     | 0      | 2       | 0     | 53    | ✅     |
    | Govern      | 66     | 0      | 0       | 0     | 66    | ✅     |
    | Data Stores | 31     | 0      | 0       | 0     | 31    | ✅     |
    | Verify      | 35     | 0      | 1       | 0     | 36    | ✅     |
    | Package     | 24     | 0      | 6       | 0     | 30    | ✅     |
    | Monitor     | 7      | 0      | 0       | 0     | 7     | ✅     |
    | Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 308    | 0      | 19      | 0     | 327   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :x: test report for a2f2b957

    expand test summary
    +-------------------------------------------------------------+
    |                       suites summary                        |
    +--------+--------+--------+---------+-------+-------+--------+
    |        | passed | failed | skipped | flaky | total | result |
    +--------+--------+--------+---------+-------+-------+--------+
    | Manage | 6      | 32     | 12      | 1     | 50    | ❌     |
    | Create | 0      | 0      | 15      | 0     | 15    | ➖     |
    +--------+--------+--------+---------+-------+-------+--------+
    | Total  | 6      | 32     | 27      | 1     | 65    | ❌     |
    +--------+--------+--------+---------+-------+-------+--------+
  • Florie Guibert approved this merge request

    approved this merge request

  • Justin Ho Tuan Duong changed the description

    changed the description

  • added 312 commits

    • d0cc13d6...06c1289e - 304 commits from branch master
    • f939af6e - Move Jira project key under enable vulnerabilities
    • ffa46166 - Add help text to project keys
    • e6be96bc - Improve warning messages around project key
    • a8089b09 - Add specs for basic rendering and logic
    • 72cb1280 - Update section titles and checkbox labels
    • b075780c - Fix failing feature specs
    • f8aed602 - Update copy from technical writing review
    • e0437368 - Update more copy and refactor code

    Compare with previous version

  • Justin Ho Tuan Duong reset approvals from @fguibert by pushing to the branch

    reset approvals from @fguibert by pushing to the branch

  • Justin Ho Tuan Duong requested review from @ashrafkhamis and removed review request for @fguibert and @nradina

    requested review from @ashrafkhamis and removed review request for @fguibert and @nradina

  • Ashraf Khamis approved this merge request

    approved this merge request

  • Ashraf Khamis removed review request for @ashrafkhamis

    removed review request for @ashrafkhamis

  • added 1 commit

    Compare with previous version

  • added 49 commits

    • eb030c85...f52fe519 - 40 commits from branch master
    • 2ef5b8cb - Move Jira project key under enable vulnerabilities
    • 043e9a92 - Add help text to project keys
    • 61fe9762 - Improve warning messages around project key
    • d2c88bbf - Add specs for basic rendering and logic
    • 108d9aab - Update section titles and checkbox labels
    • 67a1776c - Fix failing feature specs
    • 8dee851e - Update copy from technical writing review
    • 54947a7b - Update more copy and refactor code
    • a2f2b957 - Update section description

    Compare with previous version

  • Abhilash Kotte approved this merge request

    approved this merge request

  • Abhilash Kotte requested review from @pshutsin

    requested review from @pshutsin

  • Abhilash Kotte removed review request for @akotte

    removed review request for @akotte

  • changed milestone to %17.0

  • Pavel Shutsin approved this merge request

    approved this merge request

  • Pavel Shutsin removed review request for @pshutsin

    removed review request for @pshutsin

  • Pavel Shutsin resolved all threads

    resolved all threads

  • Pavel Shutsin enabled an automatic merge when the pipeline for 0323e020 succeeds

    enabled an automatic merge when the pipeline for 0323e020 succeeds

  • Pavel Shutsin mentioned in commit 6a8d6bfb

    mentioned in commit 6a8d6bfb

  • added workflowstaging label and removed workflowcanary label

  • Ashraf Khamis mentioned in merge request !149964 (merged)

    mentioned in merge request !149964 (merged)

  • Please register or sign in to reply
    Loading