Remove the temporary patch for "listing commits failed" error
What does this MR do and why?
Contributes to #452488 (closed)
Problem
gitaly!6590 (merged) introduced a
bug that was raising a listing commits
error if the repository was
empty.
I fixed it by adding an error handler for this error: Fix 500 error in Commits API when the repositor... (!148405 - merged)
Solution
This original bug was fixed on Gitaly side: gitaly!6801 (merged). The Rails patch is not necessary anymore.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
How to set up and validate locally
- Create a project with an empty repository (without README.md)
- Visit
http://127.0.0.1:3000/api/v4/projects/<project_id>/repository/commits
- You should see an empty array response instead of an internal error.
Merge request reports
Activity
changed milestone to %16.11
added backend groupsource code maintenanceremoval labels
assigned to @vyaklushin
added Category:Source Code Management devopscreate sectiondev labels
added typemaintenance label
1 Warning The master pipeline status page reported failures in If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the#master-broken
Slack channel.Reviewer roulette
Category Reviewer Maintainer backend @praba.m7n
(UTC+2, same timezone as author)
@digitalmoksha
(UTC-5, 7 hours behind author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in issue #452488 (closed)
added pipeline:run-all-rspec label
added 239 commits
-
0f4d4211...45ae55ba - 238 commits from branch
master
- 9dd5b75c - Remove the temporary patch for "listing commits failed" error
-
0f4d4211...45ae55ba - 238 commits from branch
added 536 commits
-
9dd5b75c...9ef96894 - 535 commits from branch
master
- 9483e314 - Remove the temporary patch for "listing commits failed" error
-
9dd5b75c...9ef96894 - 535 commits from branch
changed milestone to %17.0
removed pipeline:run-all-rspec label
- Resolved by Jerry Seto
Hi @praba.m7n!
Can you please review this MR?
requested review from @praba.m7n
removed review request for @praba.m7n
added pipeline:mr-approved label
- Resolved by Prabakaran Murugesan
@praba.m7n
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
requested review from @j.seto
added 36 commits
-
9483e314...d58eac93 - 34 commits from branch
master
- 682f0e97 - Remove the temporary patch for "listing commits failed" error
- 7e867674 - Add an extra test case
-
9483e314...d58eac93 - 34 commits from branch
reset approvals from @praba.m7n by pushing to the branch
removed review request for @j.seto
removed pipeline:mr-approved label
added 1294 commits
-
7e867674...1d72aff8 - 1292 commits from branch
master
- 635723c7 - Remove the temporary patch for "listing commits failed" error
- 98f786c4 - Add an extra test case
-
7e867674...1d72aff8 - 1292 commits from branch
requested review from @j.seto
added pipeline:mr-approved label
enabled an automatic merge when the pipeline for 5bc9cbf4 succeeds
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 98f786c4expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 87 | 0 | 9 | 0 | 96 | ✅ | | Plan | 51 | 0 | 2 | 0 | 53 | ✅ | | Govern | 66 | 0 | 0 | 0 | 66 | ✅ | | Verify | 35 | 0 | 1 | 0 | 36 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 24 | 0 | 6 | 0 | 30 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 308 | 0 | 19 | 0 | 327 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 98f786c4expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 600 | 0 | 66 | 9 | 666 | ✅ | | Package | 6 | 0 | 8 | 0 | 14 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Plan | 44 | 0 | 4 | 0 | 48 | ✅ | | Govern | 28 | 0 | 0 | 0 | 28 | ✅ | | Verify | 18 | 0 | 0 | 0 | 18 | ✅ | | Release | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 728 | 0 | 78 | 9 | 806 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
mentioned in commit f9132d4e
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!3058 (merged)
added releasedpublished label and removed releasedcandidate label
added pipelinetier-3 label