Skip to content

commit: Wait for the git-log(1) process to exit in FindCommits

Eric Ju requested to merge ej-5671_FindCommits-using-structured-error into master

This MR depends on !6589 (merged)

In this MR, we add a new wait logic to wait for git-log(1) command to finish;

Previously we did not Wait() for the git-log(1) process to exit in FindCommits, causing us to fail to include its execution time in the command details and not log any errors it returned.

We differentiate benign errors from real errors.

  • Benign errors are caused by terminating the stream since response limit is reached; while real errors are caused by git log command failures, such as timeout, OOM, or calling a non-existing commit.
  • If there is not commits returned, a RPC NotFound error is returned.

We used structured error message from !6589 (merged) to return NotFound error if git-log(1) command finished with error and no results

Closes #5671 (closed)

Merge request reports