Skip to content

Redesign create custom role permissions list

Daniel Tian requested to merge 438838-redesign-custom-role-permissions-list into master

What does this MR do and why?

On the Settings -> Roles and Permissions page, there's a form for creating new roles:

ksnip_20240404-160326

There is a list of permissions in the form. This MR changes the design of the permissions list.

Before After
ksnip_20240404-160511 ksnip_20240404-160453

How to set up and validate locally

  1. Go to any top-level group, then go to Settings -> Roles and Permissions.
  2. Click the New role button on the upper right.
  3. Verify that the permissions uses the new design as in the above screenshot.
  4. Do not fill out the form or select any permissions. Click on the Create role button at the bottom of the form.
  5. Verify that the permission names turn red.
  6. Select at least 1 permission, then click on Create role again. Verify that the permission names turn back to black.
  7. Select Admin vulnerability and verify that Read vulnerability is checked alongside it.
  8. Unselect Read vulnerability and verify that Admin vulnerability is unchecked alongside it.

Related to #438838 (closed)

Edited by Daniel Tian

Merge request reports

Loading