No BSO e-mail if current user is Owner
What does this MR do and why?
Relates to https://gitlab.com/gitlab-org/gitlab/-/issues/441796 and expands the functionality introduced with !146302 (merged). When the Owner is the one adding members (i.e., the current user), we skip sending the e-mail.
Note that this is a feature under development, behind a feature flag.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Example below:
-
In rails console enable the FF
Feature.enable(:block_seats_overages)
-
Visit any group or project with N seats in subscription
-
Make sure your logged in user has
Owner
role -
Make sure that all seats are occupied
-
Try to add another members
-
Check
http://127.0.0.1:3000/rails/letter_opener
– there should be no email
Alternatively, the template is available at http://localhost:3000/rails/mailers/notify/no_more_seats
-->
Merge request reports
Activity
assigned to @agulina
changed milestone to %16.10
removed frontend label
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @Quintasan
(UTC+2, same timezone as author)
@mkozono
(UTC-10, 12 hours behind author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Useradded 1 commit
- 521ff9e3 - Do not send email is current user is a Owner
changed milestone to %16.11
added missed:16.10 label
added 1721 commits
-
521ff9e3...fc6d601a - 1720 commits from branch
ag/441796-bso-email-owner
- 454bf37c - Do not send email is current user is a Owner
-
521ff9e3...fc6d601a - 1720 commits from branch
added 1 commit
- 22b5fab3 - Do not send email is current user is a Owner
Quarantined Fulfillment QA E2E Tests
The following Fulfillment QA E2E tests are in quarantine. If your changes would be covered by these tests, please be sure to perform manual testing.
Description Location Fulfillment Utilization when namespace storage usage hits the limit puts the namespace into read-only mode ./qa/specs/features/ee/browser_ui/11_fulfillment/utilization/namespace_storage_limit_spec.rb[1:1:1:1] Fulfillment Utilization when namespace storage usage goes back down below the limit reverts the namespace back to full-access mode ./qa/specs/features/ee/browser_ui/11_fulfillment/utilization/namespace_storage_limit_spec.rb[1:1:2:1] Fulfillment Utilization when admin sets user cap limit for group shows members over limit as pending for approvals ./qa/specs/features/ee/browser_ui/11_fulfillment/utilization/saas_user_caps_spec.rb[1:1:1:1] Fulfillment with an active subscription behaves like Purchase storage adds additional storage to group namespace ./qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_storage_spec.rb[1:2:1:1] Fulfillment without active subscription behaves like Purchase storage adds additional storage to group namespace ./qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_storage_spec.rb[1:1:1:1] Fulfillment with existing compute minutes packs behaves like Purchase storage adds additional storage to group namespace ./qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_storage_spec.rb[1:3:1:1] Fulfillment Purchase compute minutes with an active subscription adds additional minutes to group namespace ./qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_ci_spec.rb[1:1:2:1] Fulfillment Purchase compute minutes with existing compute minutes packs adds additional minutes to group namespace ./qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_ci_spec.rb[1:1:3:1] Fulfillment Purchase compute minutes without active subscription adds additional minutes to group namespace ./qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_ci_spec.rb[1:1:1:1] changed milestone to %17.0
- A deleted user
added frontend label
added 3405 commits
-
22b5fab3...5074f4ea - 3404 commits from branch
master
- 9a0f01ca - Do not send email if current user is Owner
-
22b5fab3...5074f4ea - 3404 commits from branch