Skip to content
Snippets Groups Projects

Remove references to code suggestions group setting

Merged Jessie Young requested to merge jy-ai-assisted-ui into master

What does this MR do and why?

  • This was for SaaS only and is no longer in use now that the purchase_code_suggestions feature flag has been rolled out
  • Cleanup for #432282 (closed)
  • Final cleanup will be to remove the actual attribute from the DB

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to validate locally

None needed, this is unused code now that the <code data-sourcepos="15:49-15:73">purchase_code_suggestions</code> feature flag is rolled out on gitlab.com

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 1 Message
    :book: This merge request adds or changes files that require a review from the Database team.

    This merge request requires a database review. To make sure these changes are reviewed, take the following steps:

    1. Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
    2. Prepare your MR for database review according to the docs.
    3. Assign and mention the database reviewer suggested by Reviewer Roulette.

    If you no longer require a database review, you can remove this suggestion by removing the database label and re-running the danger-review job.

    Reviewer roulette

    Category Reviewer Maintainer
    backend @jmontal profile link current availability (UTC-7, 1 hour ahead of author) @robotmay_gitlab profile link current availability (UTC+0, 8 hours ahead of author)
    frontend @a_akgun profile link current availability (UTC+3, 11 hours ahead of author) @ealcantara profile link current availability (UTC+1, 9 hours ahead of author)
    test for spec/features/* @jmontal profile link current availability (UTC-7, 1 hour ahead of author) Maintainer review is optional for test for spec/features/*

    Please check reviewer's status!

    • available Reviewer is available!
    • unavailable Reviewer is unavailable!

    Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

    Edited by Ghost User
  • Jessie Young
  • Jessie Young
  • mentioned in issue #405163 (closed)

  • Jessie Young
  • requested review from @mikolaj_wawrzyniak

  • Jessie Young added 1 commit

    added 1 commit

    • 11753521 - Remove references to code suggestions group setting

    Compare with previous version

  • A deleted user added databasereview pending label
  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-package-and-test: :white_check_mark: test report for 11753521

    expand test summary
    +---------------------------------------------------------------------+
    |                           suites summary                            |
    +----------------+--------+--------+---------+-------+-------+--------+
    |                | passed | failed | skipped | flaky | total | result |
    +----------------+--------+--------+---------+-------+-------+--------+
    | Create         | 548    | 0      | 93      | 18    | 641   | ✅     |
    | Fulfillment    | 8      | 0      | 75      | 4     | 83    | ✅     |
    | Verify         | 150    | 0      | 27      | 6     | 177   | ✅     |
    | Plan           | 246    | 0      | 13      | 0     | 259   | ✅     |
    | Govern         | 271    | 0      | 22      | 0     | 293   | ✅     |
    | Package        | 226    | 0      | 17      | 18    | 243   | ✅     |
    | Data Stores    | 116    | 0      | 31      | 1     | 147   | ✅     |
    | Manage         | 39     | 0      | 11      | 3     | 50    | ✅     |
    | Systems        | 8      | 0      | 0       | 0     | 8     | ✅     |
    | GitLab Metrics | 2      | 0      | 1       | 0     | 3     | ✅     |
    | Monitor        | 36     | 0      | 13      | 0     | 49    | ✅     |
    | Analytics      | 7      | 0      | 0       | 0     | 7     | ✅     |
    | Configure      | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Release        | 15     | 0      | 3       | 0     | 18    | ✅     |
    | Secure         | 6      | 0      | 3       | 0     | 9     | ✅     |
    | Growth         | 0      | 0      | 6       | 0     | 6     | ➖     |
    | ModelOps       | 0      | 0      | 3       | 0     | 3     | ➖     |
    +----------------+--------+--------+---------+-------+-------+--------+
    | Total          | 1679   | 0      | 327     | 50    | 2006  | ✅     |
    +----------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-gdk: :white_check_mark: test report for 11753521

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Create      | 57     | 0      | 12      | 0     | 69    | ✅     |
    | Package     | 24     | 0      | 2       | 0     | 26    | ✅     |
    | Govern      | 65     | 0      | 1       | 0     | 66    | ✅     |
    | Plan        | 53     | 0      | 0       | 0     | 53    | ✅     |
    | Verify      | 31     | 0      | 0       | 0     | 31    | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Data Stores | 31     | 0      | 1       | 0     | 32    | ✅     |
    | Monitor     | 7      | 0      | 0       | 0     | 7     | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 275    | 0      | 17      | 0     | 292   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    Edited by Ghost User
  • Mikołaj Wawrzyniak approved this merge request

    approved this merge request

  • Mikołaj Wawrzyniak requested review from @robotmay_gitlab and @jmontal and removed review request for @mikolaj_wawrzyniak

    requested review from @robotmay_gitlab and @jmontal and removed review request for @mikolaj_wawrzyniak

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading