Change admin users search filter

What does this MR do and why?

Change admin users search filter

New admin users search is supposed to have better UX to filter users

Changelog: added

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before	After
before	after

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

1. Being an admin visit the page /admin/users
2. Verify that now you are able to filter users using filter-search component Filters should include

• Access level
  • Administrator
  • External
• two factor authentication
  • On
  • Off
• State
  • Blocked
  • Banned
  • Pending approval
  • Deactivated
  • Without project
  • Trusted

3. Verify that sorting and pagination work as it used to do

Related to #238183 (closed) and #448885 (closed)

added typefeature label

Hey @bahek2462774!

Thank you for your contribution to GitLab. Please refer to the contribution documentation for an overview of the process.

When you're ready for a first review, post @gitlab-bot ready. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with @gitlab-bot ready @user1 @user2.

At any time, if you need help, feel free to post @gitlab-bot help or initiate a mentor session on Discord. Read more on how to get help.

You can comment @gitlab-bot label <label1> <label2> to add labels to your MR. Please see the list of allowed labels in the label command documentation.

This message was generated automatically. You're welcome to improve it.

added Community contribution workflowin dev labels

assigned to @bahek2462774

added linked-issue label

mentioned in issue #238183 (closed)

	14 Warnings
	This merge request is quite big (509 lines changed), please consider splitting it into multiple merge requests.
	ec46878c: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	660e94a5: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
	a304c68e: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines.
	d8e43f41: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	52d9464a: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines.
	310a119d: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines.
	310a119d: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	c97f961e: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
	1ac4f4b0: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines.
	2146514f: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines.
	c033f3a0: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	This merge request contains lines with testid selectors. Please ensure e2e:package-and-test job is run.
	Labels missing: please ask a reviewer or maintainer to add backend, QA to this merge request.

testid selectors

The following changed lines in this MR contain testid selectors:

app/views/admin/users/_users.html.haml

-      = gl_tab_link_to admin_users_path(filter: "blocked_pending_approval"), { item_active: active_when(params[:filter] == 'blocked_pending_approval'), class: 'filter-blocked-pending-approval gl-border-0!', data: { testid: 'pending-approval-tab' } } do
-.row-content-block.gl-border-0{ data: { testid: "filtered-search-block" } }
-        = search_field_tag :search_query, params[:search_query], placeholder: s_('AdminUsers|Search by name, email, or username'), class: 'form-control search-text-input js-search-input', spellcheck: false, data: { testid: 'user-search-field' }
+.admin-users-search.row-content-block.gl-lg-display-grid.gl-border-bottom-0.gl-border-top-0{ data: { testid: "filtered-search-block" } }

If the e2e:package-and-test job in the qa stage has run automatically, please ensure the tests are passing. If the job has not run, please start the trigger-omnibus-and-follow-up-e2e job in the qa stage and ensure the tests in follow-up-e2e:package-and-test-ee pipeline are passing.

For the list of known failures please refer to the latest pipeline triage issue.

If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.

Reviewer roulette

Category	Reviewer	Maintainer
backend	@arpitgogia (UTC+5.5)	@ebaque (UTC-3)
frontend	@syarynovskyi (UTC+3)	@ntepluhina (UTC+2)
QA	@jroodnick (UTC-7)	Maintainer review is optional for QA
test for spec/features/*	@hmuralidhar (UTC+10)	Maintainer review is optional for test for spec/features/*
UX	@ipelaez1 (UTC-4)	Maintainer review is optional for UX

Please check reviewer's status!

• Reviewer is available!
• Reviewer is unavailable!

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

mentioned in issue gitlab-org/quality/triage-reports#16284 (closed)

added frontend label

added Category:User Management admin dashboard labels

added devopsgovern groupauthentication sectionsec labels

added UX label

Thanks for helping us improve the UX of GitLab. Your contribution is appreciated! We have pinged our UX team, so stay tuned for their feedback.

This message was generated automatically. You're welcome to improve it.

requested review from @seggenberger

@seggenberger before review could you please read my comment here ? #238183 (comment 1775339790) Thanks

Hey @bahek2462774

Thank you for your contribution!

Also I've found a bug:

cc @sunjungp as we recently have looked into the filtered search together

removed review request for @seggenberger

marked this merge request as draft

added 810 commits

• 5f1b9e52...33eecda2 - 809 commits from branch gitlab-org:master
• 6a5a85c7 - Change admin users search filter

Compare with previous version

@bahek2462774 the sub tab Admins feels a little redudant given that it is an option as a filter token. What do you think about removing the tab and relocating the buttons?

Proposed	Removing tab