Skip to content

Add name field to organization group form

Peter Hegman requested to merge 410804-organization-owner-can-create-group-from-group-overview-add-path-field-2 into master

What does this MR do and why?

Related to #410804 (closed)

The grouptenant scale team is starting to build out an Organization MVC. For more information about what an "Organization" will be see https://docs.gitlab.com/ee/architecture/blueprints/organization/

This MR builds on top of !142598 (merged) and !143709 (merged) to continue building out the form to add a group to an organization. This MR adds the Group Name field to the form. When the user types in the Group name field it will pre-populate the Group URL field with the slugified version. If the user has explicitly modified the Group URL field it will not change when typing in the Group name field. See reviewer notes for changes in future MRs.

Reviewer notes

  1. GlFormFields does not yet support rendering error messages from API calls. I have gitlab-ui!3849 (merged) open to add support for this. When that is merged we will be able to show the error message that says Group path is unavailable. Path has been replaced with a suggested available path.
  2. Future MRs will add:
    • Visibility radio buttons
    • Your group name must not contain a period if you intend to use SCIM integration, as it can lead to errors. alert that is shown on https://gitlab.com/groups/new#create-group-pane
    • API call that creates the group
  3. The plan is to use this new Vue form to refactor /groups/new#create-group-pane (#440464) and /admin/groups/new (#440466) to Vue in the future.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screen_Recording_2024-02-11_at_9.23.34_PM

How to set up and validate locally

  1. Open Rails console
    • bin/rails console
  2. Enable the feature flag
    • Feature.enable(:ui_for_organizations)
  3. Navigate to /-/organizations/default/groups/new
Edited by Peter Hegman

Merge request reports