Migrate "New group" form to Vue
Background
Currently the "New group" form (https://gitlab.com/groups/new#create-group-pane) is a mixture of Vue/HAML/jQuery. We are in the process of building the form out in Vue for Organizations in #410804 (closed). Once that is complete we should use that Vue form for the main "New group" form to reduce technical debt and have a consistent UX experience across all of GitLab.
Proposal
Use the Vue from build in #410804 (closed) to migrate the from on https://gitlab.com/groups/new#create-group-pane
Implementation guide
- Create a
new_group_app.vue
file inapp/assets/javascripts/groups/components
- Render
app/assets/javascripts/groups/components/new_edit_group_form.vue
- Move the
newSubgroup
logic in app/assets/javascripts/groups/components/group_name_and_path.vue#L314 intoapp/assets/javascripts/groups/components/new_group_form.vue
- Add hidden inputs in
new_group_app.vue
that update with the values fromapp/assets/javascripts/groups/components/new_group_form.vue
. - Mount form in
app/views/groups/_new_group_fields.html.haml
- Update feature specs and QA E2E tests
Designs
- Show closed items
Blocks
- #370468Backlog3
- #477826Backlog
- #442799Backlog
Is blocked by
Relates to
- #440466Backlog5
- #468333Backlog5
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Peter Hegman added to epic &12259
added to epic &12259
- Maintainer
@peterhegman, Please add a group or category label to identify issue ownership.You can refer to the Features by Group handbook page for guidance.
If you are unsure about the correct group, please do not leave the issue without a group label, and refer to GitLab's shared responsibility functionality guidelines for more information on how to triage this kind of issue.
This message was generated automatically. You're welcome to improve it.
- Peter Hegman added workflowblocked label
added workflowblocked label
- Peter Hegman set weight to 5
set weight to 5
- Peter Hegman marked this issue as blocked by #410804 (closed)
marked this issue as blocked by #410804 (closed)
- 🤖 GitLab Bot 🤖 added sectioncore platform label
added sectioncore platform label
- Peter Hegman cloned to #440466
cloned to #440466
- Peter Hegman changed the description
Compare with previous version changed the description
- Christina Lohr added Category:Groups & Projects label
added Category:Groups & Projects label
- Christina Lohr changed the description
Compare with previous version changed the description
- Peter Hegman mentioned in epic &12259
mentioned in epic &12259
- Christina Lohr changed milestone to %Backlog
changed milestone to %Backlog
- Peter Hegman mentioned in merge request !143709 (merged)
mentioned in merge request !143709 (merged)
- Christina Lohr marked this issue as related to #440466
marked this issue as related to #440466
- Peter Hegman mentioned in merge request !144425 (merged)
mentioned in merge request !144425 (merged)
- Peter Hegman mentioned in merge request !145326 (merged)
mentioned in merge request !145326 (merged)
- Peter Hegman mentioned in merge request !146001 (merged)
mentioned in merge request !146001 (merged)
- Peter Hegman removed workflowblocked label
removed workflowblocked label
- Peter Hegman added workflowready for development label
added workflowready for development label
- Peter Hegman marked this issue as blocking #370468
marked this issue as blocking #370468
- Peter Hegman changed the description
Compare with previous version changed the description
- Peter Hegman mentioned in issue #370468
mentioned in issue #370468
- Christina Lohr changed milestone to %17.3
changed milestone to %17.3
- Peter Hegman mentioned in merge request !148911 (merged)
mentioned in merge request !148911 (merged)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17271 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17271 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17347 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17347 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17446 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17446 (closed)
- Abdul Wadood mentioned in merge request !150707 (merged)
mentioned in merge request !150707 (merged)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17613 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17613 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17716 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17716 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17798 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17798 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#17904 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17904 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#18069 (closed)
mentioned in issue gitlab-org/quality/triage-reports#18069 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#18168 (closed)
mentioned in issue gitlab-org/quality/triage-reports#18168 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#18252 (closed)
mentioned in issue gitlab-org/quality/triage-reports#18252 (closed)
- Peter Hegman changed the description
Compare with previous version changed the description
- Peter Hegman mentioned in issue #468333
mentioned in issue #468333
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#18360 (closed)
mentioned in issue gitlab-org/quality/triage-reports#18360 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#18441 (closed)
mentioned in issue gitlab-org/quality/triage-reports#18441 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#18637 (closed)
mentioned in issue gitlab-org/quality/triage-reports#18637 (closed)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#18724 (closed)
mentioned in issue gitlab-org/quality/triage-reports#18724 (closed)
- Christina Lohr added milestonep2 label
added milestonep2 label
- Developer
@peterhegman Would this issue update the form for all of the following actions?
- The form that opens on the group overview page when clicking the
New subgroup
button (either in the header, or from theSubgroups and projects
tab empty state) - The form that opens when clicking on
New group
inYour Work > Groups
- The form that opens when clicking on
New group
inExplore > Groups
- The form that opens on the group overview page when clicking the
Collapse replies - Author Maintainer
- Developer
@peterhegman I moved this one back to the %Backlog for now, because we have quite a few things in flux with the filtering and list migrations and also completing the User tab migration to Vue, so let's finalize those first before starting to work on the forms.
1
- Christina Lohr changed milestone to %Backlog
changed milestone to %Backlog
- Christina Lohr marked this issue as related to #468333
marked this issue as related to #468333
- Christina Lohr marked this issue as related to #477826
marked this issue as related to #477826
- Christina Lohr removed the relation with #477826
removed the relation with #477826
- Christina Lohr marked this issue as blocking #477826
marked this issue as blocking #477826
- Christina Lohr marked this issue as blocking #442799
marked this issue as blocking #442799
- Peter Hegman mentioned in issue pgh-test-group/subgroup-project#1 (moved)
mentioned in issue pgh-test-group/subgroup-project#1 (moved)
- Peter Hegman mentioned in issue #479887
mentioned in issue #479887
- 🤖 GitLab Bot 🤖 added devopstenant scale grouporganizations sectioninfrastructure platforms labels and removed devopsdata stores grouptenant scale [DEPRECATED] sectioncore platform labels
added devopstenant scale grouporganizations sectioninfrastructure platforms labels and removed devopsdata stores grouptenant scale [DEPRECATED] sectioncore platform labels
- Christina Lohr changed milestone to %17.9
changed milestone to %17.9
- Christina Lohr changed milestone to %17.10
changed milestone to %17.10
- Christina Lohr removed milestonep2 label
removed milestonep2 label
- Christina Lohr changed milestone to %Backlog
changed milestone to %Backlog