Fix CODEOWNERS rule to ignore Verify specs
What does this MR do and why?
Fix CODEOWNERS rule to ignore Verify specs
The generic rule /**/lib/**/ci/
was not intended to capture spec files.
It turns out that was catching directories like /spec/lib/**/ci/
as well as /ee/spec/lib/**/ci/
.
Changelog: fixed
For example, this MR !143208 (merged) required Verify approval unnecessarily.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
changed milestone to %16.9
added backend devopsverify sectionci typebug labels
assigned to @fabiopitino
mentioned in merge request !143208 (merged)
requested review from @rymai
1 Warning 09ed29d0: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer .gitlab/CODEOWNERS
Reviewer review is optional for .gitlab/CODEOWNERS
@stanhu
(UTC-8, 8 hours behind author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User- Resolved by Rémy Coutable
@rymai could you review?
- Resolved by Fabio Pitino
- Resolved by Fabio Pitino
- Resolved by Rémy Coutable
@rymai
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
removed review request for @rymai
@cheryl.li could you review and merge this change? I thought that Remy was an approver for this.
requested review from @cheryl.li
@cheryl.li, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 4 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to auto-merge.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
mentioned in commit 8f136e07
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2763 (merged)