Skip to content
Snippets Groups Projects

Fix CODEOWNERS rule to ignore Verify specs

Merged Fabio Pitino requested to merge ignore-verify-section-specs into master
All threads resolved!

What does this MR do and why?

Fix CODEOWNERS rule to ignore Verify specs

The generic rule /**/lib/**/ci/ was not intended to capture spec files. It turns out that was catching directories like /spec/lib/**/ci/ as well as /ee/spec/lib/**/ci/.

Changelog: fixed

For example, this MR !143208 (merged) required Verify approval unnecessarily.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Fabio Pitino

Merge request reports

Merged results pipeline #1159501226 passed

Merged results pipeline passed for 96897f1f

Approval is optional

Merged by Cheryl LiCheryl Li 1 year ago (Feb 9, 2024 10:08pm UTC)

Merge details

  • Changes merged into master with 8f136e07 (commits were squashed).
  • Deleted the source branch.

Pipeline #1171564755 passed

Pipeline passed for 8f136e07 on master

10 environments impacted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Fabio Pitino resolved all threads

    resolved all threads

  • Fabio Pitino added 1 commit

    added 1 commit

    • 4351754a - Apply 2 suggestion(s) to 1 file(s)

    Compare with previous version

  • Fabio Pitino changed title from Fix CODEOWNERS rule to ignore Verify specs for lib to Fix CODEOWNERS rule to ignore Verify specs

    changed title from Fix CODEOWNERS rule to ignore Verify specs for lib to Fix CODEOWNERS rule to ignore Verify specs

  • Fabio Pitino changed the description

    changed the description

  • Rémy Coutable approved this merge request

    approved this merge request

  • Rémy Coutable resolved all threads

    resolved all threads

  • Rémy Coutable removed review request for @rymai

    removed review request for @rymai

  • @cheryl.li could you review and merge this change? I thought that Remy was an approver for this.

  • Fabio Pitino requested review from @cheryl.li

    requested review from @cheryl.li

  • Cheryl Li approved this merge request

    approved this merge request

  • merged

  • @cheryl.li, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 4 hours ago, you should:

    1. Ensure the merge request is not in Draft status.
    2. Start a pipeline (especially important for Community contribution merge requests).
    3. Set the merge request to auto-merge.

    This is a guideline, not a rule. Please consider replying to this comment for transparency.

    This message was generated automatically. You're welcome to improve it.

  • Cheryl Li mentioned in commit 8f136e07

    mentioned in commit 8f136e07

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading