Skip to content

Run auto-remediation MR test for old modal

Lorenz van Herwaarden requested to merge make-sure-auto-remediation-test-is-run into master

What does this MR do and why?

Related #434353

In Only resolve vulnerability E2E test on old modal (!141755 - merged) • Lorenz van Herwaarden • 16.9 I introduced a check to make sure the auto-remediation MR spec from /qa/qa/specs/features/ee/browser_ui/10_govern/vulnerability_management_spec.rb:107 is not run for the new modal.

Unfortunately, the test is now never run because firstly, the security report widget is not expand and the modal is not opened before checking the selector, and secondly, if we fixed that part, the selector is available on both the old and new modal, so this does not work.

In this MR, I make sure the security report widget is expanded and the finding is clicked (and hence opening the modal), before checking a selector (I'm checking #modal-mrwidget-security-issue, which is only available on the old modal).

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

GITLAB_QA_ACCESS_TOKEN=<your-token> \
GITLAB_USERNAME="root" \
GITLAB_PASSWORD='<root-password>' \
WEBDRIVER_HEADLESS=false \
QA_GITLAB_URL="http://gdk.test:3000" \
bundle exec rspec qa/specs/features/ee/browser_ui/10_govern/vulnerability_management_spec.rb:107

Merge request reports