Skip to content

Only resolve vulnerability E2E test on old modal

Lorenz van Herwaarden requested to merge only-run-create-mr-e2e-old-modal into master

What does this MR do and why?

Related #434353

When the new finding modal is shown from the MR security widget, this is when the feature flag standalone_finding_modal_merge_request_widget is enabled, the "Resolve with merge request" action is not shown anymore for newly detected findings. This causes the spec vulnerability_management_spec.rb#L107 to fail.

In Add "can download remediation patch from mr wid... (#434353) • Unassigned • Backlog we'll add a test for the "Download remediation patch" action for the new modal. But in the mean time, to unblock [Feature flag] Integrate standalone finding mod... (#425936 - closed) • Lorenz van Herwaarden • 16.9 • On track, we make sure the test checks whether we're on the old or new modal and only conditionally runs the action and check.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

GITLAB_QA_ACCESS_TOKEN=<your-token> \
GITLAB_USERNAME="root" \
GITLAB_PASSWORD='<root-password>' \
WEBDRIVER_HEADLESS=false \
QA_GITLAB_URL="http://gdk.test:3000" \
bundle exec rspec qa/specs/features/ee/browser_ui/10_govern/vulnerability_management_spec.rb:107
Edited by Lorenz van Herwaarden

Merge request reports