Add "can download remediation patch from mr widget" E2E test
Summary
With Hide Resolve with merge request action for newl... (#428890 - closed) • Subashis Chakraborty, Lorenz van Herwaarden • 16.7 the ability to resolve a newly found finding with a merge request via the new finding modal has been removed. Therefore, the test case 'can create an auto-remediation MR from mr security widget'
in qa/qa/specs/features/ee/browser_ui/10_govern/vulnerability_management_spec.rb
should not be tested when the new modal is used. Instead, we can test "can download remediation patch from mr widget".
Feature flag info
Suggestion
-
'can create an auto-remediation MR from mr security widget' -> only test when the feature flag
standalone_finding_modal_merge_request_widget
is disabled - create new test 'can download remediation patch from mr widget' when
standalone_finding_modal_merge_request_widget
is enabled. Possibly this could also run with the feature flag disabled, but it'll need other selectors perhaps because it will be rendering in another modal.
Context for how the resolve with merge request can still be tested with standalone_finding_modal_merge_request_widget
enabled.
After the MR is merged to the default branch, the finding has a vulnerability related to it and presentOnDefaultBranch is true. On the vulnerability report, clicking the vulnerability would lead you to the vulnerability details page. There is a "Resolve with merge request" option there, but I think we would still want to test that action in the finding modal. So I think, after the MR is merged, we'd need to go to the default branch latest pipeline (post MR merge) > security tab and open the finding modal. The option to "Resolve with merge request" should be there.