Add possibility to add new branch rules
What does this MR do and why?
Add possibility to add new branch rules
Add dropdown and modal for branch rule creation
Changelog: changed
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Enable
add_branch_rule
FF - Go to any project Settings > Repository
- Observe branch rule section, and add branch rule button/dropdown
Related to #388128 (closed)
Merge request reports
Activity
changed milestone to %16.8
assigned to @nradina
- A deleted user
added backend feature flag labels
- Resolved by Nataliia Radina
2 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @syarynovskyi
(UTC+2, 1 hour ahead of author)
@kerrizor
(UTC-8, 9 hours behind author)
frontend @robyrne
(UTC+0, 1 hour behind author)
@pgascouvaillancourt
(UTC-5, 6 hours behind author)
UX @annabeldunstone
(UTC+0, 1 hour behind author)
Maintainer review is optional for UX Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits d0b45c61 and a2c81946
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.12 MB 4.12 MB - 0.0 % mainChunk 3.09 MB 3.09 MB - 0.0 % Significant Growth: 2Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.settings.repository.create_deploy_token 600.29 KB 632.49 KB +32.21 KB 5.4 % pages.projects.settings.repository.show 600.26 KB 632.47 KB +32.21 KB 5.4 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@leipert
,@markrian
,@pgascouvaillancourt
,@sdejonge
or@thutterer
) for review, if you are unsure about the size increase.Note: We do not have exact data for d0b45c61. So we have used data from: bd689b1c.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerE2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for a2c81946expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 54 | 0 | 7 | 0 | 61 | ✅ | | Verify | 31 | 0 | 0 | 0 | 31 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Data Stores | 21 | 0 | 2 | 0 | 23 | ✅ | | Govern | 67 | 0 | 0 | 0 | 67 | ✅ | | Package | 15 | 0 | 1 | 0 | 16 | ✅ | | Plan | 54 | 0 | 1 | 0 | 55 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 256 | 0 | 12 | 0 | 268 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for a2c81946expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 278 | 2 | 28 | 4 | 308 | ❌ | | Govern | 6 | 0 | 0 | 0 | 6 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 304 | 2 | 30 | 4 | 336 | ❌ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for a2c81946expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Create | 8 | 0 | 2 | 2 | 10 | ✅ | | Govern | 3 | 0 | 0 | 0 | 3 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 4 | 2 | 24 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
added UX label
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@f13c9c4e
added 1670 commits
-
a8662203...8759b101 - 1669 commits from branch
master
- 0b1143c4 - Add possibility to add new branch rules
-
a8662203...8759b101 - 1669 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@bfa554a7
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@16470031
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@5a327df8
requested review from @tvellishetty
requested review from @andrei.zubov
- Resolved by Paul Gascou-Vaillancourt
@andrei.zubov could you please perform initial frontend review?
@tvellishetty could you please perform initial backend review
- Resolved by Nataliia Radina
- Resolved by Nataliia Radina
@andrei.zubov thank you so much for the great review! I have replied to your comments
Thanks for clarification, @nradina! Looks good to me
@pgascouvaillancourt Could you please help with the maintainer review?The frontend looks good to me, thanks @nradina! It looks like we'll need to create the FF rollout issue before we merge: !140319 (comment 1706031082). Could you look into it and ping me again?
@pgascouvaillancourt this makes sense! I have added the rollout issue, please have another look
@pgascouvaillancourt thanks!
Sorry I seem to miss some of the comments.
- Resolved by Nataliia Radina
- Resolved by Paul Gascou-Vaillancourt
@tvellishetty
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
requested review from @kerrizor and removed review request for @tvellishetty
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@34ec459f
requested review from @pgascouvaillancourt
- Resolved by Paul Gascou-Vaillancourt
- Resolved by Paul Gascou-Vaillancourt
added 952 commits
-
80360fc5...063c1bd6 - 950 commits from branch
master
- 063967a0 - Add possibility to add new branch rules
- bd105cac - Add rollout issue
-
80360fc5...063c1bd6 - 950 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@80b785b3
mentioned in issue #437086
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@319e88ee
enabled an automatic merge when the pipeline for b27d561b succeeds
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@b27d561b
mentioned in commit ce9fd52c
added workflowstaging-canary label
@nradina This merge request was deployed to the workflowstaging-canary environment. You may want to enable the associated feature flag on this environment with/chatops run feature set add_branch_rule true --staging
.This message was generated automatically. You're welcome to improve it.
@nradina This merge request was deployed to the workflowcanary environment. You may want to enable the associated feature flag on this environment with/chatops run feature set add_branch_rule true --production
.This message was generated automatically. You're welcome to improve it.
@nradina This merge request was deployed to the workflowstaging environment. You may want to enable the associated feature flag on this environment with/chatops run feature set add_branch_rule true --staging
.This message was generated automatically. You're welcome to improve it.
@nradina This merge request was deployed to the workflowproduction environment. You may want to enable the associated feature flag on this environment with/chatops run feature set add_branch_rule true --production
.This message was generated automatically. You're welcome to improve it.
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2720 (merged)
mentioned in issue gitlab-org/quality/pipeline-triage#246 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#251 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20597 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20960 (closed)
mentioned in issue gitlab-org/quality/triage-reports#21530 (closed)
mentioned in issue gitlab-org/quality/triage-reports#22034