Use toast for preferences saved notification
What does this MR do and why?
Toasts are the preferred pattern for giving users transient positive feedback about immediate actions. This MR changes user preference save interactions to use Toasts instead of Alerts.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Check out this branch
- Visit user preferences on the GDK
- Update user preferences
- Choose a new theme (does not require clicking Save button)
- Update your user's home page (will require clicking Save to apply)
When each of the updates is applied, you will see a toast in the bottom left corner. You will not see a blue alert at the top of the page.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #331162 (closed)
Merge request reports
Activity
changed milestone to %16.8
assigned to @clavimoniere
added UX Paper Cuts label
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend @aalakkad
(UTC+3, 8 hours ahead of author)
@justin_ho
(UTC+7, 12 hours ahead of author)
test for spec/features/*
@hmuralidhar
(UTC+11, 16 hours ahead of author)
Maintainer review is optional for test for spec/features/*
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost UserBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits fada90d7 and 9821f690
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.12 MB 4.12 MB - 0.0 % mainChunk 3.09 MB 3.09 MB - 0.0 %
Note: We do not have exact data for fada90d7. So we have used data from: e5c4b45e.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by Ghost UserE2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 9821f690expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 23 | 0 | 0 | 0 | 23 | ✅ | | Create | 54 | 0 | 7 | 0 | 61 | ✅ | | Verify | 31 | 0 | 0 | 0 | 31 | ✅ | | Govern | 72 | 0 | 0 | 0 | 72 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Package | 15 | 0 | 1 | 0 | 16 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 264 | 0 | 9 | 0 | 273 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 9821f690expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 292 | 0 | 20 | 10 | 312 | ✅ | | Create | 149 | 0 | 16 | 2 | 165 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 461 | 0 | 38 | 12 | 499 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for 748fad9dexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Govern | 61 | 0 | 2 | 0 | 63 | ✅ | | Create | 6 | 0 | 4 | 0 | 10 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 76 | 0 | 9 | 0 | 85 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Useradded 1 commit
- 748fad9d - Use toast for preferences saved notification
- Resolved by Chad Lavimoniere
@seggenberger can you do a groupux paper cuts review on this? This is my first time doing anything with toasts.
requested review from @seggenberger
- Resolved by Chad Lavimoniere
@seggenberger
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
removed review request for @seggenberger
requested review from @aalakkad
added bugux label
mentioned in issue #435225
- Resolved by Chad Lavimoniere
- Resolved by Justin Ho Tuan Duong
frontend LGTM, thanks!
I left one thought to the maintainer.
Hey @pburdette
Would you review this merge request, please?
Thanks!
requested review from @pburdette and removed review request for @aalakkad
removed review request for @pburdette
added 1 commit
- 53640fc8 - Use toast for preferences saved notification
requested review from @justin_ho
- Resolved by Chad Lavimoniere
No idea why pipelines are failing here, the failures are unrelated to my changes
added 1619 commits
-
53640fc8...35f60ee9 - 1618 commits from branch
master
- 90573ccb - Use toast for preferences saved notification
-
53640fc8...35f60ee9 - 1618 commits from branch
- Resolved by Chad Lavimoniere
- Resolved by Chad Lavimoniere
removed review request for @justin_ho
requested review from @justin_ho
enabled an automatic merge when the pipeline for 00e8887d succeeds
mentioned in commit 2c1615a5
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added groupfoundations label and removed groupauthentication label
added devopsmanage sectioncore platform labels and removed devopsgovern sectionsec labels
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2720 (merged)