Fix sticky header on vulnerability reports

changed milestone to %Backlog

added Category:Vulnerability Management Threat InsightsNavy bugux devopsgovern frontend groupthreat insights priority4 sectionsec severity4 typebug workflowrefinement + 1 deleted label

assigned to @dpisek

	1 Warning
	You've made some app changes, but didn't add any tests. That's OK as long as you're refactoring existing code, but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
frontend	`@jmontal` (UTC-7, 8 hours behind author)	`@mrincon` (UTC+1, same timezone as author)

Please check reviewer's status!

Reviewer is available!
Reviewer is unavailable!

Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 3667fc4e and 5ffee589

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	4.09 MB	4.09 MB	-	0.0 %
mainChunk	3.05 MB	3.05 MB	-	0.0 %

Note: We do not have exact data for 3667fc4e. So we have used data from: 9562ebbb.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.

Please look at the full report for more details

Allure report

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for 5ffee589

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Plan             | 55     | 0      | 0       | 0     | 55    | ✅     |
| Data Stores      | 23     | 0      | 0       | 0     | 23    | ✅     |
| Verify           | 31     | 0      | 0       | 0     | 31    | ✅     |
| Govern           | 57     | 0      | 0       | 0     | 57    | ✅     |
| Create           | 54     | 0      | 7       | 0     | 61    | ✅     |
| Release          | 5      | 0      | 0       | 0     | 5     | ✅     |
| Analytics        | 2      | 0      | 0       | 0     | 2     | ✅     |
| Monitor          | 8      | 0      | 0       | 0     | 8     | ✅     |
| Manage           | 0      | 0      | 1       | 0     | 1     | ➖     |
| Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
| Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 235    | 0      | 10      | 0     | 245   | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: test report for 5ffee589

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Govern           | 292    | 0      | 23      | 3     | 315   | ❗     |
| Create           | 140    | 1      | 14      | 0     | 155   | ❌     |
| Plan             | 4      | 0      | 0       | 0     | 4     | ✅     |
| Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
| Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
| Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
| Data Stores      | 2      | 0      | 0       | 0     | 2     | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 442    | 1      | 39      | 3     | 482   | ❌     |
+------------------+--------+--------+---------+-------+-------+--------+

e2e-review-qa: test report for 5ffee589

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Govern           | 51     | 0      | 2       | 0     | 53    | ✅     |
| Create           | 6      | 0      | 4       | 0     | 10    | ✅     |
| Plan             | 3      | 0      | 1       | 0     | 4     | ✅     |
| Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
| Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
| Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
| Data Stores      | 2      | 0      | 0       | 0     | 2     | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 66     | 0      | 9       | 0     | 75    | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+

added 489 commits

cb52ff47...df17bd0c - 488 commits from branch master
84ae151a - Fix sticky th on pipeline and instance vuln report

Compare with previous version

added 1 commit

5ffee589 - Fix sticky header on vulnerability reports

Compare with previous version

changed title from Draft: Fix sticky th on pipeline and instance vuln report to Draft: Fix sticky header on vulnerability reports

changed the description

     // The checkboxes use z-index: 1, so we need to place the headers higher so that the checkboxes
     // don't show on top of the headers when scrolling down.
     @include gl-z-index-2;
     top: calc(#{$calc-application-header-height} + var(--security-filter-height));
     top: calc(#{$calc-application-header-height} + var(--security-filter-height) + var(--group-by-selection-height));
     // Need to use an inset box-shadow here for the bottom border because position: sticky will hide
     // any borders once the table headers become sticky.
     box-shadow: inset 0 -1px $gray-100;
+  }
   thead.below-selection-summary th {
     top: calc(#{$calc-application-header-height} + var(--security-filter-height) + #{$selection-summary-height});
     top: calc(#{$calc-application-header-height} + var(--security-filter-height) + #{$selection-summary-height} + var(--group-by-selection-height) );

Fix sticky header on vulnerability reports

What does this MR do and why?

Screenshots or screen recordings

Pipeline

Instance

How to set up and validate locally

MR acceptance checklist

Activity

Reviewer roulette

Bundle size analysis [beta]

Special assets

Allure report

Fix sticky header on vulnerability reports

What does this MR do and why?

Screenshots or screen recordings

Pipeline

Instance

How to set up and validate locally

MR acceptance checklist

Merge request reports

Activity

Reviewer roulette

Bundle size analysis [beta]

Special assets

Allure report