Rename runner_fleet category to fleet_visibility
What does this MR do and why?
Given the renaming that happened in gitlab-com/www-gitlab-com!131699 (merged), this MR changes the feature category name accordingly in the code base.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
n/a
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
n/a
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
added devopsverify grouprunner maintenancerefactor sectionci + 1 deleted label
assigned to @pedropombeiro
added typemaintenance label
- A deleted user
added backend database databasereview pending frontend labels
2 Warnings b01daf74: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. There were no new or modified feature flag YAML files detected in this MR. If the changes here are already controlled under an existing feature flag, please add
the feature flagexists. Otherwise, if you think the changes here don't need
to be under a feature flag, please add the label feature flagskipped, and
add a short comment about why we skipped the feature flag.For guidance on when to use a feature flag, please see the documentation.
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
db/docs/ci_runner_machines.yml
(Link to current live version) -
db/docs/ci_runner_versions.yml
(Link to current live version) -
db/docs/ci_runners.yml
(Link to current live version) -
db/docs/namespace_ci_cd_settings.yml
(Link to current live version) -
db/docs/p_ci_finished_build_ch_sync_events.yml
(Link to current live version) -
db/docs/p_ci_runner_machine_builds.yml
(Link to current live version) -
db/docs/project_ci_cd_settings.yml
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @jnutt
(UTC+8, 7 hours ahead of author)
@terrichu
(UTC-5, 6 hours behind author)
database @dskim_gitlab
(UTC+11, 10 hours ahead of author)
@l.rosa
(UTC-3, 4 hours behind author)
frontend @eduardobonet
(UTC+1, same timezone as author)
@vitallium
(UTC+1, same timezone as author)
test for spec/features/*
@jnutt
(UTC+8, 7 hours ahead of author)
Maintainer review is optional for test for spec/features/*
~"Verify" Reviewer review is optional for ~"Verify" @mrincon
(UTC+1, same timezone as author)
~"Verify" Reviewer review is optional for ~"Verify" @mrincon
(UTC+1, same timezone as author)
~"Clickhouse" Reviewer review is optional for ~"Clickhouse" @cablett
(UTC+13, 12 hours ahead of author)
~"Verify" Reviewer review is optional for ~"Verify" @stanhu
(UTC-8, 9 hours behind author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Sidekiq queue changes
This merge request contains changes to Sidekiq queues. Please follow the documentation on changing a queue's urgency.
These queues had their attributes changed:
cronjob:ci_runners_reconcile_existing_runner_versions_cron
cronjob:ci_runners_stale_machines_cleanup_cron
ci_runners_process_runner_version_update
cronjob:ci_runners_stale_group_runners_prune_cron
cronjob:click_house_ci_finished_builds_sync_cron
click_house_ci_finished_builds_sync
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User-
added 1 commit
- 3db40c9a - Rename runner_fleet category to fleet_visibility
- A deleted user
added documentation label
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for b01daf74expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Govern | 57 | 0 | 0 | 0 | 57 | ✅ | | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Create | 54 | 0 | 7 | 0 | 61 | ✅ | | Data Stores | 23 | 0 | 0 | 0 | 23 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Verify | 31 | 0 | 0 | 0 | 31 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 228 | 0 | 10 | 0 | 238 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for b01daf74expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Verify | 138 | 0 | 27 | 0 | 165 | ✅ | | Create | 149 | 0 | 16 | 0 | 165 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | | Govern | 6 | 0 | 0 | 0 | 6 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 313 | 0 | 47 | 0 | 360 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Userrequested review from @mrincon
- Resolved by Vladimir Shushlin
Hey @serenafang
, mind doing the test initial review?
requested review from @serenafang
@vshushlin mind doing the clickhouse review?
requested review from @vshushlin
added 66 commits
-
3db40c9a...f9e2c8c4 - 64 commits from branch
master
- db036808 - Update feature categories to 2023-12-04
- 4ff36c9d - Rename runner_fleet category to fleet_visibility
-
3db40c9a...f9e2c8c4 - 64 commits from branch
- Resolved by Vladimir Shushlin
@vshushlin
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
added pipeline:mr-approved label
- Resolved by Vladimir Shushlin
Thanks, @pedropombeiro!
I approved what I can, but you still need more
Also, FYI: I pushed back a little on the new name itself.