Omit Solutions docs from TW review
What does this MR do and why?
The Solutions Architecture team is adding content to the Docs site which will not be maintained by the Technical Writing team (see #430270 (closed)).
This MR updates Danger to not prompt MR authors to get a Technical Writing review for pages in this section.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Create a test page in the
doc/solutions
directory:mkdir doc/solutions && echo "# Just Testing" > doc/solutions/index.md
- Commit it:
git ci doc/solutions -m "Add a test Solutions page"
- Run danger:
bin/rake danger_local
On this branch, you should not get a prompt to request a Technical Writing review. On the master branch, you will.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #430270 (closed)
Merge request reports
Activity
changed milestone to %16.6
added Technical Writing automation:ml maintenancerefactor typemaintenance labels
assigned to @sarahgerman
mentioned in issue #430270 (closed)
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer ~"Tooling" Reviewer review is optional for ~"Tooling" @rymai
(UTC+1, 7 hours ahead of author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Userrequested review from @splattael
- Resolved by Sarah German
@splattael Hi Peter
can you give this a review please? We're adding some new content to the Docs site that will not be maintained by Technical Writers, and so we need to have Danger not suggest adding a TW reviewer for those.We're only adding the first new section (Solutions Architecture docs) for now but will likely add more to
SKIP_TW_REVIEW_PATHS
soon. Thank you!
- Resolved by Peter Leitzen
@splattael
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
enabled an automatic merge when the pipeline for 25207860 succeeds
mentioned in commit eb02e720
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label