Exclude productAnalyticsState in graphql fields for issue spec
What does this MR do and why?
When running rspec spec/requests/api/graphql/project/issues_spec.rb
locally, were getting error such as
1) getting an issue list for a project behaves like graphql issue list request spec behaves like a working graphql query returns a successful response
Failure/Error: expect(flattened_errors).to eq([])
expected: []
got: [{"locations"=>[{"column"=>3, "line"=>445}], "message"=>"\"productAnalyticsState\" field can be reque... "path"=>["project", "issues", "nodes", 4, "designCollection", "project", "productAnalyticsState"]}]
Add productAnalyticsState
to the graphql field exclusion list
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.6
added backend groupproject management typemaintenance labels
assigned to @digitalmoksha
added devopsplan sectiondev labels
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @marcogreg
(UTC+8, 13 hours ahead of author)
@acook.gitlab
(UTC-4, 1 hour ahead of author)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Useradded 1 commit
- a9aa8b70 - Exclude productAnalyticsState in graphql fields
@sgarg_gitlab would you mind doing a quick maintainer review on this minor spec fix?
requested review from @sgarg_gitlab
added pipeline:mr-approved label
@cwoolley-gitlab, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 4 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to auto-merge.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
mentioned in commit 8d7948f6
requested review from @cwoolley-gitlab
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label