Update loading of streaming destinations
What does this MR do and why?
Show loading icon when waiting for HTTP or GCP Logging destinations. Previously loading would disappear once one type of destination had loaded. Now it will only disappear once all loaded
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
- From a top level group with ultimate license navigate to streaming audit events
- Secure -> Audit Events -> Streams
- Add, edit and delete both HTTP and GCP Logging destinations
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #416692 (closed)
Merge request reports
Activity
changed milestone to %16.5
assigned to @nrosandich
- Resolved by Nate Rosandich
@lorenzvanherwaarden can you please do the initial review on this since it was your original suggestion
requested review from @lorenzvanherwaarden
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Serhii Yarynovskyi (
@syarynovskyi
) (UTC+3)Phil Hughes (
@iamphill
) (UTC+1)UX Mike Nichols (
@mnichols1
) (UTC-4)Maintainer review is optional for UX groupcompliance Reviewer review is optional for groupcompliance Sam Figueroa (
@sam.figueroa
) (UTC+2)Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User- Resolved by Anna Vovchenko
@cam.x can you please review for UX and groupcompliance ?
requested review from @cam.x
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 02fb6916 and 17f2929c
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.23 MB 4.23 MB - 0.0 % mainChunk 3.1 MB 3.1 MB - 0.0 %
Note: We do not have exact data for 02fb6916. So we have used data from: 265ca82e.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by Ghost UserAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 17f2929cexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 51 | 0 | 0 | 0 | 51 | ✅ | | Data Stores | 18 | 0 | 2 | 0 | 20 | ✅ | | Govern | 35 | 0 | 1 | 0 | 36 | ✅ | | Verify | 8 | 0 | 0 | 0 | 8 | ✅ | | Create | 37 | 0 | 1 | 0 | 38 | ✅ | | Manage | 12 | 0 | 1 | 0 | 13 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 161 | 0 | 5 | 0 | 166 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for 17f2929cexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Govern | 34 | 0 | 1 | 0 | 35 | ✅ | | Monitor | 4 | 0 | 0 | 1 | 4 | ❗ | | Create | 8 | 0 | 1 | 2 | 9 | ❗ | | Data Stores | 1 | 0 | 1 | 0 | 2 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 51 | 0 | 6 | 3 | 57 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost User- Resolved by Nate Rosandich
@mlapierre can you please help me understand why the
gdk-qa-reliable
pipeline is failing here?
@cam.x
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
- Resolved by Nate Rosandich
@nrosandich Some end-to-end (E2E) tests should run based on the stage label.
Please start the
trigger-omnibus-and-follow-up-e2e
job in theqa
stage and ensure tests in thefollow-up-e2e:package-and-test-ee
pipeline pass before this MR is merged. (E2E tests are computationally intensive and don't run automatically for every push/rebase, so we ask you to run this job manually at least once.)To run all E2E tests, apply the pipeline:run-all-e2e label and run a new pipeline.
E2E test jobs are allowed to fail due to flakiness. See current failures at the latest pipeline triage issue.
Once done, apply the
emoji on this comment.Team members only: for any questions or help, reach out on the internal
#quality
Slack channel.added 206 commits
-
1e4abec1...a0fdc152 - 204 commits from branch
master
- 9973173a - Update loading of streaming destinations
- 17f2929c - Update spec to resolve only one request
-
1e4abec1...a0fdc152 - 204 commits from branch
removed review request for @lorenzvanherwaarden
- Resolved by Anna Vovchenko
@anna_vovchenko can you please do the maintainer review?
requested review from @anna_vovchenko
enabled an automatic merge when the pipeline for cf5a138c succeeds
@anna_vovchenko, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 6 hours ago OR finished more than 2 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to auto-merge.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
mentioned in commit ab45a945
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in issue #416692 (closed)
mentioned in issue gitlab-com/www-gitlab-com#34645 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2517 (merged)
mentioned in merge request gitlab-com/www-gitlab-com!133792 (merged)