Skip to content
Snippets Groups Projects

Update loading of streaming destinations

Merged Nate Rosandich requested to merge 416692-follow-up-for-gcp-destination-loading into master
All threads resolved!

What does this MR do and why?

Show loading icon when waiting for HTTP or GCP Logging destinations. Previously loading would disappear once one type of destination had loaded. Now it will only disappear once all loaded

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

  1. From a top level group with ultimate license navigate to streaming audit events
    1. Secure -> Audit Events -> Streams
  2. Add, edit and delete both HTTP and GCP Logging destinations
    1. https://docs.gitlab.com/ee/administration/audit_event_streaming/

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #416692 (closed)

Edited by Nate Rosandich

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @nrosandich Some end-to-end (E2E) tests should run based on the stage label.

    Please start the trigger-omnibus-and-follow-up-e2e job in the qa stage and ensure tests in the follow-up-e2e:package-and-test-ee pipeline pass before this MR is merged. (E2E tests are computationally intensive and don't run automatically for every push/rebase, so we ask you to run this job manually at least once.)

    To run all E2E tests, apply the pipeline:run-all-e2e label and run a new pipeline.

    E2E test jobs are allowed to fail due to flakiness. See current failures at the latest pipeline triage issue.

    Once done, apply the :white_check_mark: emoji on this comment.

    Team members only: for any questions or help, reach out on the internal #quality Slack channel.

  • Nate Rosandich added 1 commit

    added 1 commit

    • 1e4abec1 - Update spec to resolve only one request

    Compare with previous version

  • Nate Rosandich added 206 commits

    added 206 commits

    Compare with previous version

  • Lorenz van Herwaarden approved this merge request

    approved this merge request

  • removed review request for @lorenzvanherwaarden

  • requested review from @anna_vovchenko

  • Anna Vovchenko approved this merge request

    approved this merge request

  • Anna Vovchenko resolved all threads

    resolved all threads

  • Anna Vovchenko enabled an automatic merge when the pipeline for cf5a138c succeeds

    enabled an automatic merge when the pipeline for cf5a138c succeeds

  • Anna Vovchenko resolved all threads

    resolved all threads

  • merged

  • @anna_vovchenko, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 6 hours ago OR finished more than 2 hours ago, you should:

    1. Ensure the merge request is not in Draft status.
    2. Start a pipeline (especially important for Community contribution merge requests).
    3. Set the merge request to auto-merge.

    This is a guideline, not a rule. Please consider replying to this comment for transparency.

    This message was generated automatically. You're welcome to improve it.

  • Anna Vovchenko mentioned in commit ab45a945

    mentioned in commit ab45a945

  • added workflowstaging label and removed workflowcanary label

  • mentioned in issue #416692 (closed)

  • Please register or sign in to reply
    Loading