Add support for Mastodon as user social
What does this MR do and why?
Add support for Mastodon as user social
Relates to #428442 (closed)
Screenshots or screen recordings
How to set up and validate locally
- Enable the FF for the user
Feature.enable(:mastodon_social_ui, user)
- Edit a user's profile
- Add a mastodon username
@riley@example.org
- Save the profile
- Open the user's profile
- Observe the Mastodon social link being rendered as
https://example.org/@riley
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @stingrayza
- A deleted user
- Resolved by Raimund Hook
- Resolved by Raimund Hook
1 Warning There were no new or modified SaaS feature YAML files detected in this MR. For guidance on when to use a SaaS feature, please see the SaaS feature documentation.
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/user/profile/index.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend serenafang
(UTC-5, 6 hours behind
@stingrayza
)michold
(UTC+2, 1 hour ahead of
@stingrayza
)database dstull
(UTC-4, 5 hours behind
@stingrayza
)ahegyi
(UTC+2, 1 hour ahead of
@stingrayza
)frontend sdejonge
(UTC+11, 10 hours ahead of
@stingrayza
)fguibert
(UTC+10, 9 hours ahead of
@stingrayza
)Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
- A deleted user
added Data WarehouseImpact Check label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits c1c942f5 and fb2df5c6
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.14 MB 4.14 MB - 0.0 % mainChunk 3.08 MB 3.08 MB - 0.0 %
Note: We do not have exact data for c1c942f5. So we have used data from: 70417ba1.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for fb2df5c6expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Verify | 20 | 0 | 0 | 0 | 20 | ✅ | | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Data Stores | 18 | 0 | 4 | 0 | 22 | ✅ | | Create | 40 | 0 | 6 | 0 | 46 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 48 | 0 | 0 | 0 | 48 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 185 | 0 | 13 | 0 | 198 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for fb2df5c6expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 3 | 0 | 0 | 0 | 3 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Data Stores | 1 | 0 | 1 | 0 | 2 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 19 | 0 | 5 | 0 | 24 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for fb2df5c6expand test summary
+------------------------------------------------------------+ | suites summary | +-------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------+--------+--------+---------+-------+-------+--------+ +-------+--------+--------+---------+-------+-------+--------+ | Total | 0 | 0 | 0 | 0 | 0 | ➖ | +-------+--------+--------+---------+-------+-------+--------+
added 221 commits
-
ecbd9fc3...8b4825f2 - 220 commits from branch
gitlab-org:master
- bd886956 - Add support for Mastodon as user social
-
ecbd9fc3...8b4825f2 - 220 commits from branch
Database migrations (on the main database)
1 Warnings 20230927124202 - AddMastodonToUserDetails had a query that exceeded timing guidelines. Run
time should not exceed 100ms, but it was 10468.12ms. Please consider possible options to improve the
query performance.ALTER TABLE user_details VALIDATE CONSTRAINT check_f1a8a05b9a
Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).
Migration Type Total runtime Result DB size change 20230927124202 - AddMastodonToUserDetails Regular 15.1 s +0.00 B Runtime Histogram for all migrations
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 6 0.1 seconds - 1 second 0 1 second - 5 seconds 0 5 seconds - 15 seconds 1 15 seconds - 5 minutes 0 5 minutes + 0 Migration: 20230927124202 - AddMastodonToUserDetails- Type: Regular
- Duration: 15.1 s
- Database size change: +0.00 B
Calls Total Time Max Time Mean Time Rows Query 1 10468.1 ms 10468.1 ms 10468.1 ms 0 ALTER TABLE user_details VALIDATE CONSTRAINT check_f1a8a05b9a
1 35.6 ms 35.6 ms 35.6 ms 0 ALTER TABLE user_details ADD CONSTRAINT check_f1a8a05b9a CHECK ( char_length(mastodon) <= 500 ) NOT VALID
1 20.8 ms 20.8 ms 20.8 ms 0 ALTER TABLE "user_details" ADD "mastodon" text DEFAULT '' NOT NULL
1 0.0 ms 0.0 ms 0.0 ms 1 SELECT "feature_gates"."key", "feature_gates"."value" FROM "feature_gates" WHERE "feature_gates"."feature_key" = $1
1 0.0 ms 0.0 ms 0.0 ms 1 SELECT $1::regtype::oid
2 0.0 ms 0.0 ms 0.0 ms 2 SELECT pg_backend_pid()
Histogram for AddMastodonToUserDetails
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 6 0.1 seconds - 1 second 0 1 second - 5 seconds 0 5 seconds - 15 seconds 1 15 seconds - 5 minutes 0 5 minutes + 0 Other information
No other migrations pending on GitLab.com
Clone details
Clone ID Clone Created At Clone Data Timestamp Expected Removal Time database-testing-2426819-11567661-main
2023-10-19T04:59:18Z 2023-10-19T00:24:13Z 2023-10-19 17:03:41 +0000 database-testing-2426819-11567661-ci
2023-10-19T04:59:18Z 2023-10-19T04:45:36Z 2023-10-19 17:03:41 +0000 Database migrations (on the ci database)
Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).
Migration Type Total runtime Result DB size change 20230927124202 - AddMastodonToUserDetails Regular 4.0 s +0.00 B Runtime Histogram for all migrations
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 5 0.1 seconds - 1 second 1 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0 Migration: 20230927124202 - AddMastodonToUserDetails
- Type: Regular
- Duration: 4.0 s
- Database size change: +0.00 B
Calls Total Time Max Time Mean Time Rows Query 1 63.6 ms 63.6 ms 63.6 ms 0 ALTER TABLE "user_details" ADD "mastodon" text DEFAULT '' NOT NULL
1 23.4 ms 23.4 ms 23.4 ms 0 ALTER TABLE user_details ADD CONSTRAINT check_f1a8a05b9a CHECK ( char_length(mastodon) <= 500 ) NOT VALID
1 1.5 ms 1.5 ms 1.5 ms 0 ALTER TABLE user_details VALIDATE CONSTRAINT check_f1a8a05b9a
1 0.0 ms 0.0 ms 0.0 ms 1 SELECT $1::regtype::oid
2 0.0 ms 0.0 ms 0.0 ms 2 SELECT pg_backend_pid()
Histogram for AddMastodonToUserDetails
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 5 0.1 seconds - 1 second 1 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0 Other information
No other migrations pending on GitLab.com
Clone details
Clone ID Clone Created At Clone Data Timestamp Expected Removal Time database-testing-2426819-11567661-main
2023-10-19T04:59:18Z 2023-10-19T00:24:13Z 2023-10-19 17:03:41 +0000 database-testing-2426819-11567661-ci
2023-10-19T04:59:18Z 2023-10-19T04:45:36Z 2023-10-19 17:03:41 +0000
Brought to you by gitlab-org/database-team/gitlab-com-database-testing. Epic
- A deleted user
added database-testing-automation label
added 869 commits
-
bd886956...d0e798ec - 868 commits from branch
gitlab-org:master
- 782c3e56 - Add support for Mastodon as user social
-
bd886956...d0e798ec - 868 commits from branch
- Resolved by Adam Hegyi
@serenafang can you take backend review, please?
@minac can you take database review, please? (also, can you figure out why the pipeline is failing?)
@lorenzvanherwaarden can you take frontend review, please?
requested review from @serenafang, @minac, and @lorenzvanherwaarden
- Resolved by Raimund Hook
- Resolved by Raimund Hook
added databasereviewed label and removed databasereview pending label
requested review from @pslaughter and removed review request for @lorenzvanherwaarden
@lorenzvanherwaarden
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
- Resolved by Greg Alfaro
- Resolved by Raimund Hook
Thanks for working on this @stingrayza! Very nice feature!
I left you a small FE comment, but I left a security question for our security team. Back to you!
removed review request for @pslaughter
added Data WarehouseNot Impacted label and removed Data WarehouseImpact Check label
- Resolved by Raimund Hook
@jglassman1 can you review the documentation change, please?
requested review from @jglassman1
added Technical Writing label
mentioned in issue #428163 (closed)
added Category:User Profile label
- A deleted user
added feature flag grouptenant scale labels
added devopsdata stores sectioncore platform labels
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@7dd744f6
added 1 commit
- 93df81c6 - Update doc message with an 'introduced' blurb
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@af3db1ee
requested review from @pslaughter
- Resolved by Raimund Hook
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@8a035bfe
changed milestone to %16.5
requested review from @dgruzd
mentioned in issue #428446 (closed)
- Resolved by Raimund Hook
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@32dae3f4
- Resolved by Dmitry Gruzd
removed review request for @dgruzd
- Resolved by Adam Hegyi
- Resolved by Raimund Hook
removed review request for @pslaughter
changed milestone to %16.6
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@c8cb3f20
requested review from @dgruzd
added databaseapproved label and removed databasereviewed label
added 2225 commits
-
c3ff77e4...2ae099e9 - 2218 commits from branch
gitlab-org:master
- ba2104b9 - Add support for Mastodon as user social
- 2fac622f - Updates from review
- cf34663f - Added FF for UI elements with user actor
- f97d421b - Update doc message with an 'introduced' blurb
- 97fcf109 - Apply 1 suggestion(s) to 1 file(s)
- 5050e772 - Apply 1 suggestion(s) to 1 file(s)
- fb2df5c6 - Extract regex into constant
Toggle commit list-
c3ff77e4...2ae099e9 - 2218 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@4a78cb64
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@2cefffd0
enabled an automatic merge when the pipeline for 2cefffd0 succeeds
Hello @stingrayza
The database team is looking for ways to improve the database review process and we would love your help!
If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:
@gitlab-org/database-team
And someone will be by shortly!
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
mentioned in commit 97acd482
added workflowstaging-canary label
@stingrayza This merge request was deployed to the workflowstaging-canary environment. You may want to enable the associated feature flag on this environment with/chatops run feature set mastodon_social_ui true --staging
.This message was generated automatically. You're welcome to improve it.
@stingrayza This merge request was deployed to the workflowcanary environment. You may want to enable the associated feature flag on this environment with/chatops run feature set mastodon_social_ui true --production
.This message was generated automatically. You're welcome to improve it.
@stingrayza This merge request was deployed to the workflowstaging environment. You may want to enable the associated feature flag on this environment with/chatops run feature set mastodon_social_ui true --staging
.This message was generated automatically. You're welcome to improve it.
@stingrayza This merge request was deployed to the workflowproduction environment. You may want to enable the associated feature flag on this environment with/chatops run feature set mastodon_social_ui true --production
.This message was generated automatically. You're welcome to improve it.
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in merge request !134760 (merged)
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request !137339 (merged)
mentioned in merge request kubitus-project/kubitus-installer!2601 (merged)
added devopstenant scale grouporganizations sectioninfrastructure platforms labels and removed devopsdata stores grouptenant scale [DEPRECATED] sectioncore platform labels
added sectioncore platform label and removed sectioninfrastructure platforms label