Skip to content
Snippets Groups Projects

Add support for Mastodon as user social

Merged Raimund Hook requested to merge gitlab-community/gitlab:stingrayza/add-mastodon into master
1 unresolved thread

What does this MR do and why?

Add support for Mastodon as user social

Relates to #428442 (closed)

Screenshots or screen recordings

image

image

How to set up and validate locally

  1. Enable the FF for the user
    Feature.enable(:mastodon_social_ui, user)
  2. Edit a user's profile
  3. Add a mastodon username @riley@example.org
  4. Save the profile
  5. Open the user's profile
  6. Observe the Mastodon social link being rendered as https://example.org/@riley

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Raimund Hook

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ghost User
  • Contributor
    1 Warning
    :warning: There were no new or modified SaaS feature YAML files detected in this MR.

    For guidance on when to use a SaaS feature, please see the SaaS feature documentation.

    1 Message
    :book: This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge.

    Documentation review

    The following files require a review from a technical writer:

    The review does not need to block merging this merge request. See the:

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend serenafang current availability (UTC-5, 6 hours behind @stingrayza) michold current availability (UTC+2, 1 hour ahead of @stingrayza)
    database dstull current availability (UTC-4, 5 hours behind @stingrayza) ahegyi current availability (UTC+2, 1 hour ahead of @stingrayza)
    frontend sdejonge current availability (UTC+11, 10 hours ahead of @stingrayza) fguibert current availability (UTC+10, 9 hours ahead of @stingrayza)

    Please check reviewer's status!

    • available Reviewer is available!
    • unavailable Reviewer is unavailable!

    Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • A deleted user added Data WarehouseImpact Check label
  • Contributor

    Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits c1c942f5 and fb2df5c6

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.14 MB 4.14 MB - 0.0 %
    mainChunk 3.08 MB 3.08 MB - 0.0 %

    Note: We do not have exact data for c1c942f5. So we have used data from: 70417ba1.
    The target commit was too new, so we used the latest commit from master we have info on.
    It might help to rerun the bundle-size-review job
    This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for fb2df5c6

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Verify           | 20     | 0      | 0       | 0     | 20    | ✅     |
    | Plan             | 55     | 0      | 0       | 0     | 55    | ✅     |
    | Data Stores      | 18     | 0      | 4       | 0     | 22    | ✅     |
    | Create           | 40     | 0      | 6       | 0     | 46    | ✅     |
    | Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Govern           | 48     | 0      | 0       | 0     | 48    | ✅     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Manage           | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 185    | 0      | 13      | 0     | 198   | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+

    e2e-review-qa: :white_check_mark: test report for fb2df5c6

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Govern           | 3      | 0      | 0       | 0     | 3     | ✅     |
    | Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Plan             | 3      | 0      | 1       | 0     | 4     | ✅     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Data Stores      | 1      | 0      | 1       | 0     | 2     | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 19     | 0      | 5       | 0     | 24    | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :heavy_minus_sign: test report for fb2df5c6

    expand test summary
    +------------------------------------------------------------+
    |                       suites summary                       |
    +-------+--------+--------+---------+-------+-------+--------+
    |       | passed | failed | skipped | flaky | total | result |
    +-------+--------+--------+---------+-------+-------+--------+
    +-------+--------+--------+---------+-------+-------+--------+
    | Total | 0      | 0      | 0       | 0     | 0     | ➖     |
    +-------+--------+--------+---------+-------+-------+--------+
  • Raimund Hook added 221 commits

    added 221 commits

    Compare with previous version

  • Contributor

    Database migrations (on the main database)

    1 Warnings
    :warning: 20230927124202 - AddMastodonToUserDetails had a query that exceeded timing guidelines. Run
    time should not exceed 100ms, but it was 10468.12ms. Please consider possible options to improve the
    query performance.
    ALTER TABLE user_details VALIDATE CONSTRAINT check_f1a8a05b9a

    Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).

    Migration Type Total runtime Result DB size change
    20230927124202 - AddMastodonToUserDetails Regular 15.1 s :warning: +0.00 B
    Runtime Histogram for all migrations
    Query Runtime Count
    0 seconds - 0.01 seconds 0
    0.01 seconds - 0.1 seconds 6
    0.1 seconds - 1 second 0
    1 second - 5 seconds 0
    5 seconds - 15 seconds 1
    15 seconds - 5 minutes 0
    5 minutes + 0

    :warning: Migration: 20230927124202 - AddMastodonToUserDetails

    • Type: Regular
    • Duration: 15.1 s
    • Database size change: +0.00 B
    Calls Total Time Max Time Mean Time Rows Query
    1 10468.1 ms 10468.1 ms 10468.1 ms 0
    ALTER TABLE user_details VALIDATE CONSTRAINT check_f1a8a05b9a
    1 35.6 ms 35.6 ms 35.6 ms 0
    ALTER TABLE user_details ADD CONSTRAINT check_f1a8a05b9a CHECK ( char_length(mastodon) <= 500 ) NOT VALID
    1 20.8 ms 20.8 ms 20.8 ms 0
    ALTER TABLE "user_details" ADD "mastodon" text DEFAULT '' NOT NULL
    1 0.0 ms 0.0 ms 0.0 ms 1
    SELECT "feature_gates"."key", "feature_gates"."value"  FROM "feature_gates"  WHERE "feature_gates"."feature_key" = $1
    1 0.0 ms 0.0 ms 0.0 ms 1
    SELECT $1::regtype::oid
    2 0.0 ms 0.0 ms 0.0 ms 2
    SELECT pg_backend_pid()
    Histogram for AddMastodonToUserDetails
    Query Runtime Count
    0 seconds - 0.01 seconds 0
    0.01 seconds - 0.1 seconds 6
    0.1 seconds - 1 second 0
    1 second - 5 seconds 0
    5 seconds - 15 seconds 1
    15 seconds - 5 minutes 0
    5 minutes + 0

    Other information

    No other migrations pending on GitLab.com

    Clone details
    Clone ID Clone Created At Clone Data Timestamp Expected Removal Time
    database-testing-2426819-11567661-main 2023-10-19T04:59:18Z 2023-10-19T00:24:13Z 2023-10-19 17:03:41 +0000
    database-testing-2426819-11567661-ci 2023-10-19T04:59:18Z 2023-10-19T04:45:36Z 2023-10-19 17:03:41 +0000

    Job artifacts

    Database migrations (on the ci database)

    Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).

    Migration Type Total runtime Result DB size change
    20230927124202 - AddMastodonToUserDetails Regular 4.0 s :white_check_mark: +0.00 B
    Runtime Histogram for all migrations
    Query Runtime Count
    0 seconds - 0.01 seconds 0
    0.01 seconds - 0.1 seconds 5
    0.1 seconds - 1 second 1
    1 second - 5 seconds 0
    5 seconds - 15 seconds 0
    15 seconds - 5 minutes 0
    5 minutes + 0

    Migration: 20230927124202 - AddMastodonToUserDetails

    • Type: Regular
    • Duration: 4.0 s
    • Database size change: +0.00 B
    Calls Total Time Max Time Mean Time Rows Query
    1 63.6 ms 63.6 ms 63.6 ms 0
    ALTER TABLE "user_details" ADD "mastodon" text DEFAULT '' NOT NULL
    1 23.4 ms 23.4 ms 23.4 ms 0
    ALTER TABLE user_details ADD CONSTRAINT check_f1a8a05b9a CHECK ( char_length(mastodon) <= 500 ) NOT VALID
    1 1.5 ms 1.5 ms 1.5 ms 0
    ALTER TABLE user_details VALIDATE CONSTRAINT check_f1a8a05b9a
    1 0.0 ms 0.0 ms 0.0 ms 1
    SELECT $1::regtype::oid
    2 0.0 ms 0.0 ms 0.0 ms 2
    SELECT pg_backend_pid()
    Histogram for AddMastodonToUserDetails
    Query Runtime Count
    0 seconds - 0.01 seconds 0
    0.01 seconds - 0.1 seconds 5
    0.1 seconds - 1 second 1
    1 second - 5 seconds 0
    5 seconds - 15 seconds 0
    15 seconds - 5 minutes 0
    5 minutes + 0

    Other information

    No other migrations pending on GitLab.com

    Clone details
    Clone ID Clone Created At Clone Data Timestamp Expected Removal Time
    database-testing-2426819-11567661-main 2023-10-19T04:59:18Z 2023-10-19T00:24:13Z 2023-10-19 17:03:41 +0000
    database-testing-2426819-11567661-ci 2023-10-19T04:59:18Z 2023-10-19T04:45:36Z 2023-10-19 17:03:41 +0000

    Job artifacts


    Brought to you by gitlab-org/database-team/gitlab-com-database-testing. Epic

  • Raimund Hook resolved all threads

    resolved all threads

  • Raimund Hook added 869 commits

    added 869 commits

    Compare with previous version

  • requested review from @serenafang, @minac, and @lorenzvanherwaarden

  • Mehmet Emin INAC requested review from @ahegyi and removed review request for @minac

    requested review from @ahegyi and removed review request for @minac

  • Lorenz van Herwaarden approved this merge request

    approved this merge request

  • Lorenz van Herwaarden requested review from @pslaughter and removed review request for @lorenzvanherwaarden

    requested review from @pslaughter and removed review request for @lorenzvanherwaarden

  • :wave: @lorenzvanherwaarden, thanks for approving this merge request.

    This is the first time the merge request has been approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Serena Fang approved this merge request

    approved this merge request

  • Looking at this now! :eyes:

  • Paul Slaughter
  • Thanks for working on this @stingrayza! Very nice feature!

    I left you a small FE comment, but I left a security question for our security team. Back to you! :soccer:

  • Paul Slaughter removed review request for @pslaughter

    removed review request for @pslaughter

  • Raimund Hook added 1 commit

    added 1 commit

    Compare with previous version

  • Raimund Hook requested review from @jglassman1

    requested review from @jglassman1

  • Jon Glassman approved this merge request

    approved this merge request

  • mentioned in issue #428163 (closed)

  • Raimund Hook added 1 commit

    added 1 commit

    • 4d7a2b0a - Added FF for UI elements with user actor

    Compare with previous version

  • A deleted user added feature flag grouptenant scale labels
  • Raimund Hook added 1 commit

    added 1 commit

    • 93df81c6 - Update doc message with an 'introduced' blurb

    Compare with previous version

  • Raimund Hook requested review from @pslaughter

    requested review from @pslaughter

  • Raimund Hook added 1 commit

    added 1 commit

    • 91668f94 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Raimund Hook changed the description

    changed the description

  • Christina Lohr changed milestone to %16.5

    changed milestone to %16.5

  • Raimund Hook requested review from @dgruzd

    requested review from @dgruzd

  • mentioned in issue #428446 (closed)

  • Jon Glassman approved this merge request

    approved this merge request

  • Raimund Hook added 1 commit

    added 1 commit

    • ddb61557 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Dmitry Gruzd
  • Dmitry Gruzd removed review request for @dgruzd

    removed review request for @dgruzd

  • Adam Hegyi
  • Adam Hegyi
  • Greg Alfaro approved this merge request

    approved this merge request

  • Sorry for the delay. Looking at this now! :eyes:

  • Paul Slaughter approved this merge request

    approved this merge request

  • Thanks for working on this @stingrayza! With the FF addition, FE changes LGTM :thumbsup:

    lgtm

    Approving...

  • Paul Slaughter removed review request for @pslaughter

    removed review request for @pslaughter

  • Raimund Hook changed milestone to %16.6

    changed milestone to %16.6

  • Raimund Hook added 1 commit

    added 1 commit

    Compare with previous version

  • Raimund Hook requested review from @dgruzd

    requested review from @dgruzd

  • Adam Hegyi approved this merge request

    approved this merge request

  • added databaseapproved label and removed databasereviewed label

  • Raimund Hook added 2225 commits

    added 2225 commits

    • c3ff77e4...2ae099e9 - 2218 commits from branch gitlab-org:master
    • ba2104b9 - Add support for Mastodon as user social
    • 2fac622f - Updates from review
    • cf34663f - Added FF for UI elements with user actor
    • f97d421b - Update doc message with an 'introduced' blurb
    • 97fcf109 - Apply 1 suggestion(s) to 1 file(s)
    • 5050e772 - Apply 1 suggestion(s) to 1 file(s)
    • fb2df5c6 - Extract regex into constant

    Compare with previous version

  • Dmitry Gruzd resolved all threads

    resolved all threads

  • Dmitry Gruzd approved this merge request

    approved this merge request

  • Adam Hegyi resolved all threads

    resolved all threads

  • Adam Hegyi approved this merge request

    approved this merge request

  • Adam Hegyi enabled an automatic merge when the pipeline for 2cefffd0 succeeds

    enabled an automatic merge when the pipeline for 2cefffd0 succeeds

  • merged

  • Hello @stingrayza :wave:

    The database team is looking for ways to improve the database review process and we would love your help!

    If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:

    @gitlab-org/database-team

    And someone will be by shortly!

    Thanks for your help! :heart:

    This message was generated automatically. You're welcome to improve it.

  • Adam Hegyi mentioned in commit 97acd482

    mentioned in commit 97acd482

  • added workflowstaging label and removed workflowcanary label

  • Raimund Hook mentioned in merge request !134760 (merged)

    mentioned in merge request !134760 (merged)

  • Paul Slaughter mentioned in merge request !137339 (merged)

    mentioned in merge request !137339 (merged)

  • Please register or sign in to reply
    Loading