Remove the mr_activity_filters feature flag
What does this MR do and why?
Removes the mr_activity_filters
feature flag
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.5
added devopscreate featureaddition frontend groupcode review typefeature labels
assigned to @iamphill
added sectiondev label
mentioned in merge request !126998 (merged)
- A deleted user
added backend documentation labels
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/user/project/merge_requests/index.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Amparo Luna (
@a_luna
) (UTC-5, 6 hours behind@iamphill
)Vijay Hawoldar (
@vij
) (UTC+1, same timezone as@iamphill
)frontend Lorenz van Herwaarden (
@lorenzvanherwaarden
) (UTC+2, 1 hour ahead of@iamphill
)Enrique Alcántara (
@ealcantara
) (UTC+2, 1 hour ahead of@iamphill
)Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits ce8a4d81 and 477a9f42
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.22 MB 4.22 MB - -0.0 % mainChunk 3.09 MB 3.09 MB - 0.0 %
Note: We do not have exact data for ce8a4d81. So we have used data from: 2c6041b4.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 477a9f42expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 18 | 0 | 2 | 1 | 20 | ❗ | | Create | 45 | 0 | 2 | 0 | 47 | ✅ | | Plan | 51 | 0 | 0 | 0 | 51 | ✅ | | Govern | 34 | 0 | 0 | 0 | 34 | ✅ | | Manage | 12 | 0 | 1 | 0 | 13 | ✅ | | Verify | 8 | 0 | 0 | 0 | 8 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 168 | 0 | 5 | 1 | 173 | ❗ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 477a9f42expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 543 | 0 | 90 | 16 | 633 | ❗ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Govern | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Manage | 2 | 0 | 0 | 0 | 2 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | | Data Stores | 0 | 0 | 4 | 0 | 4 | ➖ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 565 | 0 | 98 | 16 | 663 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@50b9a6e6
requested review from @ntepluhina
@iamphill looks good to me
@ntepluhina
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
enabled an automatic merge when the pipeline for c92607b8 succeeds
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@c92607b8
mentioned in commit 0a7a9552
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label