Stream audit events to GCP logging for instance level UI
What does this MR do and why?
This adds a form to add the required fields for GCP Logging streaming APIs that was added here API to stream audit events to GCP logging for i... (&11303 - closed)
Screenshots or screen recordings
Audit-Events--Admin-Area--GitLab
How to set up and validate locally
- Go to any Admin Area
- Go to "Monitoring" > "Audit events"
- Click "Streams" tab
- Create a new streaming destination by clicking "Add streaming destination"
- Add, edit and delete both HTTP and GCP Logging destinations
- Ensure group level streaming has not been effected
- Ensure private key is not visible after first adding destination, but can be updated
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #415731 (closed)
Merge request reports
Activity
changed milestone to %16.4
added devopsgovern groupcompliance priority2 sectionsec typefeature workflowblocked labels
assigned to @nrosandich
added 236 commits
-
8fe4adf4...f963754d - 235 commits from branch
master
- d0d243a4 - Add instance GCP logging streaming destinations
-
8fe4adf4...f963754d - 235 commits from branch
- A deleted user
added frontend label
1 Warning This merge request is quite big (954 lines changed), please consider splitting it into multiple merge requests. 1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/administration/audit_event_streaming/index.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend minahilnichols
(UTC-4)
zcuddy
(UTC-5)
groupcompliance Reviewer review is optional for groupcompliance ahuntsman
(UTC-5)
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
added 428 commits
-
d0d243a4...ff548f44 - 427 commits from branch
master
- d186e762 - Add instance GCP logging streaming destinations
-
d0d243a4...ff548f44 - 427 commits from branch
added 1 commit
- b215a89a - Add instance GCP logging streaming destinations
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 264bcee7 and 24bafbb2
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.21 MB 4.21 MB - 0.0 % mainChunk 3.08 MB 3.08 MB - 0.0 % Significant Growth: 3Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.admin.audit_logs 950.09 KB 975.24 KB +25.15 KB 2.6 % pages.groups.audit_events 962.79 KB 987.94 KB +25.15 KB 2.6 % pages.projects.audit_events 1.01 MB 1.04 MB +25.15 KB 2.4 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@leipert
,@markrian
,@ohoral
or@pgascouvaillancourt
) for review, if you are unsure about the size increase.Note: We do not have exact data for 264bcee7. So we have used data from: 143b5377.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 24bafbb2expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 32 | 0 | 5 | 0 | 37 | ✅ | | Govern | 35 | 0 | 0 | 0 | 35 | ✅ | | Plan | 51 | 0 | 0 | 0 | 51 | ✅ | | Data Stores | 18 | 0 | 2 | 0 | 20 | ✅ | | Verify | 8 | 0 | 0 | 0 | 8 | ✅ | | Manage | 12 | 0 | 1 | 0 | 13 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 156 | 0 | 8 | 0 | 164 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for 4b606843expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Govern | 34 | 0 | 0 | 0 | 34 | ✅ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Data Stores | 1 | 0 | 1 | 0 | 2 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 51 | 0 | 5 | 0 | 56 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
added 1 commit
- 3f31fba0 - Add instance GCP logging streaming destinations
added 1 commit
- cfd68dbc - Add instance GCP logging streaming destinations
- A deleted user
added documentation label
added 164 commits
-
cfd68dbc...abd35028 - 163 commits from branch
master
- d377f425 - Add instance GCP logging streaming destinations
-
cfd68dbc...abd35028 - 163 commits from branch
added 1 commit
- e4d156ca - Add instance GCP logging streaming destinations
added 1 commit
- 8b568866 - Add instance GCP logging streaming destinations
changed milestone to %16.5
added missed:16.4 label
added 295 commits
-
8b568866...4bfea294 - 294 commits from branch
master
- 39ebed95 - Add instance GCP logging streaming destinations
-
8b568866...4bfea294 - 294 commits from branch
added 902 commits
-
39ebed95...05e94987 - 901 commits from branch
master
- 73e1de0e - Add instance GCP logging streaming destinations
-
39ebed95...05e94987 - 901 commits from branch
mentioned in merge request !133147 (closed)
added 1028 commits
-
73e1de0e...72ab51bf - 1027 commits from branch
master
- 065bc3d3 - Add instance GCP logging streaming destinations
-
73e1de0e...72ab51bf - 1027 commits from branch
requested review from @eread
- Resolved by Nate Rosandich
- Resolved by Nate Rosandich
- Resolved by Nate Rosandich
- Resolved by Nate Rosandich
added Technical Writing docsfeature labels
removed review request for @eread
requested review from @eread
added 638 commits
-
0572a03b...18878b90 - 636 commits from branch
master
- 15dc8d82 - Add instance GCP logging streaming destinations
- 4b606843 - Apply 4 suggestion(s) to 1 file(s)
-
0572a03b...18878b90 - 636 commits from branch
@eread
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @eread
@nrosandich Some end-to-end (E2E) tests should run based on the stage label.
Please start the
trigger-omnibus-and-follow-up-e2e
job in theqa
stage and ensure tests in thefollow-up-e2e:package-and-test-ee
pipeline pass before this MR is merged. (E2E tests are computationally intensive and don't run automatically for every push/rebase, so we ask you to run this job manually at least once.)To run all E2E tests, apply the pipeline:run-all-e2e label and run a new pipeline.
E2E test jobs are allowed to fail due to flakiness. See current failures at the latest pipeline triage issue.
Once done, apply the
emoji on this comment.Team members only: for any questions or help, reach out on the internal
#quality
Slack channel.added 214 commits
-
4b606843...5ae6480b - 212 commits from branch
master
- 611bcf4a - Add instance GCP logging streaming destinations
- 512c8f18 - Apply 4 suggestion(s) to 1 file(s)
-
4b606843...5ae6480b - 212 commits from branch
added 1 commit
- 24bafbb2 - Add instance GCP logging streaming destinations
- Resolved by Zack Cuddy
requested review from @cam.x
- Resolved by Nate Rosandich
@jmontal can you please do the groupcompliance and initial frontend review?
requested review from @jmontal
mentioned in issue #415731 (closed)
- Resolved by Nate Rosandich
- Resolved by Nate Rosandich
- Resolved by Zack Cuddy
mentioned in issue #428113 (closed)
- Resolved by Zack Cuddy
enabled an automatic merge when the pipeline for 4e2c6c27 succeeds
mentioned in commit 03843c4b
added workflowstaging-canary label and removed workflowblocked label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2517 (merged)