Make BuildSuccessWorker no-op
What does this MR do and why?
BuildSuccessWorker
was deprecated in !127079 (merged). It is no longer called anywhere.
This MR makes sure that BuildSuccessWorker
does not perform any operations.
Screenshots or screen recordings
N/A
How to set up and validate locally
N/A
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #419911 (closed)
Merge request reports
Activity
changed milestone to %16.4
assigned to @partiaga
removed workflowready for development label
- A deleted user
added backend label
1 Warning ⚠ You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Ian Baum (
@ibaum
) (UTC-5, 15 hours behind@partiaga
)Kerri Miller (
@kerrizor
) (UTC-5, 15 hours behind@partiaga
)~"Verify" Reviewer review is optional for ~"Verify" Marius Bobin (
@mbobin
) (UTC+3, 7 hours behind@partiaga
)Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 DangerEdited by Ghost UserAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
❗ test report for 892a6c4aexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Govern | 36 | 0 | 0 | 0 | 36 | ✅ | | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Create | 46 | 0 | 1 | 0 | 47 | ✅ | | Data Stores | 22 | 0 | 0 | 1 | 22 | ❗ | | Manage | 13 | 0 | 1 | 0 | 14 | ✅ | | Verify | 8 | 0 | 0 | 0 | 8 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 184 | 0 | 4 | 1 | 188 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Useradded maintenanceremoval label
- Resolved by Shinya Maeda
Hi @shinya.maeda, would you mind giving this the initial backend review?
BuildSuccessWorker
doesn't have a spec. I decided not to add one because it's being no-oped and deprecated later, but I'm happy to add a spec if you think we should🙂
requested review from @shinya.maeda
👋 @shinya.maeda
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
enabled an automatic merge when the pipeline for 2c1b2744 succeeds
mentioned in commit 8621c40b
added workflowstaging-canary label