Skip to content

Move Deployment logic from Ci::Build to Ci::Deployable module

Shinya Maeda requested to merge move-deployment-logic-to-processable into master

What does this MR do and why?

This is a preliminary work for Support `environment` keyword with `trigger` ke... (#369061 - closed) that modulizes deployment/environment related logic into Ci::Deployable. This later allows us to include the module in Ci::Bridge.

This MR does NOT change the business logic of the features. It's just moving code from Ci::Build to Ci::Deployable.

A few notes:

  • BuildSuccessWorker contains Deployment/Environment logic only, thus we'll move it to Environments::StopJobSuccessWorker for the sake of Use namespaces to define bounded contexts.
  • Tests are moved to deployable_shared_examples.rb without any modifications in order to make reviews easier. This will be followed-up in a separate MR.
  • Rubocop offences are not addressed in this MR in order to make reviews easier. This will be followed-up in a separate MR.
  • You can find PoC in !124562 (closed)

Screenshots or screen recordings

No changes

How to set up and validate locally

No changes

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Shinya Maeda

Merge request reports