Skip to content
Snippets Groups Projects

Fix some rubocops for gitlab-http and fix the email

Merged Furkan Ayhan requested to merge 415686-gitlab-http-followup-1 into master

What does this MR do and why?

This is a follow-up MR from !125024 (merged). Related to #415686 (closed)

It fixes some Rubocop failures and fixes the email section.

Issue / MR Link
Main issue #415686 (closed)
First MR to initialize the gem !125024 (merged)
Small fixes =HERE= !131612 (merged)
POC !131644 (closed)
Enabling on GitLab !132238 (merged)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Furkan Ayhan

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Furkan Ayhan
  • mentioned in issue #424940 (closed)

  • Contributor
    2 Warnings
    :warning: bab441dd: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
    :warning: There were no new or modified feature flag YAML files detected in this MR.

    If the changes here are already controlled under an existing feature flag, please add
    the feature flagexists. Otherwise, if you think the changes here don't need
    to be under a feature flag, please add the label feature flagskipped, and
    add a short comment about why we skipped the feature flag.

    For guidance on when to use a feature flag, please see the documentation.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend Rutger Wessels current availability (@rutgerwessels) (UTC+2, same timezone as @furkanayhan) Marc Shaw current availability (@marc_shaw) (UTC+2, same timezone as @furkanayhan)

    Please check reviewer's status!

    • available Reviewer is available!
    • unavailable Reviewer is unavailable!

    Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Furkan Ayhan requested review from @rymai

    requested review from @rymai

  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :exclamation: test report for bab441dd

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Create      | 38     | 0      | 0       | 0     | 38    | ✅     |
    | Plan        | 51     | 0      | 0       | 0     | 51    | ✅     |
    | Data Stores | 20     | 0      | 0       | 1     | 20    | ❗     |
    | Govern      | 33     | 0      | 1       | 0     | 34    | ✅     |
    | Manage      | 12     | 0      | 1       | 0     | 13    | ✅     |
    | Verify      | 8      | 0      | 0       | 0     | 8     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 162    | 0      | 2       | 1     | 164   | ❗     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • Rémy Coutable resolved all threads

    resolved all threads

  • Rémy Coutable approved this merge request

    approved this merge request

  • :wave: @rymai, thanks for approving this merge request.

    This is the first time the merge request has been approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Rémy Coutable resolved all threads

    resolved all threads

  • Rémy Coutable enabled an automatic merge when the pipeline for 22cfb904 succeeds

    enabled an automatic merge when the pipeline for 22cfb904 succeeds

  • merged

  • Rémy Coutable mentioned in commit 59e55988

    mentioned in commit 59e55988

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading