Fix some rubocops for gitlab-http and fix the email
What does this MR do and why?
This is a follow-up MR from !125024 (merged). Related to #415686 (closed)
It fixes some Rubocop failures and fixes the email section.
Issue / MR | Link |
---|---|
Main issue | #415686 (closed) |
First MR to initialize the gem | !125024 (merged) |
Small fixes | =HERE= !131612 (merged) |
POC | !131644 (closed) |
Enabling on GitLab | !132238 (merged) |
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.4
assigned to @furkanayhan
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Rémy Coutable
- Resolved by Rémy Coutable
mentioned in issue #424940 (closed)
2 Warnings bab441dd: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. There were no new or modified feature flag YAML files detected in this MR. If the changes here are already controlled under an existing feature flag, please add
the feature flagexists. Otherwise, if you think the changes here don't need
to be under a feature flag, please add the label feature flagskipped, and
add a short comment about why we skipped the feature flag.For guidance on when to use a feature flag, please see the documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Rutger Wessels ( @rutgerwessels
) (UTC+2, same timezone as@furkanayhan
)Marc Shaw ( @marc_shaw
) (UTC+2, same timezone as@furkanayhan
)Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger - Resolved by Rémy Coutable
@rymai Could you review and merge this refactoring?
requested review from @rymai
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for bab441dd expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 38 | 0 | 0 | 0 | 38 | ✅ | | Plan | 51 | 0 | 0 | 0 | 51 | ✅ | | Data Stores | 20 | 0 | 0 | 1 | 20 | ❗ | | Govern | 33 | 0 | 1 | 0 | 34 | ✅ | | Manage | 12 | 0 | 1 | 0 | 13 | ✅ | | Verify | 8 | 0 | 0 | 0 | 8 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 162 | 0 | 2 | 1 | 164 | ❗ | +-------------+--------+--------+---------+-------+-------+--------+
@rymai
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
enabled an automatic merge when the pipeline for 22cfb904 succeeds
mentioned in commit 59e55988