Skip to content

Remove role required before action

Doug Stull requested to merge 411858-remove-role-required-redirect into master

What does this MR do and why?

Remove role required before action

  • CE no longer need to fill out the welcome form.
  • EE will still be directed to welcome page, but will eventually be removed via next MR in !129528 (merged)
  • EE with SaaS is forced to fill it out via ensure_onboarding paradigm

Screenshots or screen recordings

See screenshots on #411858 (closed) an further description

How to set up and validate locally

coverage in spec/features/users/signup_spec.rb and ee/spec/features/registrations/saas show full process - one way to validate seen below

  1. Register as a new user.
  2. Confirm email by finding the confirmation path from last User created in rails console
    • Rails.application.routes.url_helpers.user_confirmation_path(confirmation_token: User.last.confirmation_token)
  3. Verify landing in welcome page after verification/sign up.
  4. Attempt to go to root path (/)
  5. Validate not redirected back to welcome. If you are, it is because you are setup to emulate SaaS and you should turn that off to verify here.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #411858 (closed)

Edited by Doug Stull

Merge request reports